Bug 1468877
Summary: | Review Request: python-fiona - read and write spatial data files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Elliott Sales de Andrade <quantum.analyst> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-09-28 19:57:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1468873 | ||
Bug Blocks: | 1468995 |
Description
Elliott Sales de Andrade
2017-07-09 09:08:28 UTC
Some informal reviews I have done: https://bugzilla.redhat.com/show_bug.cgi?id=1440992#c1 https://bugzilla.redhat.com/show_bug.cgi?id=1440971#c1 https://bugzilla.redhat.com/show_bug.cgi?id=1433757#c2 https://bugzilla.redhat.com/show_bug.cgi?id=1368855#c14 It's generally better to not repeat the package name in Summary, since most of the time the package name is shown separately anyway (by dnf list, etc.). The %description is also a bit off in my opinion: the most important part is what formats it can read and write. I'd move the last sentence to the beginning and add some information about what formats it supports (I don't know how many there are, but if it's possible, I'd just list them. This has the advantage that it'll show up in searches.) I'd also recommend the trick from https://bugzilla.redhat.com/show_bug.cgi?id=1468873#c2 to avoid repeating the lengthy description text. But those are all non-blocking issues. rpmlint: python3-fiona.x86_64: W: no-manual-page-for-binary fio That's not mandatory. Otherwise rpmlint says nothing useful. + package name is OK + license is acceptable for Fedora (BSD) + license is specified correctly + builds and install OK + %check is present and passes + modern python packaging template is used + R/P/BR look correct + %python_provide macros are present + %license macro is used + /usr/bin/fio runs OK Package is APPROVED. That's the first paragraph from PyPI: https://pypi.python.org/pypi/Fiona Unfortunately, I cannot find a straightforward list of all supported formats. Yes. It's also a bad description for pypi. (It contains too much "advertisting", and doesn't really give the one to two sentence summary of what this package "does".)
>>> print('\n'.join(sorted(fiona.drivers().drivers())))
ARCGEN
AVCBin
AVCE00
AeronavFAA
AmigoCloud
BNA
CSV
CSW
Carto
Cloudant
CouchDB
DGN
DXF
EDIGEO
ESRI Shapefile
ElasticSearch
GFT
GML
GPKG
GPSBabel
GPSTrackMaker
GPX
GeoJSON
GeoRSS
Geoconcept
Geomedia
HTF
HTTP
Idrisi
Interlis 1
Interlis 2
JML
JP2OpenJPEG
JPEG2000
KML
LIBKML
MSSQLSpatial
MapInfo File
Memory
MySQL
NAS
ODBC
ODS
OGR_DODS
OGR_GMT
OGR_OGDI
OGR_PDS
OGR_SDTS
OGR_VRT
OSM
OpenAir
OpenFileGDB
PCIDSK
PDF
PGDUMP
PGeo
PLSCENES
PostgreSQL
REC
S57
SEGUKOOA
SEGY
SQLite
SUA
SVG
SXF
Selafin
TIGER
UK .NTF
VDV
VFK
WAsP
WFS
Walk
XLS
XLSX
XPlane
netCDF
That's way too many to list :(
Can you build this? It's the last thing blocking python-geopandas. Still need SCM. No-one has responded: https://pagure.io/releng/issue/6976 (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-fiona python-fiona-1.7.8-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0180c5666a python-fiona-1.7.8-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-89f565ab8d python-fiona-1.7.8-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-89f565ab8d python-fiona-1.7.8-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0180c5666a python-fiona-1.7.8-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. python-fiona-1.7.8-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |