Bug 1476822
Summary: | scripts: invalid test in S32gluster_enable_shared_storage.sh | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Kaleb KEITHLEY <kkeithle> |
Component: | scripts | Assignee: | Kaleb KEITHLEY <kkeithle> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.11 | CC: | bugs |
Target Milestone: | --- | Keywords: | Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.11.3 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | 1476785 | Environment: | |
Last Closed: | 2017-08-24 14:46:21 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1476785, 1476827, 1478498 | ||
Bug Blocks: | 1466024, 1473776, 1476819 |
Description
Kaleb KEITHLEY
2017-07-31 14:25:53 UTC
REVIEW: https://review.gluster.org/17927 (scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh) posted (#1) for review on release-3.11 by Kaleb KEITHLEY (kkeithle) COMMIT: https://review.gluster.org/17927 committed in release-3.11 by Shyamsundar Ranganathan (srangana) ------ commit d42af66b39b9ce2a02839479d3e95225edaf718a Author: Kaleb S. KEITHLEY <kkeithle> Date: Mon Jul 31 10:27:45 2017 -0400 scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh test(1) man pages says -eq is for INTEGER compares, and = is for string compares. Also note the comment that -a and -o are ambiguous and to use test && test or test || test instead. This bug has existed since 2015! (yikes) Found while testing localtime logging and running glusterd in the foreground. Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84 BUG: 1476822 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> Reviewed-on: https://review.gluster.org/17927 Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.3, please open a new bug report. glusterfs-3.11.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-August/000081.html [2] https://www.gluster.org/pipermail/gluster-users/ |