Bug 1478498

Summary:	scripts: invalid test in S32gluster_enable_shared_storage.sh
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	scripts	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.5	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1476785	Environment:
Last Closed:	2017-08-21 13:42:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1476785
Bug Blocks:	1468046, 1476819, 1476822, 1476827

Description Kaleb KEITHLEY 2017-08-04 17:17:06 UTC

+++ This bug was initially created as a clone of Bug #1476785 +++

Description of problem:

line 5:

   if [ ! "$key" -eq "enable-shared-storage" -o "$key" -eq "cluster.enable-shared-storage" ]; then

man page for test(1) says -eq takes two integer arguments.

The correct syntax should be 
   
   if [ "$key" != "enable-shared-storage" -o "$key" = "cluster.enable-shared-storage" ]; then

Or is it supposed to be:

   if [ ! ( "$key" = "enable-shared-storage" -o "$key" = "cluster.enable-shared-storage" ) ]; then


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-07-31 09:53:01 EDT ---

REVIEW: https://review.gluster.org/17925 (scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Worker Ant on 2017-08-01 13:41:29 EDT ---

COMMIT: https://review.gluster.org/17925 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 1ae3747608797445c4a59569f93edc331e3626b0
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Mon Jul 31 09:48:09 2017 -0400

    scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh
    
    test(1) man pages says -eq is for INTEGER compares, and = is for
    string compares.
    
    Also note the comment that -a and -o are ambiguous and to use
     test && test or test || test instead.
    
    This bug has existed since 2015! (yikes)
    
    Found while testing localtime logging and running glusterd in the
    foreground.
    
    Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84
    BUG: 1476785
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: https://review.gluster.org/17925
    Reviewed-by: Niels de Vos <ndevos>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-08-04 17:28:54 UTC

REVIEW: https://review.gluster.org/17978 (scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh) posted (#1) for review on release-3.10 by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2017-08-11 10:54:35 UTC

COMMIT: https://review.gluster.org/17978 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 27571cf3cdc83b609bcabf7d0459d61e29abf681
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Fri Aug 4 13:27:36 2017 -0400

    scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh
    
    test(1) man pages says -eq is for INTEGER compares, and = is for
    string compares.
    
    Also note the comment that -a and -o are ambiguous and to use
    test && test or test || test instead.
    
    This bug has existed since 2015! (yikes)
    
    Found while testing localtime logging and running glusterd in the
    foreground.
    
    Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84
    BUG: 1478498
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: https://review.gluster.org/17978
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Nigel Babu <nigelb>

Comment 3 Shyamsundar 2017-08-21 13:42:02 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.5, please open a new bug report.

glusterfs-3.10.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-August/000079.html
[2] https://www.gluster.org/pipermail/gluster-users/