Bug 1516328

Summary:	Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins
Product:	[Fedora] Fedora	Reporter:	Jaroslav Prokop <jar.prokop>
Component:	Package Review	Assignee:	Vít Ondruch <vondruch>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ilya.gradina, package-review, vondruch
Target Milestone:	---	Flags:	vondruch: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-guard-compat-1.2.1-1.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-18 15:27:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1268696, 1268698

Description Jaroslav Prokop 2017-11-22 13:47:03 UTC

Spec URL: https://gitlab.com/jackorp/rubygem-guard-compat/raw/0c4eecca79b92c92086753573328d5255370e400/rubygem-guard-compat.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-guard-compat/fedora-rawhide-x86_64/00678214-rubygem-guard-compat/rubygem-guard-compat-1.2.1-1.fc28.src.rpm
Description: Helps creating valid Guard plugins and testing them.
Fedora Account System Username: jackorp
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23300282

This is my first package so please be nice to me.

Comment 1 Vít Ondruch 2017-11-22 13:49:16 UTC

I'll take it for a review and I can sponsor you as well.

Comment 2 Ilia Gradina 2017-11-23 18:14:17 UTC

*** Bug 1268695 has been marked as a duplicate of this bug. ***

Comment 3 Vít Ondruch 2017-11-27 14:55:34 UTC

* Hidden files
  - rpmlint complains:

~~~
rubygem-guard-compat.noarch: W: hidden-file-or-dir /usr/share/gems/gems/guard-compat-1.2.1/.rubocop_todo.yml
~~~

    but it would be probably good idea to get rid of all the hidden file by one
    sweep, e.g. to replace:

~~~
%exclude %{gem_instdir}/.gitignore
%exclude %{gem_instdir}/.rubocop.yml
%{gem_instdir}/.rubocop_todo.yml
%exclude %{gem_instdir}/.rspec
~~~

    by just single line:

~~~
%exclude %{gem_instdir}/.*
~~~

* Missing URL
  - There is no URL tag in the .spec file. There should probably be some, e.g.:

~~~
URL: https://github.com/guard/guard-compat
~~~

Otherwise the package looks good. Please fix these two nits and I'll approve this package.

Comment 4 Jaroslav Prokop 2017-11-28 20:34:42 UTC

Updated spec URL: https://gitlab.com/jackorp/rubygem-guard-compat/raw/fbb428b56066c1490c53750e4c74811bb9aae5b7/rubygem-guard-compat.spec

Updated srpm URL: https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-guard-compat/fedora-rawhide-x86_64/00681701-rubygem-guard-compat/rubygem-guard-compat-1.2.1-1.fc28.src.rpm

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23440326

Comment 5 Vít Ondruch 2017-12-14 17:35:06 UTC

Thx. I can't see any other issue with the package => APPROVED. Please continue
with the SCM request, import and build of the package:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Pack
age_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

Comment 6 Gwyn Ciesla 2017-12-15 18:20:14 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-guard-compat