Bug 1632194
| Summary: | psi-plus - remove minizip-compat dependency | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrik Novotný <panovotn> | |
| Component: | psi-plus | Assignee: | Vitaly <vitaly> | |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | rawhide | CC: | drizt72, Neustradamus, panovotn, projects.rg | |
| Target Milestone: | --- | Keywords: | FutureFeature, Reopened, Upstream | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| URL: | https://github.com/psi-im/psi/issues/388 | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1699574 (view as bug list) | Environment: | ||
| Last Closed: | 2021-02-20 13:32:52 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1699574, 1699575 | |||
| Bug Blocks: | 1632208 | |||
|
Description
Patrik Novotný
2018-09-24 10:46:20 UTC
You did that change by yourself. Please undo also. https://src.fedoraproject.org/rpms/psi-plus/c/94ac1caaff7a20f25a42de4dacadfd0d013c3b55?branch=master I'll try to clarify the situation. What happened is that I renamed the minizip package (part of zlib) to minizip-compat. Then a new minizip package build from maintained fork of the original minizip library has been introduced. In the commit you're referring to I'm only preserving the dependency on the old minizip - now packaged as minizip-compat. So this change is only cosmetic and the functionality is unchanged. The subject of this BZ is to actually change the dependency to the new minizip package. Either by porting psi-plus or by bundling the old minizip. The intent is to remove the old minizip library from the zlib package (now minizip-compat). Please can you file a PR? I could review and apply. Sorry for the long delay. Sorry, I still fail to see an issue. There's no FTBFS in rawhide and I don't know what to fix. Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=32047025 Please feel free to reopen this bug if you think there's still an issue. https://src.fedoraproject.org/rpms/psi-plus/c/94ac1caaff7a20f25a42de4dacadfd0d013c3b55?branch=master Maybe? psi-plus version 1.4 successfully builds with separate minizip package as dependency. No idea why there wasn't any change done in F29. Reverting your commit with the next build. Right, this should get fixed by upstream. Why isn't a new minizip pkg available in F29? https://src.fedoraproject.org/rpms/psi/blob/master/f/psi.spec#_38 Filed to upstream. Upstream refuses to unbundle with the reasons given there in the issue. https://github.com/psi-im/libpsi/issues/13 Main discussion: https://github.com/psi-im/psi/issues/388 This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. new maintainer. Psi-plus is already uses its own bundled minizip. It has no depencency on minizip-compat-devel anymore. |