Bug 1803303
| Summary: | Review Request: golang-github-alecaivazis-survey - A golang library for building interactive prompts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joe Doss <joe> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | bcotton, eclipseo, package-review, ppisar |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-09-30 20:20:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1803302 | ||
|
Description
Joe Doss
2020-02-15 04:33:11 UTC
- Why not packaging 2.0.5? - tag is not needed here, only: Version: 2.0.0 - summary is too long, need to be below 80 characters: Summary: Build interactive prompts with full support for windows and posix terminals - License ok - Builds in mock - No rpmlint errors - Tests are ok - Conforms to Packaging Guidelines Package approved. Please package the latest version and fix the above issues. - Version updated. - Tag removed. - Summary trimmed down. https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01246624-golang-github-alecaivazis-survey/golang-github-alecaivazis-survey.spec https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x86_64/01246624-golang-github-alecaivazis-survey/golang-github-alecaivazis-survey-2.0.5-1.fc31.src.rpm Updated version to 2.1.1 https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01708734-golang-github-alecaivazis-survey/golang-github-alecaivazis-survey.spec https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01708734-golang-github-alecaivazis-survey/golang-github-alecaivazis-survey-2.1.1-1.fc33.src.rpm Joe, the package was approved in #comment 1. You can go on with adding it into Fedora. fedpkg request-repo golang-github-alecaivazis-survey 1803303 Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago Either open a new request, or reset this one the original state (NEW state, default assignee, unset fedora-review flag). Whatever suits you better. Petr, Can you reset the fedora-review+ flag for me? I did this and the request got rejected. https://pagure.io/releng/fedora-scm-requests/issue/30141 I reset this review request to initial state as the package must be reviewed again because the previous review expired. Joe, if you can provide updated locations for the spec an srpm, I'll give it a re-review. Nevermind. I see them in comment 3. I'll do the review now. The binary rpm does not build from source due to unmet dependencies: No matching package to install: 'golang(github.com/Netflix/go-expect)' No matching package to install: 'golang(github.com/hinshun/vt10x)' That doesn't look like a new change, am I missing something? These other dependency packages also expired and I just got the SCM request resubmitted so I can move forward on them. Once I get them in rawhide you can give this a try. https://bugzilla.redhat.com/show_bug.cgi?id=1803309 https://pagure.io/releng/fedora-scm-requests/issue/30228 https://bugzilla.redhat.com/show_bug.cgi?id=1803312 https://pagure.io/releng/fedora-scm-requests/issue/30229 Flag reset. Closing on request https://bugzilla.redhat.com/show_bug.cgi?id=1803302#c16 |