Bug 1803303 - Review Request: golang-github-alecaivazis-survey - A golang library for building interactive prompts
Summary: Review Request: golang-github-alecaivazis-survey - A golang library for build...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1803302
TreeView+ depends on / blocked
 
Reported: 2020-02-15 04:33 UTC by Joe Doss
Modified: 2021-09-30 20:20 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-30 20:20:26 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Comment 1 Robert-André Mauchin 🐧 2020-02-16 23:13:49 UTC
 - Why not packaging 2.0.5?

 - tag is not needed here, only:

Version:                2.0.0

 - summary is too long, need to be below 80 characters:

Summary:        Build interactive prompts with full support for windows and posix terminals


 - License ok
 - Builds in mock
 - No rpmlint errors
 - Tests are ok
 - Conforms to Packaging Guidelines

Package approved. Please package the latest version and fix the above issues.

Comment 4 Petr Pisar 2020-10-23 12:02:36 UTC
Joe, the package was approved in #comment 1. You can go on with adding it into Fedora.

Comment 5 Joe Doss 2020-10-27 15:39:59 UTC
fedpkg request-repo golang-github-alecaivazis-survey 1803303
Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago

Comment 6 Petr Pisar 2020-10-29 07:37:45 UTC
Either open a new request, or reset this one the original state (NEW state, default assignee, unset fedora-review flag). Whatever suits you better.

Comment 7 Joe Doss 2020-10-29 15:48:14 UTC
Petr, 

Can you reset the fedora-review+ flag for me? I did this and the request got rejected.

https://pagure.io/releng/fedora-scm-requests/issue/30141

Comment 8 Petr Pisar 2020-10-29 16:12:49 UTC
I reset this review request to initial state as the package must be reviewed again because the previous review expired.

Comment 9 Ben Cotton 2020-10-30 20:41:29 UTC
Joe, if you can provide updated locations for the spec an srpm, I'll give it a re-review.

Comment 10 Ben Cotton 2020-10-30 20:42:36 UTC
Nevermind. I see them in comment 3. I'll do the review now.

Comment 11 Ben Cotton 2020-10-30 21:06:04 UTC
The binary rpm does not build from source due to unmet dependencies:

No matching package to install: 'golang(github.com/Netflix/go-expect)'
No matching package to install: 'golang(github.com/hinshun/vt10x)'

That doesn't look like a new change, am I missing something?

Comment 12 Joe Doss 2020-11-03 15:49:52 UTC
These other dependency packages also expired and I just got the SCM request resubmitted so I can move forward on them. Once I get them in rawhide you can give this a try.

https://bugzilla.redhat.com/show_bug.cgi?id=1803309
https://pagure.io/releng/fedora-scm-requests/issue/30228

https://bugzilla.redhat.com/show_bug.cgi?id=1803312
https://pagure.io/releng/fedora-scm-requests/issue/30229

Comment 13 Robert-André Mauchin 🐧 2020-11-05 06:57:52 UTC
Flag reset.

Comment 14 Joe Doss 2021-09-30 20:20:26 UTC
Closing on request https://bugzilla.redhat.com/show_bug.cgi?id=1803302#c16


Note You need to log in before you can comment on or make changes to this bug.