Bug 185376

Mayank, assigning to you:

1. Can you create a patch for /usr/share/X11/locale/locale.{alias,dir} with all
those new locale {as,kn,ml,or,ur,te}_IN and attach here?

2. Create a full modified files for translators' machines.

Hi, the patch files for locale.dir, locale.alias are attached.

- Modifications to locale.alias
# added by majain
{as,kn,ml,or,ur,te}_IN.utf8                    {as,kn,ml,or,ur,te}_IN.UTF-8
{as,kn,ml,or,ur,te}_IN.UTF-8                   {as,kn,ml,or,ur,te}_IN.UTF-8
# end modification

- Modifications to locale.dir
# added by majain
en_US.UTF-8/XLC_LOCALE                 {as,kn,ml,or,ur,te}_IN.UTF-8
# end modification

Created attachment 126092 [details]
Patch for /usr/share/X11/locale/locale.alias

Created attachment 126093 [details]
Patch for /usr/share/X11/locale/locale.dir

Hi,

The patch for xorg-x11-6.8.2-62.src.rpm (locale.dir, locale.alias) is attached.
Please have a look & revert if something's out of order.

Thanks.

Created attachment 126150 [details]
Patch for indic locales

Updated bug #3646 - https://bugs.freedesktop.org/show_bug.cgi?id=3646
at freedesktop bugzilla.

Added bugs 177295, 177370, 177371, 177372, 177378, 177379 as dependence for this
bug.

Updates : After patching the locale.{alias,dir}

as - Locale not supported by C library
kn - locale not supported by Xlib
ml - locale not supported by Xlib
or - Locale not supported by C library
ur - Locale not supported by C library
te - locale not supported by Xlib

Some findings

as - http://www.redhat.com/archives/fedora-i18n-list/2005-October/msg00002.html
or - http://oriya.sarovar.org/docs/getting_started/node35.html#url:rp-locale

Bugs of interest
Oriya locale - https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183728
Assamese locale - https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183729

Assamese -
Runa, can you please verify that as_IN locale mentioned in
http://www.redhat.com/archives/fedora-i18n-list/2005-October/msg00002.html is fine.

Oriya -
Subhranshu, can you please verify this locale -
http://oriya.sarovar.org/download/indicsort.tar.gz

Urdu -
Aalam, lets finish this task asap :)

If you have already verified the locale, kindly add you confirmation here.

Thanks guys :)
Mayank

Created attachment 130179 [details]
Oriya_Locale_Definition

Mayank,

This is the modified file. Just go through it.

Regards,
Subhransu

Subhransu, please verify it.
Thanks.

> Oriya -
> Subhranshu, can you please verify this locale -
> http://oriya.sarovar.org/download/indicsort.tar.gz
> 

Mayank,

The above file is verified :)

Cheers,
Subhransu

http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/localedata/locales/?cvsroot=glibc#dirlist
as_IN & or_IN locales already added 2 days ago.

te_IN is already present in FC5

kn_IN present in FC5

Created attachment 130184 [details]
Urdu locale file is attached

Thanks Aalam.

Mayank, please post glibc locale seperately from this X locale bug. Also would
you please follow up with the xorg upstream and see when would they include the
patch.

X Team, please consider to include the patch in Comment #6 in the meanwhile for
FC6. Moving back to ASSIGNED as it is not fixed in the package, and re-assigning
this bug back to you guys, thank you.

Created attachment 130223 [details]
assamese localedef file

Assamesed localedef file attached.

Please file a feature request for this in X.Org bugzilla at
http://bugs.freedesktop.org in the "xorg" component.  Once it has been
reviewed by upstream, accepted, and committed to CVS, we will review it
for consideration for FC6.

Please paste the upstream bug URL here once you've filed the report,
so we can track it.

Thanks in advance.

Hi Mike, I've requested the upstream to review the patch... but no response from
them. I'll add the upstream bz # in the reference... though the bug number is
available in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185376#c7

Thanks,
Mayank

The patch that was submitted upstream is for 6.8.x.  You should regenerate
it for the current X.Org CVS head to ensure someone reviews it.  If someone
were to try and apply it to cvs head, and it fails, they may fix it up
themselves, or they may just leave the bug sit there until someone else
updates it.

I've added a request in the upstream bug report.  If you do not receive a
response within a few days of attaching a patch against the current
release, please post a message to xorg.org to discuss this
with the developers actively, so that they do actually incorporate it into
the X codebase sooner rather than later.

We have a policy to only accept patches into our X packages which have been
accepted upstream and committed to CVS (or GIT depending..), or to which
upstream has reviewed and accepted the patch and committed themselves to
putting it into the repository at a later date.

It is critically important that these type of things get officially endorsed
by X.Org first, so that we do not end up having to patch them into our own
sources endlessly, and port them forward every OS release.  We don't want
to have the same situation happen like we had for Chinese GB18030 support,
which was added to our packaging, but rejected upstream for 4+ years, causing
us to have to port it forward every OS release.

Please work with upstream on the mailing lists and in bugzilla to ensure
this doesn't fall between the cracks upstream.

Thanks in advance.

Sure Mike.
I'll update the patch asap.

Thanks for the explanation,
Mayank

Created attachment 131878 [details]
latest patch for 6 indic locales

Hi Mike,
The patch, adapted to latest codebase (cvs) is attached, kindly have a look.

Thanks,
Mayank

(In reply to comment #33)
> Created an attachment (id=131878) [edit]
> latest patch for 6 indic locales
> 
> Hi Mike,
> The patch, adapted to latest codebase (cvs) is attached, kindly have a look.

Once upstream has accepted them, we'll apply them.  We really need these
type of things to be accepted upstream first.  I've added a comment
upstream about it.  All we can do now is wait for upstream to review
it and commit it, or comment about it.

It's best continuing to engage the upstream developers on the xorg mailing
list until someone has reviewed it.

Thanks Mike and Mayank for the effort to include it into upstream. Are we on
track to build it into our RH package by FC6-T2? This is trivial but extremely
important patch for language support - if we miss this train - that would be it.

If you wouldn't mind, let's re-open this to track this effort - thanks in advance!

Sure. Thanks Mike for all the support.

Ok guys, the patch is committed upstream now so I have added it to
our package and built it for rawhide.  Thanks again for getting this
included upstream first.

Thanks Mike :)

Mayank

Some modification is required in the Oriya locale file.

So kindly send me the one you have with you now.

Cheers,
Subhu

Removing runab#redhat.com & adding as LM, aphukan to CC list

Subhranshu, your file is here... pls download this, make your changes & attach 
the new file in bugzilla so I can create a patch & then ping Mike to update the 
CVS.

http://sources.redhat.com/cgi-bin/cvsweb.cgi/~checkout~/libc/localedata/locales/
or_IN?rev=1.2.2.3&content-type=text/plain&cvsroot=glibc

Thanks,
Mayank

OOps, I'm sorry, Comments from C#39 to C#41 are supposed to go in RH bug 
#200230 or a new bug.

Subhranshu, this bug is not regarding locale data errors.

Sorry for reopening this bug, closing it back with resolution as CURRENTRELEASE.

Thanks,
Mayank

There are some changes necessary in the locale definition file. I am working on
it. Will submit the complete file on Monday.

Created attachment 142567 [details]
Corrected Assamese locale definition file

Here is the correct locale definition that I have made. please revert back to
me for any changes.

Amit, this bug is for X locale def, not glibc def. If you have any improvement
on glibc, would you please modify the source localedef and ask one of our
developers to help you make a patch against it - and then submit a new bug for
it. I am closing this bug back to RAWHIDE. Thanks.