Bug 192583 (php-pear-XML-Parser)
Summary: | Review Request: php-pear-XML-Parser - XML parsing class based on PHP's bundled expat | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | petersen:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-04 16:53:20 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 197420 |
Description
Remi Collet
2006-05-21 07:56:41 UTC
Not a Review but some hints on improving SPEC:- 1) Remove Provides tag RPM will generate an appropriate Provides: entry itself. 2) rpmlint gives error on using License: PHP License 3) Add some Documnetation Files like README, INSTALL Also when i built repm from SPEC i got warning: pear/XML_Parser requires package "pear/PEAR" 1/ Provides follow php guidelines http://fedoraproject.org/wiki/Packaging/PHP 2/ it's a rpmlint bug, see Bug #191078 3/ none provided upstream (only examples), i've also add the Licence. 4/ this warning is "normal". Useful to check the "Requires" in spec file. I will do a formal review on this package but you will not be able to check it in until you are sponsered with bug #190007 MUST ITEM CHECKLIST: - rpmlint output: W: php-pear-XML-Parser invalid-license PHP License W: php-pear-XML-Parser dangerous-command-in-%post install W: php-pear-XML-Parser invalid-license PHP License Warnings can be ignored - package is named according to php packaging naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package is licensed with open source compatible license - license field matches actual license - source contains license file in %doc - spec file is in American English (and french) - spec file is legible - sources match upstream f4a491b49843f8257df8ded088854db3 XML_Parser-1.2.7.tgz - package successfully compiles and builds on FC-5 x86_64 O This package is missing: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 - package does not use locales - package does not contain shared libraries in default paths (no need to run ldconfig) - package is not relocatable - package owns all directories it creates - package does not contain any duplicate %files - permissions are set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not have large documentation - package does not include header files or static libraries - package does not use pkgconfig files - package does not contain library with suffix - package does not require a devel subpackage - package does not contain any .la files - package is not a gui and does not need a .desktop file - package does not own files or directories owned by other packages MUST - Must Add: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 - Explain why adding || : in %post and %postun sections was added, should we not fail if this step fails? - Change %defattr to (-,root,root,-) - Remove dist tages in changelog version numbers Also, add php >= 4.2.0 to the Requires to meet PHP packaging guidelines Spec: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser.spec SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-1.2.7-2.fc5.src.rpm Mock: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-build.log Changes: - use new macros from /etc/rpm/macros.pear - own /usr/share/pear/XML - require php >= 4.2.0 Hi Remi, can you update the %setup and %install sections to the new cleaner way shown here: https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=135449 More info at bug #198706 Spec: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser.spec SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-1.2.7-3.fc5.src.rpm Mock: http://remi.collet.free.fr/rpms/extras/php-pear-XML-Parser-build.log Changes: - new and simpler %%prep and %%install Looks good, approved. please change %defattr(-,root,root) to defattr(-,root,root,-) after importing into cvs. Package Change Request ====================== Package Name: php-pear-XML-Parser New Branches: EL-5 done |