Bug 2038636
| Summary: | Review Request: rust-nu-path - Path handling library for Nushell | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davide, decathorpe, package-review |
| Target Milestone: | --- | Flags: | davide:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-04-17 22:21:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2038637, 2038648, 2038652, 2038653, 2038736, 2038788 | ||
|
Description
Michel Lind
2022-01-09 05:49:26 UTC
There's no LICENSE file in published crates. That is not acceptable wrt/ the MIT license, as it requires redistributed sources to contain the license text. If there's a license file in the upstream repository, you can include it from there as a second Source file, until upstream fixes things and published crates contain the LICENSE file. In any case, please report this issue with upstream (but I think you already did). Updated to 0.60 with license added and link to upstream PR adding the license Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-x86_64/03955185-rust-nu-path/rust-nu-path.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-x86_64/03955185-rust-nu-path/rust-nu-path-0.60.0-1.fc37.src.rpm Taking this review Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. Thanks! src/fedora/pkgs-sig-rust ❯ fedpkg request-repo rust-nu-path 2038636 https://pagure.io/releng/fedora-scm-requests/issue/43506 src/fedora/pkgs-sig-rust took 6s ❯ fedpkg request-branch --repo rust-nu-path --all-releases https://pagure.io/releng/fedora-scm-requests/issue/43507 https://pagure.io/releng/fedora-scm-requests/issue/43508 https://pagure.io/releng/fedora-scm-requests/issue/43509 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-path FEDORA-2022-a7b8406617 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617 FEDORA-2022-00805ead9b has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b FEDORA-2022-f12eda9c87 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87 FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-f12eda9c87 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-00805ead9b has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-00805ead9b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-a7b8406617 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-00805ead9b has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |