Bug 2038653
| Summary: | Review Request: rust-nu-engine - Core commands for nushell | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-04-28 05:50:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2038469, 2038612, 2038636, 2038652, 2075626 | ||
| Bug Blocks: | 2038638, 2038736 | ||
|
Description
Michel Lind
2022-01-09 07:47:14 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-x86_64/04221853-rust-nu-engine/rust-nu-engine.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-x86_64/04221853-rust-nu-engine/rust-nu-engine-0.61.0-1.fc37.src.rpm COPR builds and review templates: https://copr.fedorainfracloud.org/coprs/salimma/nu-wip/build/4221853/ Make sure to build rust-nu-glob and rust-nu-protocol before this package, otherwise it will have broken dependencies.
Did you disable the "plugin" feature on purpose, or did you just not regenerate the .spec file for 0.61.0?
+%package -n %{name}+plugin-devel
+Summary: %{summary}
+BuildArch: noarch
+
+%description -n %{name}+plugin-devel %{_description}
+
+This package contains library source intended for building other packages which
+use the "plugin" feature of the "%{crate}" crate.
+
+%files -n %{name}+plugin-devel
+%ghost %{crate_instdir}/Cargo.toml
+
I disabled plugin on purpose, as it depends on nu-plugin which depends on nu-engine: https://crates.io/crates/nu-plugin/0.61.0/dependencies Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Thanks! ❯ fedpkg request-repo rust-nu-engine 2038653 https://pagure.io/releng/fedora-scm-requests/issue/43716 ❯ fedpkg request-branch --repo rust-nu-engine --all-releases https://pagure.io/releng/fedora-scm-requests/issue/43717 https://pagure.io/releng/fedora-scm-requests/issue/43718 https://pagure.io/releng/fedora-scm-requests/issue/43719 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-engine FEDORA-2022-4f48ae2d1a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a FEDORA-2022-40a68fac9c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c FEDORA-2022-43bd74ffd7 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7 FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4f48ae2d1a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-43bd74ffd7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-40a68fac9c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |