Bug 212897 (pear-Structures-DG)

Summary: Review Request: php-pear-Structures-DataGrid - A tabular structure for converting data
Product: [Fedora] Fedora Reporter: Christopher Stone <chris.stone>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideFlags: wtogami: fedora-cvs+
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-11-14 04:06:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 212898, 212919, 212924, 212925    

Description Christopher Stone 2006-10-30 01:09:14 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-0.7.2-1.src.rpm

Description:
This package offers a toolkit to render out a datagrid in HTML format as well
as many other formats such as an XML Document, an Excel Spreadsheet, an XUL
Document and more. It also offers paging and sorting functionallity to limit
the data that is presented and processed. This concept is based on the .NET
Framework DataGrid control and works very well with database and XML result
sets.

Comment 1 Jason Tibbitts 2006-11-13 17:33:59 UTC
rpmlint complains about the lack of documentation:
   W: php-pear-Structures-DataGrid no-documentation
but that's the honest truth; this package doesn't have so much as a README file.
 Which sucks, but there's not much to be done about it.

* source files match upstream:
   bb51347f4b792d733c22f6ffd594766c  Structures_DataGrid-0.7.2.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
O rpmlint output is acceptable.
* final provides and requires are sane:
   php-pear(Structures_DataGrid) = 0.7.2
   php-pear-Structures-DataGrid = 0.7.2-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-pear(PEAR)
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation)
* code, not content.
* No documentation to consider putting in a -docs subpackage.

APPROVED

Comment 2 Christopher Stone 2006-11-14 04:06:13 UTC
Package is still beta, there is documentation on the web site.  Thanks for the
review!

Comment 3 Christopher Stone 2007-05-05 23:50:56 UTC
Package Change Request
======================
Package Name: php-pear-Structures-DataGrid
New Branches: EL-5

Comment 4 Dennis Gilmore 2007-05-06 05:25:25 UTC
branched for EL

Comment 5 Christopher Stone 2007-05-06 21:50:45 UTC
This was branched for both EL-4 and EL-5.  I only requested an EL-5 branch.  Can
the EL-4 branch be removed?