Bug 2279542
| Summary: | Review Request: rust-sqlx-mysql - MySQL driver implementation for SQLx | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Cristian Le <fedora> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, eclipseo, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/sqlx-mysql | ||
| Whiteboard: | |||
| Fixed In Version: | rust-sqlx-mysql-0.8.2-1.fc42 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-12 11:44:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2268045, 2279536, 2279537, 2310831 | ||
| Bug Blocks: | 2279539, 2279547 | ||
|
Description
Cristian Le
2024-05-07 12:23:08 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7424579 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279542-rust-sqlx-mysql/fedora-rawhide-x86_64/07424579-rust-sqlx-mysql/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. - Grab license files from https://github.com/launchbadge/sqlx and reference this bug for resolution of the situation: https://github.com/launchbadge/sqlx/issues/3237 - License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines Package approved. > - Conforms to Go Packaging Guidelines
Looks like you pasted the wrong template? :)
Also, compared to Go packages, it's also necessary that all built packages *install* without missing dependencies. Did you verify this?
Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/bcb99b4c4cf9566d8da58eb5eb90b0f26257fd3f/rust-sqlx-mysql/rust-sqlx-mysql.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07475520-rust-sqlx-mysql/rust-sqlx-mysql-0.7.4-1.fc41.src.rpm rust2rpm.toml: ```toml [[package.extra-sources]] number = 10 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-APACHE" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [[package.extra-sources]] number = 11 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-MIT" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."] [package] extra-files = [ "%license %{crate_instdir}/LICENSE-APACHE", "%license %{crate_instdir}/LICENSE-MIT", ] [tests] skip = [ "options::MySqlConnectOptions", ] comments = [ "Skip tests that require main sqlx package" ] ``` Similar change to https://bugzilla.redhat.com/show_bug.cgi?id=2279546#c6 --- Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/8a8d6c3c423c1e9b24ca1a557a32f3df1d0ff38f/rust-sqlx-mysql/rust-sqlx-mysql.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07714406-rust-sqlx-mysql/rust-sqlx-mysql-0.7.4-1.fc41.src.rpm rust2rpm.toml: ```toml [features] enable-all = true [[package.extra-sources]] number = 10 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-APACHE" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [[package.extra-sources]] number = 11 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-MIT" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."] [package] cargo-toml-patch-comments = [ "- Fix missing chrono.clock feature", " https://github.com/launchbadge/sqlx/issues/3332", ] [tests] skip = [ "options::MySqlConnectOptions", ] comments = [ "Skip tests that require main sqlx package" ] ``` sqlx-mysql-fix-metadata.diff ``` --- sqlx-mysql-0.7.4/Cargo.toml 1970-01-01T00:00:01+00:00 +++ sqlx-mysql-0.7.4/Cargo.toml 2024-07-07T08:49:46.239326+00:00 @@ -51,6 +51,9 @@ [dependencies.chrono] version = "0.4.22" +features = [ + "clock", +] optional = true default-features = false ``` Copr build: https://copr.fedorainfracloud.org/coprs/build/7719760 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279542-rust-sqlx-mysql/fedora-rawhide-x86_64/07719760-rust-sqlx-mysql/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-mysql/rust-sqlx-mysql.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-mysql/rust-sqlx-mysql-0.8.1-1.fc42.src.rpm Bump sqlx packages to 0.8.1 Copr build: https://copr.fedorainfracloud.org/coprs/build/7947981 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279542-rust-sqlx-mysql/fedora-rawhide-x86_64/07947981-rust-sqlx-mysql/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-mysql/rust-sqlx-mysql.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-mysql/rust-sqlx-mysql-0.8.2-1.fc42.src.rpm Bumped to 0.8.2 Copr build: https://copr.fedorainfracloud.org/coprs/build/8010406 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279542-rust-sqlx-mysql/fedora-rawhide-x86_64/08010406-rust-sqlx-mysql/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (one test disabled with justification) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review, Fabio The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sqlx-mysql FEDORA-2024-6e13919777 (rust-sqlx-mysql-0.8.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e13919777 FEDORA-2024-6e13919777 (rust-sqlx-mysql-0.8.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |