Bug 2312637 (rust-asn1-rs)

$ cat rust2rpm.toml 
[requires]
test = [
  "crate(bitvec)",
  "crate(cookie-factory)",
  "crate(num-bigint)",
  "crate(time)",
  "crate(time-macros)",
]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8025100
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312637-rust-asn1-rs/fedora-rawhide-x86_64/08025100-rust-asn1-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8229471
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312637-rust-asn1-rs/fedora-rawhide-x86_64/08229471-rust-asn1-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

@davide you need to update the buildrequires list:
%if %{with check}
BuildRequires:  crate(bitvec)
BuildRequires:  crate(cookie-factory)
BuildRequires:  crate(futures)
BuildRequires:  crate(futures-macro)
BuildRequires:  crate(futures-executor)
BuildRequires:  crate(num-bigint)
BuildRequires:  crate(slab)
BuildRequires:  crate(time)
BuildRequires:  crate(time-macros)
%endif

(In reply to Marc-Andre Lureau from comment #5)
> @davide you need to update the buildrequires list:
> %if %{with check}
> BuildRequires:  crate(bitvec)
> BuildRequires:  crate(cookie-factory)
> BuildRequires:  crate(futures)
> BuildRequires:  crate(futures-macro)
> BuildRequires:  crate(futures-executor)
> BuildRequires:  crate(num-bigint)
> BuildRequires:  crate(slab)
> BuildRequires:  crate(time)
> BuildRequires:  crate(time-macros)
> %endif

I don't know why this is here or why you both think it's required - adding crate dependencies like this is wrong either way, especially without lower / upper version bounds.

If the dependencies are missing from the crate, they should be added in Cargo.toml (how that is possible, I don't know), or if the dependencies are needed for tests and they're pulled in by optional / non-default features, add the "-f foo,bar" or even "-a" flag to "%cargo_*" macros (except %cargo_prep) instead.

Spec URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs/rust-asn1-rs.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs/rust-asn1-rs-0.6.2-1.fc42.src.rpm

Changelog:
- enable features we need for tests

$ cat rust2rpm.toml 
[features]
# These need to be enables for the tests to work
enable = [
  "bigint",
  "bits",
  "datetime",
  "serialize",
]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8319579
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312637-rust-asn1-rs/fedora-rawhide-x86_64/08319579-rust-asn1-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

*** Bug 2330103 has been marked as a duplicate of this bug. ***

Taking this review.

Package was generated with rust2rpm, simplifying the review.

You might want to exclude the "doc/" folder but it doesn't hurt to be present since it's just some markdown files.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-asn1-rs

FEDORA-2024-45784f5560 (rust-asn1-rs-0.6.2-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-45784f5560

FEDORA-2024-45784f5560 (rust-asn1-rs-0.6.2-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.