Bug 440136
| Summary: | PATCH: imagemagick fails to read 24bit .ico files causing various package build failures | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> | ||||
| Component: | ImageMagick | Assignee: | Norm Murray <nmurray> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | nmurray | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-04-28 15:22:10 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 440765, 440828, 440907, 440911 | ||||||
| Attachments: |
|
||||||
|
Description
Hans de Goede
2008-04-01 20:35:31 UTC
Created attachment 299966 [details]
PATCH: imagemagick fails to read 24bit .ico files
Norm, Can you please fix this, this blocks 4 other bugs. I'm sorry todo this, but consider this your first ping in the light of the NonResponsiveMaintainers policy: http://fedoraproject.org/wiki/PackageMaintainers/Policy/NonResponsiveMaintainers Should be fixed in latest build just done. Please let me know if there are any problems. (In reply to comment #3) > Should be fixed in latest build just done. Please let me know if there are any > problems. There are, by updating to upstream's latest release instead of just applying my patch, you've introduced a soname change into F-9 very very late in the F-9 release cycle. Luckily this build was never pushed to rawhide because rawhide is frozen at the moment, please do a build of ImageMagick-6.3.8.1 with my patch included for F-9 (no need to bump the epoch, the 6.4.x build was never pushed ot any repos) and do the 6.4.x build for F-10 (F-9 currently has its own cvs branch, F-10 is the devel branch). Also looking at: https://admin.fedoraproject.org/pkgdb/packages/bugs/ImageMagick There are a lot of bugs open against ImageMagick, so it looks like you could use a hand with maintaining it. I'm a _very_ experienced package maintainer / programmer, see: https://admin.fedoraproject.org/pkgdb/users/packages/jwrdegoede And I would be very happy to lend a hand, would it be ok with you to have me as co-maintainer. If so I'll request the necessary rights and start working on that list of bugs. done and done Thanks! The new ImageMagick works fine, fixing all the bugs depending upon this one, shall I mail rel-eng to ask to include this fixed version in F-9? One important note: you've only done this update for the F-9 branch in CVS not for devel, so if someone know makes changes to devel, then the 2 versions might get out of sync. Its good policy to always make changes in devel and then copy them to other branches, unless for reasons like sonames being different the 2 branches are based on different upstream versions (which will be the case once devel gets updated to 6.4.x). I've discussed things with rel-eng and they've decided to include ImageMagick-6.3.8.1-4.fc9 in F-9 final, so I'm closing this now. |