Bug 480527

To the reporter: can you try reproducing this with the gstreamer backend?  (Switch in the Preferences under Playback IIRC)

Will: is this a known issue with new xine upstream?

Not reproducible with gstreamer - only with xine (which is the default)

I'm assuming this is with Miro 1.2.8.

I've not heard of this.  But if I was a betting man, I'd say it was a issue with compiling Miro against one version and running it with a different one.

(In reply to comment #3)
> I'm assuming this is with Miro 1.2.8.
> 
> I've not heard of this.  But if I was a betting man, I'd say it was a issue
> with compiling Miro against one version and running it with a different one.

Yes - Miro-1.2.8-1.fc10.x86_64 - and FWIW, I just now rebuilt the SRPM against xine-lib 1.1.16 and there was no change: it still crashes.

I can confirm that I get a crash off sorts, the program hangs towards the end of playing a video.  I made a scratch build against xine-lib 1.1.6 as done in comment #4:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1073627

I then reinstalled this rpm and get the same kind of hang, so this would appear to be an upstream issue or problem with xine-lib 1.1.16.  Will?

I can confirm the segfault of miro every time the video is done, no matter whether it is stopped manually or just clip is over. I've been asking about that on fedora mail list earlier https://www.redhat.com/archives/fedora-list/2009-January/msg02329.html

It does not crash with gstreamer renderer, and after I rolled back to xine* 1.1.15  miro works as before again.

I tried to reproduce the problem, but I can't.  I tested the Miro RPM that's in the Fedora 10 repository in my Fedora 10 vm and it works fine for me with libxine 1.1.16:

[build@localhost gtk-x11]$ rpm -q Miro xine-lib
Miro-1.2.8-1.fc10.i386
xine-lib-1.1.16-1.fc10.i386

For people who are seeing crashes, are any of you on i386 or are all the issues on x86_64?

(In reply to comment #7)
> I tried to reproduce the problem, but I can't.  I tested the Miro RPM that's in
> the Fedora 10 repository in my Fedora 10 vm and it works fine for me with
> libxine 1.1.16:
> 
> [build@localhost gtk-x11]$ rpm -q Miro xine-lib
> Miro-1.2.8-1.fc10.i386
> xine-lib-1.1.16-1.fc10.i386
> 
> For people who are seeing crashes, are any of you on i386 or are all the issues
> on x86_64?

I see a "hang", not a seg fault, per se, after playing (or pausing) videos.  Basically the UI becomes unresponsive and I have to kill the process.  This is on i386.

Alex: I think you're the only one reporting a hang--all the other comments use the word "crash" or "segfault".  I'm not sure if that means anything, but it might indicate you've got a different issue.

Is there another frontend for xine that you could use to test playback of the videos that are hanging Miro?

xine-lib-1.1.16-1.fc10.i386
> 
> For people who are seeing crashes, are any of you on i386 or are all the issues
> on x86_64?

I observe the crash after each video is done playing  in Fedora 9 x86_64

(In reply to comment #7)

> For people who are seeing crashes, are any of you on i386 or are all the issues
> on x86_64?

I'm on i386 and Miro is crashing on me after each video with error

"/usr/bin/miro: line 2:  3347 Segmentation fault      LD_LIBRARY_PATH=/usr/lib/xulrunner-1.9 miro.real "$@""

Miro-1.2.8-1.fc10.i386
xine-lib-1.1.16.1-1.fc10.i386

(In reply to comment #8)
> 
> I see a "hang", not a seg fault, per se, after playing (or pausing) videos. 
> Basically the UI becomes unresponsive and I have to kill the process.  This is
> on i386.

I have similar problem with flac files playing in amarok, songbird or rhythmbox
after the xine-lib update (on fc10 i386). The UI just hangs, have to kill the application from a xterm.

Tried to search for bugs upstream, however xinehq.de is down.

(In reply to comment #12)

> I have similar problem with flac files playing in amarok, songbird or rhythmbox
> after the xine-lib update (on fc10 i386). The UI just hangs, have to kill the
> application from a xterm.

I can seem to play the downloads from the main xine application (it correctly terminates), so it must be something in the interaction.

> Tried to search for bugs upstream, however xinehq.de is down.

Hmm, seems that it must have been down for a while, because it was down last week.  Has upstream disappeared perhaps?

My problem was fixed by xine-lib 1.1.16.1-4:

 http://koji.fedoraproject.org/koji/buildinfo?buildID=82128

xine-lib 1.1.16.2 has been released and built in koji too, 
maybe that update will fix the problem?

Miro-2.0-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/Miro-2.0-1.fc10

I submitted the update, but Miro 2.0 doesn't necessarily fix the xine crashes for me, I still get them with some files, however I added the bug to the bodhi update to make people aware of the new Miro.

Please provide feedback on the bodhi page in comment #15, however bear in mind that this update should still be pushed even if it doesn't fix all the xine problems (unless it makes them uniformly worse), as things still work with gstreamer and Miro 2.0 has fixes for other issues.

Thanks for packaging the 2.0 update, Alex. The GUI's been much improved.

2.0 WFM, despite the xinelib problem still crashing it after playing any video, so it's no worse than with Miro 1.2 was, but I wouldn't agree that this should be pushed to updates until this bug's been fixed, or unless the default backend is switched to gstreamer in the meantime.

For the past couple weeks since this bug reared up I haven't actually been able to use Miro as a player (though I know i could've just switched the backend from xine to gstreamer), so I've just been using it as a glorified RSS downloader, and then watching/deleting the vids externally as they showed up in the download dir.

Thanks,
Jason "zcat" Farrell

We're about to put out a 2.0.2 (this week for sure) which fixes a bunch of other things and some xine problems.

Uwe (Debian) pointed out that the xine-xvhack code seems to be the cause of the problems with xinelib 1.1.16.  You can compile the xine hack out by setting USE_XINE_HACK to False at the top of setup.py might help.  There's more details in setup.py.

There's a list of changes for 2.0.1 and what will become 2.0.2 in the release notes:

https://develop.participatoryculture.org/trac/democracy/wiki/2.0ReleaseNotes

Hope that helps.

(In reply to comment #17)

> For the past couple weeks since this bug reared up I haven't actually been able
> to use Miro as a player (though I know i could've just switched the backend
> from xine to gstreamer), 


and I just rolled back to xine-lib-1.1.15-3.fc10.i386  and since then have been procrastinating with update until you guys say it's fixed. 

switching to gstreamer doesn't work for me either because after playback starts its window detaches from Miro and stays alone. Besides, gstreamer doesn't hold the aspect ratio when resizing that window. See how it looks in the end of this  thread http://getsatisfaction.com/participatoryculturefoundation/topics/miro_segfaults_after_each_video Perhaps I just don't know how to cook gstreamer.

Miro-2.0-1.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update Miro'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2084

Miro-2.0-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/Miro-2.0-2.fc10

Miro-2.0-3.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update Miro'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2139

Miro-2.0-3.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update Miro'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2139

Miro-2.0-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

I'm still having the same problem. 

Miro-2.0-3.fc10.x86_64
xine-lib-1.1.16.2-3.fc10.x86_64
xulrunner-1.9.0.6-1.fc10.x86_64

And if I downgrade to xine-lib 1.1.15-3, then I can't play videos at all -- I click the play button, and nothing happens except this gets spewed out in my terminal:

AttributeError: NullRenderer instance has no attribute 'set_widget'
Traceback (most recent call last):
  File "/usr/lib64/python2.5/site-packages/miro/frontends/widgets/gtk/weakconnect.py", line 49, in handle_callback
    return real_method(obj, *(args + self.user_args))
  File "/usr/lib64/python2.5/site-packages/miro/frontends/widgets/gtk/tableview.py", line 861, in on_button_release
    hotspot_tracker.iter)
  File "/usr/lib64/python2.5/site-packages/miro/signals.py", line 155, in emit
    if callback.invoke(self, args):
  File "/usr/lib64/python2.5/site-packages/miro/signals.py", line 89, in invoke
    return callback(obj, *(args + self.extra_args))
  File "/usr/lib64/python2.5/site-packages/miro/frontends/widgets/itemlistcontroller.py", line 263, in on_hotspot_clicked
    self._play_item_list(items)
  File "/usr/lib64/python2.5/site-packages/miro/frontends/widgets/itemlistcontroller.py", line 165, in _play_item_list
    app.playback_manager.start_with_items(playable, presentation_mode)
  File "/usr/lib64/python2.5/site-packages/miro/frontends/widgets/playback.py", line 146, in start_with_items
    self.video_display = VideoDisplay()
  File "/usr/lib64/python2.5/site-packages/miro/frontends/widgets/displays.py", line 412, in __init__
    self.renderer = widgetset.VideoRenderer()
  File "/usr/lib64/python2.5/site-packages/miro/frontends/widgets/gtk/video.py", line 407, in __init__
    self._video_widget = VideoWidget(self.renderer)
  File "/usr/lib64/python2.5/site-packages/miro/frontends/widgets/gtk/video.py", line 217, in __init__
    renderer.set_widget(self._widget)
AttributeError: NullRenderer instance has no attribute 'set_widget'

(In reply to comment #25)
> I'm still having the same problem. 
> 
> Miro-2.0-3.fc10.x86_64
> xine-lib-1.1.16.2-3.fc10.x86_64
> xulrunner-1.9.0.6-1.fc10.x86_64

Does the gstreamer backend work for you?

gstreamer works for video, but not audio. Which is an improvement; up until now, gstreamer has given me a "I can't play this format" error. 

Has anybody who had the xine problem before gotten xine working with 2.0-3?

We should probably try and get this resolved once and for all.

- which feed are you using
- rpm -qa gstreamer\*

With the correct third-party-repo (rpmfusion) enabled, gstreamer should decode both audio and video just fine. Without this repo, xine would not work properly either as the necessary codecs are in xine-lib-extras-freeworld. Unless you use another repo that has the xine-lib plugins but not gstreamer.

(Which might be a useful test: if you did use a different xine-lib-* RPM, could you switch to rpmfusion's and see if that works?)

$ rpm -qa gstreamer\*
gstreamer-python-0.10.12-1.fc10.x86_64
gstreamer-plugins-ugly-0.10.10-2.fc10.x86_64
gstreamer-plugins-good-0.10.13-1.fc10.x86_64
gstreamer-ffmpeg-0.10.5-1.fc10.x86_64
gstreamer-plugins-flumpegdemux-0.10.15-4.fc10.x86_64
gstreamer-tools-0.10.21-2.fc10.x86_64
gstreamer-plugins-base-0.10.21-2.fc10.x86_64
gstreamer-0.10.21-2.fc10.x86_64
$ rpm -qa xine\*
xinetd-2.3.14-21.fc10.x86_64
xine-lib-1.1.16.2-1.fc10.x86_64
xine-0.99.5-5.fc10.x86_64
xine-lib-extras-freeworld-1.1.16.2-1.fc10.x86_64
xine-lib-pulseaudio-1.1.16.2-1.fc10.x86_64
spoo:~$ rpm -q xulrunner
xulrunner-1.9.0.6-1.fc10.x86_64
$ 

xine is from rpmfusion. 

One of many feeds that isn't working for me (but was working a month ago) is 
http://feeds.feedburner.com/crankmychain

Specifically, with this feed, using gstreamer, if I click play on the "Whatever happened to Critical Mass in Portland" (which is a mov), I get a black screen -- no audio, no video. If I click on "Rep. Boehner Thinks American Families Hate Bike Paths", which is an mp4, I get video but no audio. 

If I use xine instead, the videos play fine, but segfault miro when I stop them.

The latest release wasn't necessarily supposed to fix the xine issue, but I added it to notify users that it *might*.  Unfortunately there isn't anyway to selectively ask bodhi to close some bugs and not others.  Anyway I'm re-opening it now.

Regarding the problem itself, comment #18 indicates that they are working on this upstream and that 2.0.2 may fix this.  Also we should put out another testing update and try the following:

> Uwe (Debian) pointed out that the xine-xvhack code seems to be the cause of the
> problems with xinelib 1.1.16.  You can compile the xine hack out by setting
> USE_XINE_HACK to False at the top of setup.py might help.  There's more details
> in setup.py.

Try installing gstreamer-plugins-bad ? And yes, we should try turning off USE_XINE_HACK too.

There we go. With gstreamer-plugins-bad, gstreamer now works.

Confirmed with Fedora 10 and Miro 2.0.4 as well - thanks!

(In reply to comment #33)
> Confirmed with Fedora 10 and Miro 2.0.4 as well - thanks!  

Miro 2.0.4?  Do you mean Miro 2.0.2 which was released on the 7 March?

Also you are confirming that gstreamer playback works, not that xine playback works, right?

(In reply to comment #34)
> (In reply to comment #33)
> > Confirmed with Fedora 10 and Miro 2.0.4 as well - thanks!  
> 
> Miro 2.0.4?  Do you mean Miro 2.0.2 which was released on the 7 March?

Sorry, I meant Miro-2.0-4.fc10.i386 - just installed now.

> Also you are confirming that gstreamer playback works, not that xine playback
> works, right?

Correct - I had tried gstreamer with 2.0-2 and 2.0-3 but it didn't work until I saw the above comment and installed gstreamer-plugins-bad . . xine playback still crashes on video ending/stopping.

Phil.

I just pushed 2.0.2 to testing:

http://admin.fedoraproject.org/updates/Miro-2.0.2-1.fc10

although in my testing, this didn't quite fix the xine issues (still get segfaults) and therefore I didn't mark this bug as being fixed by that update.  Although I did get through some videos without crashing if they weren't the last in the list.  I think this is still yet to be properly fixed upstream see:

http://bugzilla.pculture.org/show_bug.cgi?id=11435

New pending build:

http://admin.fedoraproject.org/updates/Miro-2.0.3-1.fc10

about to go to testing.  This disables the xine hack which fixes things for me.

Thanks alex - fixes the crashing with xine-lib-1.1.16 here too. and so perhaps the default backend can also be changed back to xine from gstreamer for the final release.

Miro-2.0.3-1.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update Miro'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2766

(In reply to comment #38)
> Thanks alex - fixes the crashing with xine-lib-1.1.16 here too. and so perhaps
> the default backend can also be changed back to xine from gstreamer for the
> final release.  

gstreamer is default upstream now too, and now Miro installs the default gstreamer bindings properly (bug #489134) so we'll be sticking with that as the default.  Users can always switch between to xine playback if they prefer.

Miro-2.0.3-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.