Bug 530770

Summary:	environment-modules.i686 0:3.2.7b-4.fc12 breaks (at least) gdm
Product:	[Fedora] Fedora	Reporter:	Bruno Wolff III <bruno>
Component:	environment-modules	Assignee:	Orion Poplawski <orion>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	dakingun, james, jfrieben, mclasen, orion
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	3.2.7b-5.fc11	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-10-26 17:53:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	473303

Description Bruno Wolff III 2009-10-24 21:31:24 UTC

Description of problem:
After updating to the 10-24 rawhide, gdm wasn't starting. I eventually found that running the environment-modules script in /etc/profile.d was killing the gdm script. Uninstalling environment-modules got things working again.

Version-Release number of selected component (if applicable):
environment-modules.i686 0:3.2.7b-4.fc12

How reproducible:
I don't know if there are any dependencies on /etc/profile which I changed a while back to put sbin in normal users' paths. (That wouldn't excuse environment-modules, but could potentially be needed to reproduce the problem.)

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Deji Akingunola 2009-10-25 19:54:03 UTC

Me too :). environment-modules-3.2.7b-4.fc12 was supposed to fix Bug 529745 (which it did), but with a rather huge negative impact.

Comment 2 Orion Poplawski 2009-10-26 16:14:45 UTC

So, any idea what the actual problem is?  This is my thought for a fix, but I'm not sure what the real cause is.

shell=`/bin/basename \`/bin/ps -p $$ -ocomm=\``
[ -f /usr/share/Modules/init/$shell ] &&
  . /usr/share/Modules/init/$shell

Comment 3 Orion Poplawski 2009-10-26 16:50:44 UTC

Ah, interesting, /usr/sbin/gdm is a script and it sources the profile.d directory.  Here is my suggested fix:

shell=`/bin/basename \`/bin/ps -p $$ -ocomm=\``
if [ -f /usr/share/Modules/init/$shell ]
then
  . /usr/share/Modules/init/$shell
else
  . /usr/share/Modules/init/sh
fi

Comment 4 Bruno Wolff III 2009-10-26 16:58:21 UTC

I didn't try to figure out what actually broke things. I was just happy I figured out which package broke graphical logins.

Comment 5 Bruno Wolff III 2009-10-26 17:06:13 UTC

I see there is a new build. I'll report back in a few minutes whether or not it solved the problem I was seeing.

Comment 6 Fedora Update System 2009-10-26 17:33:20 UTC

environment-modules-3.2.7b-5.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/environment-modules-3.2.7b-5.fc11

Comment 7 Bruno Wolff III 2009-10-26 17:36:41 UTC

environment-modules-3.2.7b-5.fc12.x86_64 fixed the problem with gdm.

Comment 8 James 2009-10-26 20:22:03 UTC

*** Bug 530967 has been marked as a duplicate of this bug. ***

Comment 9 Ray Strode [halfline] 2009-10-29 17:29:42 UTC

*** Bug 531195 has been marked as a duplicate of this bug. ***

Comment 10 Fedora Update System 2009-11-10 17:49:28 UTC

environment-modules-3.2.7b-5.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.