Bug 575157
| Summary: | cman cannot be rebuilt with latest nss libraries | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Jaroslav Kortus <jkortus> | ||||
| Component: | cman | Assignee: | Lon Hohberger <lhh> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | urgent | ||||||
| Version: | 5.5 | CC: | cluster-maint, djansa, emaldona, fdinitto, iannis, jwest, kbsingh, pasteur, tis | ||||
| Target Milestone: | rc | Keywords: | ZStream | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | cman-2.0.115-37.el5 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-01-13 22:32:35 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 453577, 587546, 590145, 590734 | ||||||
| Bug Blocks: | 586034, 586035, 586036 | ||||||
| Attachments: |
|
||||||
|
Description
Jaroslav Kortus
2010-03-19 16:08:54 UTC
I don' Oops. I don't get the warm and fuzzies from the fact that use of nss makes me DISABLE compiler warnings. It stems from a bad function prototype in prlink.h: void (*fp)(); For fence_xvm, the best option is to use: #pragma GCC diagnostic ignored "-Wstrict-prototypes" ... at the beginning of the file(s) where nss or nspr includes are used. This prevents the need to ignore strict-prototypes elsewhere in the code base during compilation. Unfortunately this trick doesn't work with gcc version included in rhel5. You need to use -Wno-strict-prototypes. Created attachment 403833 [details]
Patch fixing compile against nspr-4.8.2+
should be clone for RHEL4 too cman-kernel-2.6.9-56.7.el4_8.12.can be built with nss-3.12.3.99.3-1.el4_8.2 but fails to build if 3.12.6-1.el4_8 is installed cman-kernel does not use nss; I do not understand how building it could fail due to nss or nspr updates. Furthermore, if there is an identifiable point at which an update of a library broke compilation of applications, it is a regression in the library. This isn´t a new bug. nss maintainers have been aware of this issue for sometime (reported several months ago against Fedora). And for sure not a cman issue. Time nss people fix their stuff. http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=d4ae5b0f197288fafe884046ba9d9cd1c9c556b0 I do not see value in sweeping the error under the rug by not compiling with -Wstrict-prototypes. Consequently, I have removed -Werror. See: https://bugzilla.redhat.com/show_bug.cgi?id=453577#c3 A change to nss caused this (not nspr or gcc, as previously suspected) Patch in https://bugzilla.redhat.com/attachment.cgi?id=409353 that patch should work for this bug as well. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0036.html |