| Summary: | Review Request: hibernate-validator - Bean Validation (JSR 303) Reference Implementation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andy Grimm <agrimm> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | akurtako, jgoulding, jzeleny, mgoldman, notting, package-review, sochotni |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-05 15:14:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 790553, 794693, 794722, 794725 | ||
| Bug Blocks: | |||
|
Description
Andy Grimm
2011-12-13 04:01:18 UTC
Andy,
You forgot to include pom file for hibernate-validator module. Instead you just added the parent pom, which should be renamed to JPP-%{name}-parent.pom
Updated files: SPEC: http://downloads.eucalyptus.com/devel/packages/fedora-16/SPECS/hibernate-validator.spec SRPM: http://downloads.eucalyptus.com/devel/packages/fedora-16/SRPMS/hibernate-validator-4.2.0-2.fc16.src.rpm It seems that this package lacks of a few classes - most importantly HibernateValidar.class :) To add these classes we need to leave the xjc goal of jaxb2-maven-plugin. Unfortunately this plugin isn't packaged in Fedora yet. The jaxb2-maven-plugin requires jaxb-xjc... This where I ended. I have the jaxb2-maven-plugin spec file more or less prepared, but I haven't looked at jaxb-xjc yet. And I'll not have time to do this in the next week :( I would really appreciate it if someone could look at jaxb-xjc. Also watch out for maven-shade-plugin. The results of shading don't seem to be used inside the package itself, but it's possible some external package will require them I packaged jaxb2-maven-plugin. This allowed me to compile the full hibernate-validator. I'll start submitting all required specs soon. In total - 13 new packages must be added... In the meantime, here is what my spec looks like: SPEC: http://goldmann.fedorapeople.org/package_review/hibernate-validator/1/hibernate-validator.spec SRPM: http://goldmann.fedorapeople.org/package_review/hibernate-validator/1/hibernate-validator-4.2.0-3.fc17.src.rpm Feel free to make changes to this spec. Marek, I rebuilt your source rpms on F17 over the weekend. I had to make small changes to istack-commons, relaxngcc, and jaxb2-maven-plugin to make them build, but I got them to work. I am concerned about the bootstrapping for relaxngcc (because it looks like it relies on a binary jar right now, rather than doing a partial build followed by a full build or something), but I think we should work together to get this whole stack of things cleaned up and packaged. Thanks for working on this. Andy, Cleaned relaxngcc is submitted by Juan, here: https://bugzilla.redhat.com/show_bug.cgi?id=790549 I'm setting some dependencies for this package. They are mostly indirect deps, but it will make it more clear what's holding this one up. Closing in favor of Marek & Juan's version with all the right deps. *** This bug has been marked as a duplicate of bug 799976 *** |