Bug 785438 (Horde_Url)

Summary:	Review Request: php-horde-Horde-Url - Horde Url class
Product:	[Fedora] Fedora	Reporter:	Nick Bebout <nb>
Component:	Package Review	Assignee:	Remi Collet <fedora>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, notting, package-review
Target Milestone:	---	Flags:	fedora: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-03-21 23:50:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	785424, 785436
Bug Blocks:	785439, 785451, 785492, 909588

Description Nick Bebout 2012-01-28 23:39:41 UTC

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Url.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Url-1.0.0-1.fc16.src.rpm
Description: This class represents a single URL and provides methods for manipulating URLs.

Comment 1 Remi Collet 2012-01-30 14:53:15 UTC

Same comment as others...

If you don't set Buildroot, you can also remove %clean

--- php-horde-Horde-Url.spec.old	2012-01-30 15:46:30.000000000 +0100
+++ php-horde-Horde-Url.spec	2012-01-30 15:51:21.000000000 +0100
@@ -12,13 +12,16 @@
 Source0:        http://pear.horde.org/get/%{pear_name}-%{version}.tgz
 
 BuildArch:      noarch
-BuildRequires:  php-pear >= 1:1.4.9-1.2
+BuildRequires:  php-pear(PEAR) >= 1.7.0
+BuildRequires:  php-channel(pear.horde.org)
+
 Requires(post): %{__pear}
 Requires(postun): %{__pear}
-Requires:       php-pear(pear.horde.org/Horde_Exception) <= 2.0.0, php-pear(PEAR) >= 1.7.0
-Conflicts:      php-pear(pear.horde.org/Horde_Exception) = 2.0.0
-Provides:       php-pear(pear.horde.org/Horde_Url) = %{version}
-BuildRequires:  php-channel(pear.horde.org)
+Requires:       php-pear(pear.horde.org/Horde_Exception) >= 1.0.0
+Requires:       php-pear(pear.horde.org/Horde_Exception) <  2.0.0
+Requires:	php-pear(PEAR) >= 1.7.0
+Requires:	php-common >= 5.2.0
+Provides:       php-pear(pear.horde.org/%{pear_name}) = %{version}
 Requires:       php-channel(pear.horde.org)
 
 %description
@@ -51,10 +54,6 @@
 install -pm 644 %{name}.xml $RPM_BUILD_ROOT%{pear_xmldir}
 
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
 %post
 %{__pear} install --nodeps --soft --force --register-only \
     %{pear_xmldir}/%{name}.xml >/dev/null || :
@@ -67,13 +66,9 @@
 
 
 %files
-
 %{pear_xmldir}/%{name}.xml
-# Expand this as needed to avoid owning dirs owned by our dependencies
-# and to avoid unowned dirs
-%{pear_phpdir}/Horde/Url/Exception.php
+%{pear_phpdir}/Horde/Url
 %{pear_phpdir}/Horde/Url.php
-
 %{pear_testdir}/Horde_Url

Comment 2 Nick Bebout 2012-02-15 21:51:54 UTC

This one doesn't appear to have translation files, so I think it's ready.

Comment 3 Remi Collet 2012-02-19 07:20:16 UTC

This one is also OK


APPROVED

Comment 4 Nick Bebout 2012-02-19 14:40:47 UTC

New Package SCM Request
=======================
Package Name: php-horde-Horde-Url
Short Description: This class represents a single URL and provides methods for
manipulating URLs
Owners: nb
Branches: f16 f17 el6
InitialCC:

Comment 5 Gwyn Ciesla 2012-02-19 20:38:27 UTC

Git done (by process-git-requests).