Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-1.1.4-1.fc16.src.rpm Description: The Horde_Token:: class provides a common abstracted interface into the various token generation mediums. It also includes all of the functions for retrieving, storing, and checking tokens.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-1.1.7-1.fc16.src.rpm
I will review this package
After a quick review: [MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml [MUST] Fix file-not-in-%lang rpmlint warnings [SHOULD] %check is present and all tests pass [SHOULD] Localized php.ini not necessary (see https://bugzilla.redhat.com/show_bug.cgi?id=785471#c5)
Please update to 2.0.1
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-2.0.3-2.fc17.src.rpm
[!]: License field in the package spec file matches the actual license. LGPLv2 (not LGPLv2+) [!]: Package installs properly. Note: Installation errors (see attachment) Wait for dependencies before import in repository Please fix the License, everything else seems OK.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-2.0.3-3.fc17.src.rpm
License fixed No blocker === APPROVED ===
New Package SCM Request ======================= Package Name: php-horde-Horde-Token Short Description: A common abstracted interface into the various token generation mediums Owners: nb remi Branches: el6 f18 f19 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.el6,php-horde-Horde-LoginTasks-2.0.2-4.el6,php-horde-Horde-Stream-Filter-2.0.1-4.el6,php-horde-Horde-Token-2.0.3-3.el6
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.fc18,php-horde-Horde-Group-2.0.2-1.fc18,php-horde-Horde-LoginTasks-2.0.2-4.fc18,php-horde-Horde-Stream-Filter-2.0.1-4.fc18,php-horde-Horde-Token-2.0.3-3.fc18
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been pushed to the Fedora 18 stable repository.
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository.