Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller-1.0.1-1.fc16.src.rpm Description: This package provides the controller part of an MVC system for Horde.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller-1.0.2-1.fc16.src.rpm
I am not an official package reviewer, but here are some comments I have for this package: *** Your BuildRequires should be BuildRequires: php-pear(PEAR) >= 1.7.0 instead of BuildRequires: php-pear >= 1:1.4.9-1.2 (this would match what you have in bug 785606 and satisfy this package's package.xml dependency) *** Per package.xml requirements, please add: Requires: php-common >= 5.2.0 *** phpci results: For completeness, you may wish to require the package "php-mbstring" and the virtual package (to prevent any future packaging issues due to PHP package changes) "php-zlib". While package.xml lists these as optional, I believe this package would provide a better end-user experience if you added the two requires.
I believe I have fixed these issues Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller-1.0.2-2.fc16.src.rpm
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller-2.0.1-2.fc17.src.rpm
[!]: License field in the package spec file matches the actual license. LGPLv2 (not LGPLv2+) [!]: Package installs properly. Note: Installation errors (see attachment) Wait for dependencies before import in repository Please fix the License, everything else seems OK.
Sorry, comment on the bad component, forget previous
Created attachment 695803 [details] phpci.log
Created attachment 695804 [details] review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785492
[!]: Package installs properly. Note: Installation errors (see attachment) Wait for dependency before import [!]: Requires correct, justified where necessary. Replace php(language) except if you want to wait for RHEL 6.4 Requires: php-common >= 5.3.0 From package.xml Requires: php-pear(PEAR) >= 1.7.0 [!]: All build dependencies are listed in BuildRequires php-pear > 1.7.0 don't work because of epoch BuildRequires: php-pear(PEAR) >= 1.7.0 And for consistency BuildRequires: php-common >= 5.3.0
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller-2.0.1-3.fc17.src.rpm
[x]: Requires correct Note, comment about php(language) doesn't apply anymore, as RHEL 6.4 is now released ;) == APPROVED ==
New Package SCM Request ======================= Package Name: php-horde-Horde-Controller Short Description: The controller part of an MVC system for Horde Owners: nb remi Branches: el6 f18 f19 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Compress-2.0.3-3.fc18,php-horde-Horde-Controller-2.0.1-3.fc18,php-horde-Horde-Mail-2.0.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Compress-2.0.3-3.fc18,php-horde-Horde-Controller-2.0.1-3.fc18,php-horde-Horde-Mail-2.0.4-1.fc18
php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6
Package php-horde-Horde-Mail-2.0.4-1.el6, php-horde-Horde-Template-2.0.1-3.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing php-horde-Horde-Mail-2.0.4-1.el6 php-horde-Horde-Template-2.0.1-3.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-0785/php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6 then log in and leave karma (feedback).
php-horde-Horde-Compress-2.0.3-3.fc18, php-horde-Horde-Controller-2.0.1-3.fc18, php-horde-Horde-Mail-2.0.4-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
php-horde-Horde-Mail-2.0.4-1.el6, php-horde-Horde-Template-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.