Bug 785495 (Horde_Data)

I am not an official package reviewer, but here are some comments I have for this package:



*** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements



*** Your BuildRequires should be
BuildRequires:  php-pear(PEAR) >= 1.7.0
instead of
BuildRequires:  php-pear >= 1:1.4.9-1.2
(this would match what you have in bug 785606 and satisfy this package's package.xml dependency)



*** Your Provides statement should be
Provides:	php-pear(pear.horde.org/%{pear_name}) = %{version}
instead of
Provides:	php-pear(%{pear_name}) = %{version}



*** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual provides "php-date" and "php-pcre".



*** All locale %files should be tagged with "%lang(xx)".  Some rpmlint warnings:
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/ar/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/bg/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/bs/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/ca/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/cs/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/da/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/de/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/el/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/en/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/es/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/et/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/eu/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/fa/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/fi/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/fr/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/gl/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/he/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/hr/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/hu/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/id/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/is/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/it/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/ja/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/km/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/ko/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/lt/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/lv/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/mk/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/nb/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/nl/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/nn/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/pl/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/pt/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/pt_BR/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/ro/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/ru/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/sk/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/sl/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/sv/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/tr/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/uk/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/zh_CN/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Data/locale/zh_TW/LC_MESSAGES/Horde_Data.mo



*** Do you plan on building for EPEL 5?
- If not, please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag).
- If you do, there are several staements that need to be added.



*** You may wish to contact upstream to fix their package.xml as Horde_Util is listed as both required and optional

I believe I have fixed the issues you have mentioned.

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data-1.0.7-1.fc16.src.rpm

(In reply to comment #2)

Ready for official review.

(In reply to comment #3)
> Ready for official review.

I take that back.  Please add:

Requires: php-common >= 5.2.0

I believe I have fixed the issues you have mentioned.

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data-1.0.9-1.fc16.src.rpm

Actually the new urls are

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data-1.0.9-2.fc16.src.rpm

Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data-2.0.3-2.fc17.src.rpm

Created attachment 716498 [details]
phpci.log

phpci version 2.14.0.

Created attachment 716499 [details]
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785495

MUST

[!]: License field in the package spec file matches the actual license.
	LGPLv2

[!] Package installs properly.
	Requiert : php-pear(pear.horde.org/Horde_Icalendar) >= 2.0.0
	=> wait for dependencies before import

COULD (not a blocker, and I don't really care)

[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed

Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Data-2.0.3-3.fc17.src.rpm

-License:        LGPLv2+
+License:        LGPLv2

[x]: License field in the package spec file matches the actual license.

-%defattr(-,root,root,-)

[x]: Each %files section contains %defattr if rpm < 4.4


No blocker

=== APPROVED ===

New Package SCM Request
=======================
Package Name: php-horde-Horde-Data
Short Description: Horde Data API
Owners: nb remi
Branches: el6 f18 f19
InitialCC:

Git done (by process-git-requests).

php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Data-2.0.3-3.el6,php-horde-Horde-Prefs-2.3.2-2.el6,php-horde-Horde-Mime-2.0.4-2.el6

php-horde-Horde-Mime-2.0.4-2.fc18, php-horde-Horde-Perms-2.1.0-1.fc18, php-horde-Horde-Prefs-2.3.2-2.fc18, php-horde-Horde-Data-2.0.3-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-horde-Horde-Data-2.0.3-3.fc18,php-horde-Horde-Prefs-2.3.2-2.fc18,php-horde-Horde-Perms-2.1.0-1.fc18,php-horde-Horde-Mime-2.0.4-2.fc18

php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6, php-horde-Horde-Icalendar-2.0.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.