Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime-1.4.1-1.fc16.src.rpm Description: Provides methods for dealing with MIME (RFC 2045) and related e-mail (RFC822/2822/5322) standards.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime-1.6.1-1.fc16.src.rpm
Please update to 2.0.x Please also consider php 5.5 patch attached in http://bugs.horde.org/ticket/11913
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime-2.0.3-2.fc17.src.rpm
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime-2.0.4-1.fc17.src.rpm
Created attachment 716472 [details] phpci.log phpci version 2.14.0.
Created attachment 716473 [details] review.txt Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785460
----- MUST: [!]: License field in the package spec file matches the actual license. Please correct License (with the comment) : # lib/Horde/Mime.php is BSD and LGPLv2 # other files are LGPLv2 License: LGPLv2 and BSD ----- SHOULD [!]: Requires correct, justified where necessary. A typo in the Requires list. BuildRequires: php-pear(PEAR) >= 1.7.0 Listed twice should be Requires: php-pear(PEAR) >= 1.7.0 ----- COULD [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required As Buildroot is not present, both could be clean (not a blocker)
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Mime-2.0.4-2.fc17.src.rpm
-License: LGPLv2 +# lib/Horde/Mime.php is BSD and LGPLv2 +# other files are LGPLv2 +License: LGPLv2 and BSD [x]: License field in the package spec file matches the actual license. -BuildRequires: php-pear(PEAR) >= 1.7.0 +Requires: php-pear(PEAR) >= 1.7.0 [x]: Requires correct, justified where necessary. -rm -rf %{buildroot} -%defattr(-,root,root,-) [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Package does not run rm -rf %{buildroot} All blockers fixed. === APPROVED ===
New Package SCM Request ======================= Package Name: php-horde-Horde-Mime Short Description: Horde MIME library Owners: nb remi Branches: el6 f18 f19 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Mime-2.0.4-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Mime-2.0.4-2.fc18
php-horde-Horde-Mime-2.0.4-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Mime-2.0.4-2.el6
php-horde-Horde-Mime-2.0.4-2.fc18, php-horde-Horde-Perms-2.1.0-1.fc18, php-horde-Horde-Prefs-2.3.2-2.fc18, php-horde-Horde-Data-2.0.3-3.fc18, php-horde-Horde-Icalendar-2.0.4-1.fc18 has been pushed to the Fedora 18 stable repository.
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6, php-horde-Horde-Icalendar-2.0.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.