Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar-1.1.1-1.fc16.src.rpm Description: An API for dealing with iCalendar data.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar-2.0.3-2.fc17.src.rpm
Created attachment 716524 [details] phpci.log phpci version 2.14.0.
Created attachment 716525 [details] review.txt Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785477
MUST [!]: License field in the package spec file matches the actual license. LGPLv2 SHOULD (but worth it as we have a blocker) [!]: Latest version is packaged. [!]: %check is present and all tests pass. version 2.0.4 is relesased which fix tests COULD (not a blocker, really) [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed As Buildroot is removed, both can be removed
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Icalendar-2.0.4-1.fc17.src.rpm
-# Need investigation (only fail in mock) -%global with_tests %{?_with_tests:1}%{!?_with_tests:0} [x]: %check is present and all tests pass. -Version: 2.0.3 -Release: 2%{?dist} +Version: 2.0.4 +Release: 1%{?dist} [x]: Latest version is packaged. -%defattr(-,root,root,-) [x]: Each %files section contains %defattr if rpm < 4.4 -License: LGPLv2+ +License: LGPLv2 [x]: License field in the package spec file matches the actual license. All blockers fixed. === APPROVED ===
New Package SCM Request ======================= Package Name: php-horde-Horde-Icalendar Short Description: Horde iCalendar API Owners: nb remi Branches: el6 f18 f19 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Mime-2.0.4-2.fc18, php-horde-Horde-Perms-2.1.0-1.fc18, php-horde-Horde-Prefs-2.3.2-2.fc18, php-horde-Horde-Data-2.0.3-3.fc18, php-horde-Horde-Icalendar-2.0.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Icalendar-2.0.4-1.fc18,php-horde-Horde-Data-2.0.3-3.fc18,php-horde-Horde-Prefs-2.3.2-2.fc18,php-horde-Horde-Perms-2.1.0-1.fc18,php-horde-Horde-Mime-2.0.4-2.fc18
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6, php-horde-Horde-Icalendar-2.0.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Icalendar-2.0.4-1.el6,php-horde-Horde-Perms-2.1.0-1.el6,php-horde-Horde-Data-2.0.3-3.el6,php-horde-Horde-Prefs-2.3.2-2.el6,php-horde-Horde-Mime-2.0.4-2.el6
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6, php-horde-Horde-Icalendar-2.0.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.