Bug 805417

We don't currently support inspection of installer disks
of Windows 2008, Windows 7 and Vista (not even upstream)
but it's something we're going to add.

This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

This request was erroneously removed from consideration in Red Hat Enterprise Linux 6.4, which is currently under development.  This request will be evaluated for inclusion in Red Hat Enterprise Linux 6.4.

No upstream fix.  Likely to be fixed in time for RHEL 7
by integrating libosinfo for CD/installer detection.
Setting RHEL 6.5 flags just in case we rebase.

*** Bug 811398 has been marked as a duplicate of this bug. ***

The upstream fix is:
https://github.com/libguestfs/libguestfs/commit/90e7981082a2685b235724a6dd9b737cb90fe553

This is RHEL 7 material since it involves libosinfo
integration.

PLEASE NOTE: Although I am reassigning this bug to libosinfo,
there's not necessarily a libosinfo bug here.  It's just so the
component is correct for QA if they do find problems.  Read on
for more details.

---

libguestfs now uses libosinfo for most ISO inspection
tasks.  Therefore inspection of ISOs of Windows should
Just Work, provided the ISOs are listed in the libosinfo
database.

---

Here is how to determine if libguestfs is using libosinfo:

(1) Pick an ISO.

(2) Run:

  virt-inspector -a Windows8-ConsumerPreview-64bit-English.iso -x -v

(3) In the log messages you should see something like:

libguestfs: osinfo: loading database from /usr/share/libosinfo/db/oses
libguestfs: osinfo: mapped disk to database entry 258

The first message ("loading database") indicates that libosinfo is
being used.

The second message ("mapped disk to database entry") indicates that
a match for your ISO was found in the libosinfo database.

(4) Check that virt-inspector correctly identified the ISO:

    <name>windows</name>
    <arch>x86_64</arch>
    <distro>windows</distro>
    <product_name>Microsoft Windows 8</product_name>
    <major_version>6</major_version>
    <minor_version>2</minor_version>
    <format>installer</format>

Is that what you expected for this ISO?

---

If libguestfs is using libosinfo, but is not identifying an ISO
correctly, that is a bug *in libosinfo*.  You'll have to get the
disk information from the ISO and submit it upstream:

  $ isoinfo -d -i Windows8-ConsumerPreview-64bit-English.iso >& info.txt

---

If libguestfs is *not* using libosinfo at all and is not identifying
an ISO correctly, that is a bug *in libguestfs*.

Test "inspect-get-format" with libguestfs-1.27.22-1.3.el7.x86_64 


+-----------+---------+----------+
|  OS type  |  Arch   |  Result  |
+-----------+---------+----------+
|  RHEL4.9  |  i386   |   PASS   |
+-----------+---------+----------+
|  RHEL4.9  | x86_64  |   PASS   |
+-----------+---------+----------+
|  RHEL5.11 |  i386   |   PASS   |
+-----------+---------+----------+
|  RHEL5.11 | x86_64  |   PASS   |
+-----------+---------+----------+
|  RHEL6.6  |  i386   |   PASS   |
+-----------+---------+----------+
|  RHEL6.6  | x86_64  |   PASS   |
+-----------+---------+----------+
|  RHEL7.0  | x86_64  |   PASS   |
+-----------+---------+----------+
|  WindowXP |  i386   |   PASS   |
+-----------+---------+----------+
|  WindowXP |  x86_64 |   PASS   |     
+-----------+---------+----------+
|  Win2003  |  i386   |   PASS   | 
+-----------+---------+----------+
|  Win2003  | x86_64  |   PASS   |
+-----------+---------+----------+
|  Win2003r2| x86_64  |   PASS   |
+-----------+---------+----------+
|  Win2008  |  i386   |   PASS   |
+-----------+---------+----------+
|  Win2008  | x86_64  |   PASS   |
+-----------+---------+----------+
|  Win2012  | x86_64  |   FAIL   |
+-----------+---------+----------+
| Win2012r2 | x86_64  |   FAIL   |
+-----------+---------+----------+
|    Win7   |  i386   |   PASS   |
+-----------+---------+----------+
|    Win7   | x86_64  |   FAIL   |  
+-----------+---------+----------+
| Win-vista |  i386   |   PASS   |
+-----------+---------+----------+
| Win-vista | x86_64  |   PASS   |
+-----------+---------+----------+
|    Win8   |  i386   |   FAIL   |
+-----------+---------+----------+
|    Win8   | x86_64  |   FAIL   |
+-----------+---------+----------+


For the failed test, using virt-inspector to check, the result indicates that libosinfo is being used.

Full log is attached.

Created attachment 926329 [details]
virt-inspector -a en_windows_8_1_enterprise_x64_dvd_2971902.iso -x -v

Created attachment 926330 [details]
isoinfo -d -i en_windows_8_1_enterprise_x64_dvd_2971902.iso

Bo: Can you open new bugs *against libosinfo* for each failing guest.

For each one, include the isoinfo information.

(In reply to Richard W.M. Jones from comment #17)
> Bo: Can you open new bugs *against libosinfo* for each failing guest.
> 
> For each one, include the isoinfo information.

Sure, bugs submitted.

Version: libguestfs-1.28.1-1.9.el7.x86_64

# guestfish -a en_windows_server_2012_r2_x64_dvd_2707946.iso run : inspect-os : inspect-get-format /dev/sda
/dev/sda
installer
# guestfish -a en_windows_7_ultimate_with_sp1_x64_dvd_u_677332.iso run : inspect-os : inspect-get-format /dev/sda
/dev/sda
installer
# guestfish -a en_windows_8_enterprise_x64_dvd_917522.iso  run : inspect-os : inspect-get-format /dev/sda
/dev/sda
installer
# guestfish -a en_windows_8_enterprise_x86_dvd_917587.iso  run : inspect-os : inspect-get-format /dev/sda
/dev/sda
installer
# 

Verified as above.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0303.html