Bug 827269
| Summary: | ksflatten ignoring nested includes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joey Boggs <jboggs> | ||||||||
| Component: | pykickstart | Assignee: | Chris Lumens <clumens> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 17 | CC: | bcl, cdevine, clumens, john, mburns | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | pykickstart-1.99.13-1 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2013-04-10 14:31:53 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 819672 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 588227 [details]
successful flatten
Any chance someone can look at this? This is strongly impacting oVirt-node. It forces us to manually roll back to the F16 version of pykickstart and prevent ever updating it. Thanks Created attachment 591669 [details]
patch
*** Bug 819672 has been marked as a duplicate of this bug. *** I built 1.99.12 before lunch, but didn't push yet. This'll be fixed in 1.99.13 instead. *** Bug 838713 has been marked as a duplicate of this bug. *** I see the build in F18, but can this be built for F17 as well? This is a significant pain point for building ovirt-node and keeping the build machines relatively up to date. Thanks http://koji.fedoraproject.org/koji/taskinfo?taskID=4353353 This build works for me *** Bug 846835 has been marked as a duplicate of this bug. *** The F18/rawhide build works for me too, but it would be much appreciated if we could backport this fix into F17 as well. Any chance of that happening? pykickstart-1.99.15-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/pykickstart-1.99.15-1.fc17 Package pykickstart-1.99.15-1.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing pykickstart-1.99.15-1.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-11727/pykickstart-1.99.15-1.fc17 then log in and leave karma (feedback). Works for me, many thanks!! |
Created attachment 588226 [details] failed flatten ksflatten seems to ignore nested %includes and places the section directly into the resulting kickstart. 1.99-4.1 from F16 works fine, 1.99-11 through 18 aren't working # ovirt16 Node image recipe %include common-install.ks %include ovirt16-install.ks %include repos.ks %packages --excludedocs --nobase %include common-pkgs.ks %include ovirt16-pkgs.ks %end %post %include common-post.ks %include ovirt16-post.ks %end %post --nochroot %include common-nochroot.ks %end %include image-minimizer.ks %include common-manifest.ks attaching resulting kickstart, not sure if something has changed in syntax or just a bug