Various desktop entry files from redhat-menus are missing the Encoding key and use the deprecated "Terminal=0". Will attach a patch.
Created attachment 94782 [details] Add Encoding's and use Terminal=false Oh, and BTW, the tarball is a bzipped but the filename is *.gz ... :)
*** Bug 105793 has been marked as a duplicate of this bug. ***
Patch applied to cvs, thanks. Need to rebuild.
*** Bug 107597 has been marked as a duplicate of this bug. ***
As of 3.7.1-9, the following still lack the Encoding key: /etc/X11/starthere/preferences.desktop /usr/share/desktop-menu-patches/gnome-pilot.desktop /usr/share/desktop-menu-patches/gnome-accessibility.desktop /usr/share/desktop-menu-patches/redhat-gnomemeeting.desktop /usr/share/desktop-menu-patches/redhat-diagrams.desktop
assuming the build finishes okay, this should be fixed in tomorrow rawhide.
Isn't the Encoding key now deprecated in the desktop entry spec? From http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.0.html#deprecated-items (bullet point 4): The Encoding key is deprecated. It was used to specify whether keys of type localestring were encoded in UTF-8 or in the specified locale. Possible values are UTF-8 and Legacy-Mixed. See Appendix D, The Legacy-Mixed Encoding (Deprecated) for more details.
That's true, it's deprecated nowadays. It wasn't in 2003 nor 2005 when I reported/commented on this bug ;) I think the spec is somewhat unclear about how exactly should the encodings be specified nowadays, but I guess it's like Comment[fi.ISO-8859-1]=... and for things of type localestring only (encoding being optional, and defaulting to UTF-8, in which case it can be omitted). http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.0.html#localized-keys
It doesn't hurt to add it as long as it's set to UTF-8, though. It just makes the file more compatible.