Bug 1113000 - foreman-integration: declare errors for foreman return values
Summary: foreman-integration: declare errors for foreman return values
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.5.0
Assignee: Yaniv Bronhaim
QA Contact: movciari
URL:
Whiteboard: infra
: 1124887 (view as bug list)
Depends On: 1165208
Blocks: rhev3.5beta3
TreeView+ depends on / blocked
 
Reported: 2014-06-25 08:57 UTC by Yaniv Bronhaim
Modified: 2016-02-10 19:13 UTC (History)
10 users (show)

Fixed In Version: org.ovirt.engine-root-3.5.0-13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-17 17:16:22 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 31179 0 master MERGED webadmin, core: Return specific provider authentication error Never
oVirt gerrit 33063 0 ovirt-engine-3.5 MERGED webadmin, core: Return specific provider authentication error Never

Description Yaniv Bronhaim 2014-06-25 08:57:34 UTC 
Such as "name already exist", "value error", "syntax error" and so on. Currently such errors throws VdcBllErrors.PROVIDER_FAILURE that doesn't explain anything about the failure and it forces the user to check for foreman's production log to understand what's wrong.
Comment 1 Oved Ourfali 2014-08-12 08:12:20 UTC 
*** Bug 1124887 has been marked as a duplicate of this bug. ***
Comment 2 Yaniv Bronhaim 2014-08-30 00:18:18 UTC 
patch 31179 is just partial of the fix. we still need to find more generic solution to show foreman's response
Comment 3 Eyal Edri 2014-09-28 11:29:47 UTC 
this bug was moved to MODIFIED before vt4 build date thus moving to ON_QA.
if you belive this bug isn't in vt4, please report to rhev-integ
Comment 4 Petr Beňas 2014-11-11 11:55:52 UTC 
This looks like a code change and it seems there is nothing to be tested here. If you think otherwise, please provide steps to reproduce.
Comment 5 Yaniv Bronhaim 2014-11-11 15:39:17 UTC 
Its really easy to see this case. this bug is a bit similar to Bug 1124891 but talking only on AuthenticationError (maybe we should update the title). referring to the patch comment you see:
""""
On addProvider form the user fills authentication parameters to
communicate with external provider.
This patch adds more detailed warning message if the parameters are
wrong and the authentication failed.
""""

this quite explains the test case
Comment 6 Eyal Edri 2015-02-17 17:16:22 UTC 
rhev 3.5.0 was released. closing.
Note You need to log in before you can comment on or make changes to this bug.