Bug 1332162 - Support mandatory locking in glusterfs
Summary: Support mandatory locking in glusterfs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: locks
Version: 3.8.0
Hardware: All
OS: All
medium
medium
Target Milestone: ---
Assignee: Anoop C S
QA Contact:
URL:
Whiteboard:
Depends On: GLUSTER-452
Blocks: glusterfs-3.8.0
TreeView+ depends on / blocked
 
Reported: 2016-05-02 11:42 UTC by Anoop C S
Modified: 2016-06-16 14:04 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Enhancement
Doc Text:
Clone Of: GLUSTER-452
Environment:
Last Closed: 2016-06-16 14:04:45 UTC
Regression: RTP
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Anoop C S 2016-05-02 11:42:47 UTC
+++ This bug was initially created as a clone of Bug #762184 +++

Need to get mandatory locking supported over glusterfs.

--- Additional comment from Vijay Bellur on 2010-08-28 14:45:51 IST ---

No immediate plans to address this.

--- Additional comment from Anand Avati on 2015-02-27 15:00:45 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#1) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-03-12 17:23:57 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#2) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-03-30 14:17:13 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#3) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-04-29 17:24:35 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#4) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-05-04 15:19:28 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#5) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-06-04 16:30:05 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#7) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-06-04 16:30:08 IST ---

REVIEW: http://review.gluster.org/11082 (features/locks: Include zerofill fop in locks translator) posted (#2) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-06-05 11:05:42 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#8) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-06-05 11:05:45 IST ---

REVIEW: http://review.gluster.org/11082 (features/locks: Include zerofill call in locks translator) posted (#3) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-06-08 17:23:27 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#9) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-06-11 14:43:09 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#10) for review on master by Anoop C S (achiraya)

--- Additional comment from Anand Avati on 2015-08-24 16:52:00 IST ---

REVIEW: http://review.gluster.org/11177 (gfapi: Add API support for applying mandatory-locks) posted (#2) for review on master by Anoop C S (anoopcs)

--- Additional comment from Anand Avati on 2015-08-26 15:52:41 IST ---

REVIEW: http://review.gluster.org/11177 (gfapi: Add API support for applying mandatory-locks) posted (#3) for review on master by Raghavendra Talur (rtalur)

--- Additional comment from Kaleb KEITHLEY on 2015-10-22 21:16:38 IST ---

because of the large number of bugs filed against mainline version\ is ambiguous and about to be removed as a choice.

If you believe this is still a bug, please change the status back to NEW and choose the appropriate, applicable version for it.

--- Additional comment from Anoop C S on 2015-11-24 14:54:04 IST ---

As part of preparing GlusterFS to work with multi-Protocol environment we have to support basic mandatory locking semantics. Please see the following design doc for more details.

http://review.gluster.org/#/c/12014/1/in_progress/Mandatory+Locks.md

--- Additional comment from Vijay Bellur on 2015-12-02 06:29:38 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#12) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2015-12-02 06:29:42 IST ---

REVIEW: http://review.gluster.org/11082 (features/locks: Include zerofill fop in locks translator) posted (#6) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2015-12-02 13:01:09 IST ---

REVIEW: http://review.gluster.org/11177 (gfapi: Add API support for applying mandatory-locks) posted (#5) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2015-12-09 18:02:09 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#13) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2015-12-09 18:02:13 IST ---

REVIEW: http://review.gluster.org/11177 (gfapi: Add API support for applying mandatory-locks) posted (#6) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2015-12-09 18:02:17 IST ---

REVIEW: http://review.gluster.org/11082 (features/locks: Include zerofill fop in locks translator) posted (#7) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2015-12-09 18:02:20 IST ---

REVIEW: http://review.gluster.org/12924 (tests: Add libgfapi test case for mandatory locks) posted (#1) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-01-06 12:52:08 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Fixing mandatory-locking code path) posted (#14) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-01-06 12:52:13 IST ---

REVIEW: http://review.gluster.org/11177 (gfapi: Add API support for applying mandatory-locks) posted (#7) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-01-06 12:52:17 IST ---

REVIEW: http://review.gluster.org/11082 (features/locks: Include zerofill fop in locks translator) posted (#8) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-01-19 14:39:24 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#15) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-01-19 14:39:28 IST ---

REVIEW: http://review.gluster.org/11177 (libgfapi: Add support for mandatory-locks) posted (#8) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-02-05 17:24:53 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#16) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-02-05 17:24:56 IST ---

REVIEW: http://review.gluster.org/11177 (libgfapi: Add new api for supporting mandatory-locks) posted (#9) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-02-10 18:27:22 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#17) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-02-10 18:27:25 IST ---

REVIEW: http://review.gluster.org/11177 (libgfapi: Add new api for supporting mandatory-locks) posted (#10) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-02-18 17:47:24 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#18) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-02-18 17:47:27 IST ---

REVIEW: http://review.gluster.org/11177 (libgfapi: Add new api for supporting mandatory-locks) posted (#11) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-02-18 18:26:14 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#19) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-02-18 18:26:18 IST ---

REVIEW: http://review.gluster.org/11177 (libgfapi: Add new api for supporting mandatory-locks) posted (#12) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-03-01 21:28:44 IST ---

REVIEW: http://review.gluster.org/11177 (libgfapi: Add new api for supporting mandatory-locks) posted (#13) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-03-03 20:31:04 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#20) for review on master by Anoop C S (anoopcs)

--- Additional comment from Mike McCune on 2016-03-29 03:45:42 IST ---

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

--- Additional comment from Vijay Bellur on 2016-04-12 23:37:38 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#21) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-04-13 10:47:56 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#22) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-04-29 11:03:47 IST ---

REVIEW: http://review.gluster.org/9768 (features/locks: Implement mandatory locks) posted (#23) for review on master by Anoop C S (anoopcs)

--- Additional comment from Vijay Bellur on 2016-05-02 16:48:49 IST ---

COMMIT: http://review.gluster.org/9768 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 4517bf8dd6de310950cc5a612955aa3a2fddb57e
Author: Anoop C S <anoopcs>
Date:   Wed Feb 4 10:34:33 2015 +0530

    features/locks: Implement mandatory locks
    
    Initial change to fix/enable the mandatory locking support in GlusterFS
    as per the following design:
    
    https://review.gluster.org/#/c/12014/
    
    Accordingly 'locks.mandatory-locking' option is available as part of this
    change which will accept one among the following values:
    
    * off
    * file
    * forced
    * optimal
    
    See design doc for more details
    
    Change-Id: I14c489b3f8af5ebcbfa155a03f0c175e9558ac46
    BUG: 762184
    Signed-off-by: Anoop C S <anoopcs>
    Reviewed-on: http://review.gluster.org/9768
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Vijay Bellur 2016-05-02 11:44:37 UTC
REVIEW: http://review.gluster.org/14149 (features/locks: Implement mandatory locks) posted (#1) for review on release-3.8 by Anoop C S (anoopcs)

Comment 2 Vijay Bellur 2016-05-03 09:25:01 UTC
COMMIT: http://review.gluster.org/14149 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit f5e52561d66f3777e4ec75992e52200779d9add1
Author: Anoop C S <anoopcs>
Date:   Wed Feb 4 10:34:33 2015 +0530

    features/locks: Implement mandatory locks
    
    Initial change to fix/enable the mandatory locking support in GlusterFS
    as per the following design:
    
    https://review.gluster.org/#/c/12014/
    
    Accordingly 'locks.mandatory-locking' option is available as part of this
    change which will accept one among the following values:
    
    * off
    * file
    * forced
    * optimal
    
    See design doc for more details
    
    > Reviewed-on: http://review.gluster.org/9768
    > Smoke: Gluster Build System <jenkins.com>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Poornima G <pgurusid>
    > Reviewed-by: Raghavendra Talur <rtalur>
    > Reviewed-by: Rajesh Joseph <rjoseph>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    
    (cherry picked from commit 4517bf8dd6de310950cc5a612955aa3a2fddb57e)
    
    Change-Id: I14c489b3f8af5ebcbfa155a03f0c175e9558ac46
    BUG: 1332162
    Signed-off-by: Anoop C S <anoopcs>
    Reviewed-on: http://review.gluster.org/14149
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 3 Anoop C S 2016-06-13 16:28:19 UTC
BZ #1346010 has been raised to keep track of libgfapi changes related to mandatory-lock support for GlusterFS.

Comment 4 Niels de Vos 2016-06-16 14:04:45 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.