Red Hat Bugzilla – Bug 175848
Review Request: xfce4-taskmanager
Last modified: 2007-11-30 17:11:19 EST
Spec Name or Url:
SRPM Name or Url:
Taskmanager for the Xfce desktop environment
rpmlint ist clean
builds fien in mock on core 4
license GPL & inluded
Smart guy. =). Set to FE-ACCEPT.
(In reply to comment #1)
> Smart guy. =). Set to FE-ACCEPT.
Maybe it's just me, but I can hardly call that a *review*... :-(
I meant that I couldn't find any errors using rpmlint and mock. Sorry if you
found my comment a bit offensive as it seems my quote failes to bring positive
The problem is that there is quite a bit more that should be reviewed, beside
just rpmlint errors & whether it builds correctly in mock. There is nothing in
your comments showing that you check any of the items listed in the
PackageReview list from the wiki.
For an example of what some other people's reviews look like, refer to:
Luya, first of all I want to thank you for your work, but I'm having some
problems with your reviews too. I joined FE just a short time before you so I
think I still have a lot to learn. More detailed reviews would be helpful.
This also has been mentioned on fedora-extras-list, see
One package had a md5sum mismatch, that I didn't notice, the tarball had
silently been changed upstream (bug #173543). I downloaded all sources again
and compared the sums so I'm sure they should match now, nevertheless I'd feel
more comfortable if I knew somebody else checked the md5sums too.
If anybody else would like to review (some of) my packages, he's highly welcome.
ATM there are the following packages still to be reviewed:
bug #173549 xfce4-mount-plugin
bug #173552 xfce4-sensors-plugin
bug #173553 xfce4-websearch-plugin
bug #173653 xfce4-quicklauncher-plugin
bug #173660 xfce4-diskperf-plugin
bug #173550 xfce4-netload-plugin
bug #173661 xfce4-fsguard-plugin
which have been reviewed by Luya but lack some detailed information.
My bad. I will be carefull next time.
Detailed review (not too vague this time)
+ mock succesfully built the source package. No errors reported
+ rpmlint did not complain. No warning nor errors reported
+ package follow the PackageNameGuideline procedure:
+ tarball from source rpm matched source url listed on spec file. Both matched
by md5sum and sha1sum
+ No error reported after install and removed package
+ License listed on SPEC file matches the source tarball :
+ SPEC file conform to PackagingGuideline
P.S: I got a lesson to be more detailed as possible
Built fine for Core 3 and 4 on all arches, Rawhide is inconsistent atm. Closing.