Bug 2026789 - Plasma panel style resets back to dark after changing it to light one on main page in "System Settings"
Summary: Plasma panel style resets back to dark after changing it to light one on main...
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Fedora
Classification: Fedora
Component: plasma-workspace
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: KDE SIG
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2072648 2081231 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-25 20:01 UTC by Yaroslav Sidlovsky
Modified: 2024-04-10 06:28 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-04-10 06:28:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Fedora 35 KDE Spin.webm (1.59 MB, video/webm)
2021-11-25 20:02 UTC, Yaroslav Sidlovsky
no flags Details
Breeze theme bug (575.17 KB, image/png)
2021-11-30 14:53 UTC, FSA
no flags Details
Breeze theme bug 2 (692.43 KB, image/png)
2021-11-30 14:54 UTC, FSA
no flags Details
The beauty of the default theme (625.18 KB, image/png)
2022-01-19 17:12 UTC, FSA
no flags Details
The beauty of the default theme 2 (567.34 KB, image/png)
2022-01-19 17:13 UTC, FSA
no flags Details


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 431219 0 HI RESOLVED Overriding settings (icons, plasma theme, wallpaper, etc) set by a global theme causes those changes to be discarded aft... 2021-11-29 21:57:41 UTC

Description Yaroslav Sidlovsky 2021-11-25 20:01:54 UTC
Description of problem:
Plasma style resets back to dark after changing it on main page in "System Settings".

Version-Release number of selected component (if applicable):
kf5-plasma-5.88.0-1.fc35.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. Open "System Settings", select "Dark Theme", click "Apply";
2. Select "Light Theme", click "Apply" and close "System Settings";
3. Open "System Settings" again - panel would become dark.

Actual results:
Panel changes it style to dark. 

Expected results:
Panel should stay light after choosing "Light Theme" in the settings & saving them.

Additional info:
Bug could be easily reproduced in the VM with Fedora 35 KDE Spin.
I'm using F35-KDE-x86_64-LIVE-20211115.iso to reproduce it.
Updated to latest package versions of course.

Comment 1 Yaroslav Sidlovsky 2021-11-25 20:02:47 UTC
Created attachment 1843629 [details]
Fedora 35 KDE Spin.webm

Video with live bug demonstration.

Comment 2 Yaroslav Sidlovsky 2021-11-25 20:05:01 UTC
According to my findings this bug is caused by the `plasma-workspace-5.3.0-set-fedora-default-look-and-feel.patch`:

1. https://src.fedoraproject.org/rpms/plasma-workspace/blob/rawhide/f/plasma-workspace.spec#_449
2. https://src.fedoraproject.org/rpms/plasma-workspace/blob/rawhide/f/plasma-workspace-5.3.0-set-fedora-default-look-and-feel.patch

Bug can't be reproduced if this patch is not applied to the package.

Comment 3 FSA 2021-11-25 20:27:46 UTC
The problem appeared on Fedora 34.
After changing the theme to a dark setting, they consider that the Brese theme is active and do not allow it to be activated.
When you restart the system, the theme changes in the same way. Distorted colors sometimes appear: light background, white text. This is how the main menu looks like and the background with date/time on the panel.
In addition, when the light theme is activated, the panel has no transparency. I managed to partially solve the problem by manually editing the ~/.config/plasmarc file by adding a section [Theme] parameter "name=Breeze". After saving the file, transparency is immediately added to the panel. This hack solves the problem before changing the theme through the settings.

Comment 4 FSA 2021-11-25 20:52:43 UTC
Bug & hack demo: https://youtu.be/sa8UkbqBYvM

Comment 5 FSA 2021-11-29 16:06:39 UTC
I suggest renaming the patch to "Breeze theme does not work correctly due to patch" (Russian: Тема Breeze не работает корректно из-за патча).

Comment 6 Rex Dieter 2021-11-29 17:15:59 UTC
I'd argue this is an upstream bug (somewhere), please report to them if they're not already aware.
It should be possible for downstreams to adjust default theming without side-effects like this.

Comment 7 Yaroslav Sidlovsky 2021-11-29 18:16:36 UTC
It's not upstream bug.
Issue can't be reproduced on KDE Neon.
And I repeat - issue is gone if patch is not applied.

Comment 8 Yaroslav Sidlovsky 2021-11-29 18:17:08 UTC
I've already reported it to upstream - no one can reproduce it.

Comment 9 Yaroslav Sidlovsky 2021-11-29 18:19:15 UTC
See: https://bugs.kde.org/show_bug.cgi?id=431219.

Comment 10 Nate Graham 2021-11-29 18:32:59 UTC
FWIW I build Plasma from source myself on top of Fedora's packages, so I don't have that patch, and I don't experience the bug.

Comment 11 FSA 2021-11-30 05:52:40 UTC
I participated in the discussion of this bug on the site kde.org. Together with the participants of the Russian Fedora, we investigated the issue. A patch was found in Fedora that breaks the topic. I checked for KDE Neon. There this bug is not reproduced without looking at a similar version of KDE plasma and KDE framework.

Comment 12 FSA 2021-11-30 14:53:50 UTC
Created attachment 1844181 [details]
Breeze theme bug

Comment 13 FSA 2021-11-30 14:54:39 UTC
Created attachment 1844183 [details]
Breeze theme bug 2

Comment 14 FSA 2021-11-30 14:56:04 UTC
Theme colors are sometimes distorted after restart

Comment 15 FSA 2021-12-02 18:18:15 UTC
Rebuilt from source
Drop from spec file:
---
## upstream patches
# FIXME/TODO: commented out in need of work: does not applyl cleanly and
# potentially causes problems:
# Since it appears plasma-workspace no longer uses kinit, the KToolInvocation::invokeTerminal call may not be 100% reliable
#%patch100 -p1 -b .konsole-in-contextmenu
# FIXME/TODO:  it is unclear whether this is needed or even a good idea anymore -- rex
%if 0%{?default_lookandfeel:1}
%patch101 -p1 -b .set-fedora-default-look-and-feel
sed -i -e "s|@DEFAULT_LOOKANDFEEL@|%{?default_lookandfeel}%{!?default_lookandfeel:org.kde.breeze.desktop}|g" \
  shell/packageplugins/lookandfeel/lookandfeel.cpp
%endif
%patch105 -p1
---
Install plasma-workspace-x11-5.23.3-1.fc35.x86_64.rpm. Everything now works correctly.

Comment 16 FSA 2021-12-02 18:25:34 UTC
P.S. "Fedora" theme now doesn't work correctly, but you can use the "Breeze Twight" instead, which is no different.

Comment 17 Rex Dieter 2021-12-02 20:38:11 UTC
Dropping that patch also removes breeze twilight from being the default plasma theme (something that is not an option to consider as a fix).

Comment 18 Rex Dieter 2021-12-02 20:52:00 UTC
I think I found a bug in our implementation, plasma-workspace.spec contains code:

# Populate initial lookandfeel package
cp -a lookandfeel lookandfeel.fedora
# Overwrite settings to configure twilight mode
cp -a lookandfeel.twilight/* lookandfeel.fedora
install -m 0644 %{SOURCE15} lookandfeel.fedora/metadata.desktop

So, that first step copies "lookandfeel" folder, which happens to be the plasma breeze theme, and then copies twilight contents on top of that.
If the intention is to simply use twilight, not sure why we didn't do this instead:

# Populate initial lookandfeel package from twilight
cp -a lookandfeel.twilight lookandfeel.fedora
install -m 0644 %{SOURCE15} lookandfeel.fedora/metadata.desktop

I'll ask around and test this.

Comment 19 FSA 2021-12-28 05:37:20 UTC
plasma-workspace-x11-5.23.4 also requires the removal of patches.

Comment 20 FSA 2022-01-19 17:12:30 UTC
Created attachment 1851893 [details]
The beauty of the default theme

Comment 21 FSA 2022-01-19 17:13:08 UTC
Created attachment 1851894 [details]
The beauty of the default theme 2

Comment 22 Rex Dieter 2022-01-19 19:21:03 UTC
Ok, so my findings and assumptions were incorrect.

There's still likely an upstream bug *somewhere*, and unless there comes some other (better?) way of implementing a different default theme, we won't be dropping the look-n-feel.patch

Comment 23 FSA 2022-01-19 20:14:10 UTC
The bug is reproduced only on Fedora 33+. It is associated with crooked patches.  Other distributions, including KDE Neon, do not contain bugs.

Comment 24 Rex Dieter 2022-01-19 21:33:59 UTC
I guess we'll have to agree to disagree whether it's a valid (or crooked) patch or not.

Comment 25 FSA 2022-02-26 08:48:39 UTC
Fixed with the release of 5.24.2

Comment 26 FSA 2022-03-01 20:30:20 UTC
Another update for plasma-workspace brought back the problem. Maybe they fixed another bug - https://bugzilla.redhat.com/show_bug.cgi?id=2053790

Comment 27 Jan Grulich 2022-05-21 18:18:30 UTC
*** Bug 2081231 has been marked as a duplicate of this bug. ***

Comment 28 Ben Cotton 2022-11-29 17:24:12 UTC
This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 29 Ben Cotton 2022-12-13 15:59:42 UTC
Fedora Linux 35 entered end-of-life (EOL) status on 2022-12-13.

Fedora Linux 35 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 30 Artem 2024-04-06 11:02:43 UTC
Can we reopen this please? The bug is back in new versions of KDE. Users still complain about this bug but struggle to file a bug in RHBZ.

Comment 31 Artem 2024-04-06 11:03:22 UTC
*** Bug 2072648 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.