Bug 2075949 - Review Request: bungee-fonts - bungee desktop fonts
Summary: Review Request: bungee-fonts - bungee desktop fonts
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-04-16 14:19 UTC by Benson Muite
Modified: 2023-08-21 03:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 2 Benson Muite 2022-04-19 00:21:16 UTC
Thanks for the review. Updated the name and spec file:

Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/fed500/djr-bungee-fonts/djr-bungee-fonts.git/tree/djr-bungee-fonts.spec?h=f34

COPR URL: https://copr.fedorainfracloud.org/coprs/fed500/djr-bungee-fonts/

The following seem related - maybe some changes are needed to ensure debuginfo is does not get packaged:
https://pagure.io/releng/issue/6863
https://src.fedoraproject.org/rpms/redhat-rpm-config//blob/rawhide/f/buildflags.md

The release itself does not contain the documentation files that are available on GitHub at https://github.com/djrrb/Bungee Should these be added as Source2 ?

Comment 3 Benson Muite 2022-04-19 00:27:49 UTC
Some more changes are needed to get the proper names of the styles/weights - Regular, Inline, Outline, Shadow and Shade.

Comment 4 Benson Muite 2022-04-19 12:01:49 UTC
Foundry is DJR https://github.com/djrrb/Bungee/issues/74

Comment 5 Benson Muite 2022-04-19 17:58:01 UTC
Weight naming problems in Inkscape and Gimp seem related to how these are implemented in these applications, and names appear correctly in text editors such as Kwrite and Gedit.

Comment 6 Parag AN(पराग) 2022-04-20 09:07:34 UTC
When you write font family you need to write only family name and not with its style name.

This packaging looks complex to me. If you only want to package "Bungee_Desktop" fonts then there should be 13 subpackages to be created. See
Bungee/Bungee-Hairline.otf:Family:              Bungee Hairline
Bungee/Bungee-Inline.otf:Family:              Bungee Inline
Bungee/Bungee-Outline.otf:Family:              Bungee Outline
Bungee/Bungee-Regular.otf:Family:              Bungee Regular
Bungee/Bungee-Shade.otf:Family:              Bungee Shade
BungeeLayers/BungeeLayers-Inline.otf:Family:              Bungee Layers Inline
BungeeLayers/BungeeLayers-Outline.otf:Family:              Bungee Layers Outline
BungeeLayers/BungeeLayers-Regular.otf:Family:              Bungee Layers Regular
BungeeLayers/BungeeLayers-Shade.otf:Family:              Bungee Layers Shade
BungeeLayersRotated/BungeeLayersRotated-Inline.otf:Family:              Bungee Layers Rotated Inline
BungeeLayersRotated/BungeeLayersRotated-Outline.otf:Family:              Bungee Layers Rotated Outline
BungeeLayersRotated/BungeeLayersRotated-Regular.otf:Family:              Bungee Layers Rotated Regular
BungeeLayersRotated/BungeeLayersRotated-Shade.otf:Family:              Bungee Layers Rotated Shade

as seen above, use family name as shown above for those 13 sub-packages.
Then you can also add 3 more meta subpackages like djr-bungee-fonts-all, djr-bungee-layers-fonts-all and djr-bungee-layers-rotated-fonts-all.
Then one final subpackage called djr-bungee-desktop-fonts-all that installs djr-bungee-fonts-all, djr-bungee-layers-fonts-all and djr-bungee-layers-rotated-fonts-all.
The final specfile should generate 17 binary rpms.
I suggest name this package as djr-bungee-desktop-fonts.
These are just my suggestions, need to check if it can be implemented.

I saw you need sponsorship in Fedora packager group. Have you submitted anymore packages or you already tried reviewing other contributor's packages?
------------------------------------------------------------------------------
If you are new RPM packager and want to package some software in Fedora then
you will need Sponsorship for your package. To get sponsor for your package
in packager group, please follow these things.

Make sure you have followed steps given on
https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/

We have this process, 
https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsored_into_the_Packager_Group/ to 
get sponsored into the packager group. When you submit your first submission,
it will be good if you either submit few more packages and/or do some full detailed
package reviews. This is needed to make sure package submitter understands the
rpm packaging well and follows the fedora packaging guidelines.
Check more on this at 
https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsored_into_the_Packager_Group/#convincing_someone_to_sponsor_you

Please go through the following links
1) https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/

2) https://docs.fedoraproject.org/en-US/packaging-guidelines/

3) To find the packages already submitted for review,
   check http://fedoraproject.org/PackageReviewStatus/

4) https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ and
   https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_reviewer is useful 
   while doing package reviews.

5) https://pagure.io/FedoraReview this is fedora-review tool to help
   review packages in fedora. You need to use this and do un-official package 
   reviews of packages submitted by other contributors. While doing so mention 
   "This is un-official review of the package." at top of your review comment.
   You can install this tool on your Fedora system by running command
   "sudo dnf install fedora-review"

Good to review packages listed in https://fedoraproject.org/PackageReviewStatus/reviewable.html
or https://fedoraproject.org/PackageReviewStatus/needsponsor.html

When you do full package review of some packages, provide that review comment 
link here so that I can look how you have reviewed those packages. An example
command to run fedora-review on any package review bugzilla is

fedora-review -b <bugid> -m fedora-rawhide-x86_64

If you got any questions please do ask here.
---------------------------------------------------------------------------------------------------------

Comment 7 Parag AN(पराग) 2022-04-20 10:11:18 UTC
You can refer to some already implemented multi-family font packaging examples as
https://src.fedoraproject.org/rpms/culmus-fonts/blob/rawhide/f/culmus-fonts.spec
https://src.fedoraproject.org/rpms/khmer-os-fonts/blob/rawhide/f/khmer-os-fonts.spec

I think khmer-os-fonts is best example for you to follow for bungee desktop font packaging.

Comment 8 Benson Muite 2022-04-21 07:10:33 UTC
Thanks for the suggestions.  Have one other ticket https://bugzilla.redhat.com/show_bug.cgi?id=1813687

Made some comments on libarrow (have made some contributions to the main Arrow project):
https://bugzilla.redhat.com/show_bug.cgi?id=2054708#c14
https://bugzilla.redhat.com/show_bug.cgi?id=2055596

Comment 9 Parag AN(पराग) 2022-04-22 04:27:45 UTC
Thanks. I will sponsor you once this package gets approved.

Comment 10 Benson Muite 2022-04-24 09:36:45 UTC
There are also Bungee Basic (ttf), Bungee ColorFonts (ttf, html, woff and woff2) and Bungee Web (eot, woff and woff2) Fonts. As such, maybe the following is reasonable:
Bungee/Bungee-Hairline.otf:Family:              Bungee Desktop Hairline
Bungee/Bungee-Inline.otf:Family:              Bungee Desktop Inline
Bungee/Bungee-Outline.otf:Family:              Bungee Desktop Outline
Bungee/Bungee-Regular.otf:Family:              Bungee Desktop Regular
Bungee/Bungee-Shade.otf:Family:              Bungee Desktop Shade
BungeeLayers/BungeeLayers-Inline.otf:Family:              Bungee Desktop Layers Inline
BungeeLayers/BungeeLayers-Outline.otf:Family:              Bungee Desktop Layers Outline
BungeeLayers/BungeeLayers-Regular.otf:Family:              Bungee Desktop Layers Regular
BungeeLayers/BungeeLayers-Shade.otf:Family:              Bungee Desktop Layers Shade
BungeeLayersRotated/BungeeLayersRotated-Inline.otf:Family:              Bungee Desktop Layers Rotated Inline
BungeeLayersRotated/BungeeLayersRotated-Outline.otf:Family:              Bungee Desktop Layers Rotated Outline
BungeeLayersRotated/BungeeLayersRotated-Regular.otf:Family:              Bungee Desktop Layers Rotated Regular
BungeeLayersRotated/BungeeLayersRotated-Shade.otf:Family:              Bungee Desktop Layers Rotated Shade
Bungee_Color/BungeeColor-Regular_svg.ttf:Family              Bungee Color

With metapackages
djr-bungee-desktop-fonts-all
djr-bungee-desktop-standard-fonts-all
djr-bungee-desktop-layers-fonts-all
djr-bungee-desktop-layers-rotated-fonts-all
and 
djr-bungee-fonts-all

More information on color fonts is available at https://color.typekit.com/
It seems that at least the desktop fonts could be compiled with fontmake - https://github.com/googlefonts/fontmake though at present, only the compiled versions are packaged. This also seems relevant for Hack fonts https://bugzilla.redhat.com/show_bug.cgi?id=1258542

Comment 11 Benson Muite 2022-04-24 13:35:14 UTC
Removed desktop as per the guidelines, it is the standard package:
Bungee/Bungee-Hairline.otf:Family:              Bungee Hairline
Bungee/Bungee-Inline.otf:Family:              Bungee Inline
Bungee/Bungee-Outline.otf:Family:              Bungee Outline
Bungee/Bungee-Regular.otf:Family:              Bungee Regular
Bungee/Bungee-Shade.otf:Family:              Bungee Shade
BungeeLayers/BungeeLayers-Inline.otf:Family:              Bungee Layers Inline
BungeeLayers/BungeeLayers-Outline.otf:Family:              Bungee Layers Outline
BungeeLayers/BungeeLayers-Regular.otf:Family:              Bungee Layers Regular
BungeeLayers/BungeeLayers-Shade.otf:Family:              Bungee Layers Shade
BungeeLayersRotated/BungeeLayersRotated-Inline.otf:Family:              Bungee Layers Rotated Inline
BungeeLayersRotated/BungeeLayersRotated-Outline.otf:Family:              Bungee Layers Rotated Outline
BungeeLayersRotated/BungeeLayersRotated-Regular.otf:Family:              Bungee Layers Rotated Regular
BungeeLayersRotated/BungeeLayersRotated-Shade.otf:Family:              Bungee Layers Rotated Shade
Bungee_Color/BungeeColor-Regular_svg.ttf:Family              Bungee Color

With metapackages
djr-bungee-desktop-fonts-all
djr-bungee-standard-fonts-all
djr-bungee-layers-fonts-all
djr-bungee-layers-rotated-fonts-all
and 
djr-bungee-fonts-all

Comment 12 Benson Muite 2022-04-24 19:15:26 UTC
OTF files can be generated from sources using https://github.com/googlefonts/ufo2ft but this is not yet packaged, and it seems to be developing relatively quickly. Related upstream discussion at https://github.com/djrrb/Bungee/issues/76

Comment 13 Benson Muite 2022-04-24 19:27:47 UTC
ufo2ft was packaged previously https://src.fedoraproject.org/rpms/python-ufo2ft/blob/f28/f/python-ufo2ft.spec

Comment 14 Parag AN(पराग) 2022-04-26 02:52:27 UTC
Maybe try un-retiring python-ufo2ft package. See https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming

and then submit initial work of this package that is SPEC and SRPM.

Comment 15 Benson Muite 2022-05-03 17:57:15 UTC
Unofficial review in progress for fbf-ani-fonts - Script like Bengali Font
https://bugzilla.redhat.com/show_bug.cgi?id=2051879

Comment 17 Benson Muite 2022-05-28 19:03:09 UTC
Started process of unretiring ufo2ft https://bugzilla.redhat.com/show_bug.cgi?id=2091310

Comment 18 Benson Muite 2022-05-31 15:44:10 UTC
Another package am working on, though unrelated to fonts https://bugzilla.redhat.com/show_bug.cgi?id=2091389

Comment 19 Benson Muite 2022-06-02 07:05:00 UTC
Unofficial review of python-google-cloud-pubsub
https://bugzilla.redhat.com/show_bug.cgi?id=2092637

Comment 20 Benson Muite 2022-06-05 07:45:18 UTC
Unofficial review of sfnt2woff-zopfli 
https://bugzilla.redhat.com/show_bug.cgi?id=2091282

Comment 21 Benson Muite 2022-06-05 08:24:45 UTC
Unofficial review of bfs
https://bugzilla.redhat.com/show_bug.cgi?id=2087264

Comment 22 Benson Muite 2022-06-08 05:26:15 UTC
Unofficial review of libmd:
https://bugzilla.redhat.com/show_bug.cgi?id=2094582

Unofficial review of libaiff:
https://bugzilla.redhat.com/show_bug.cgi?id=2094422

Comment 23 Benson Muite 2022-06-10 14:38:43 UTC
Unofficial review of daniel-wikholm-segment16-fonts :
https://bugzilla.redhat.com/show_bug.cgi?id=2095732

Comment 24 Benson Muite 2022-06-13 14:45:37 UTC
Unofficial review of sfsexp:
https://bugzilla.redhat.com/show_bug.cgi?id=2095717

Comment 25 Benson Muite 2022-06-14 17:51:36 UTC
Unofficial review of simdjson:
https://bugzilla.redhat.com/show_bug.cgi?id=2096621

Unofficial review of giza:
https://bugzilla.redhat.com/show_bug.cgi?id=1187030

Comment 26 Benson Muite 2022-06-20 15:06:36 UTC
Unofficial review of Gearhead II:
https://bugzilla.redhat.com/show_bug.cgi?id=2098373

Unofficial review of golang-github-derekparker-trie:
https://bugzilla.redhat.com/show_bug.cgi?id=2098379

Comment 27 Benson Muite 2022-07-03 18:37:10 UTC
Unofficial review of starkbank-ecdsa:
https://bugzilla.redhat.com/show_bug.cgi?id=2101458

Comment 28 Benson Muite 2022-07-09 06:05:49 UTC
Unofficial review of python-pynvim:
https://bugzilla.redhat.com/show_bug.cgi?id=2105127

Comment 29 Benson Muite 2022-07-11 17:58:13 UTC
Unofficial review of rust-cap:
https://bugzilla.redhat.com/show_bug.cgi?id=2105887

Comment 30 Benson Muite 2022-07-16 12:41:23 UTC
Unofficial review of python-railroad-diagrams:
https://bugzilla.redhat.com/show_bug.cgi?id=2107355

Comment 31 Benson Muite 2022-07-16 14:21:24 UTC
Unofficial review of blueprint-compiler:
https://bugzilla.redhat.com/show_bug.cgi?id=2106919

Comment 32 Benson Muite 2022-07-18 07:39:17 UTC
Unofficial review of vim-mediawiki:
https://bugzilla.redhat.com/show_bug.cgi?id=2107962

Comment 33 Benson Muite 2022-07-20 17:33:20 UTC
Unofficial review of python-pyvat:
https://bugzilla.redhat.com/show_bug.cgi?id=2109069

Comment 34 Benson Muite 2022-07-25 09:00:36 UTC
Unofficial review of libodiosacd:
https://bugzilla.redhat.com/show_bug.cgi?id=2110108

Comment 35 Benson Muite 2022-08-01 05:50:19 UTC
Unofficial review of ugrep:
https://bugzilla.redhat.com/show_bug.cgi?id=2109340

Unofficial review of v:
https://bugzilla.redhat.com/show_bug.cgi?id=2042701

Packaging PT Astra serif font:
https://bugzilla.redhat.com/show_bug.cgi?id=2112636

Packaging PT Astra sans font:
https://bugzilla.redhat.com/show_bug.cgi?id=2112639

Comment 36 Benson Muite 2022-08-02 11:20:19 UTC
Unofficial review basez:
https://bugzilla.redhat.com/show_bug.cgi?id=2113075

Comment 37 Parag AN(पराग) 2022-08-02 12:15:59 UTC
Sorry I just remembered this bug and saw I missed above comments about your unofficial reviews.
I am surprised being assignee of this bug I did not received any update from this bug since 28th May 2022.

Anyways, I have sponsored you now :)

Comment 38 Benson Muite 2022-08-07 11:50:23 UTC
Many thanks for sponsorship. Did not want to clutter inboxes.

Comment 39 Package Review 2023-08-08 00:45:28 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 40 Parag AN(पराग) 2023-08-08 01:43:18 UTC
(In reply to Package Review from comment #39)
> This is an automatic check from review-stats script.
> 
> This review request ticket hasn't been updated for some time, but it seems
> that the review is still being working out by you. If this is right, please
> respond to this comment clearing the NEEDINFO flag and try to reach out the
> submitter to proceed with the review.
> 
> If you're not interested in reviewing this ticket anymore, please clear the
> fedora-review flag and reset the assignee, so that a new reviewer can take
> this ticket.
> 
> Without any reply, this request will shortly be resetted.

Hey you seems really funny. I know you are a bot but you should needinfo both the parties here.

Comment 41 Parag AN(पराग) 2023-08-08 01:45:39 UTC
(In reply to Benson Muite from comment #0)
> Spec URL:
> https://copr-dist-git.fedorainfracloud.org/cgit/fed500/bungee-fonts/bungee-
> fonts.git/tree/bungee-fonts.spec?h=f34
> 
> COPR URL: https://copr.fedorainfracloud.org/coprs/fed500/bungee-fonts/
> 
> Description: OTF fonts from https://github.com/djrrb/Bungee
> These fonts are helpful for making Fedora Magazine images
> https://docs.fedoraproject.org/en-US/fedora-magazine/creating-an-image/
> #_fonts , but are not yet packaged for Fedora.
> 
> SPEC file draws from 
> https://src.fedoraproject.org/rpms/fira-code-fonts/tree/rawhide
> https://src.fedoraproject.org/rpms/vernnobile-oswald-fonts/tree/rawhide
> https://pagure.io/fontpackages/blob/master
> 
> Fedora Account System Username: fed500

Do submit this package again as I can't access your copr repo.


Note You need to log in before you can comment on or make changes to this bug.