Spec URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/fedora-rawhide-x86_64/08982300-fooyin/fooyin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/fedora-rawhide-x86_64/08982300-fooyin/fooyin-0.8.1-1.fc43.src.rpm Description: fooyin is a music player built around customization. It provides a variety of widgets to help you manage and play your local collection. Fedora Account System Username: ypsvlq Copr build: https://copr.fedorainfracloud.org/coprs/ypsvlq/fooyin/build/8982300/ This is my first package, so I will need a sponsor.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8982493 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363087-fooyin/fedora-rawhide-x86_64/08982493-fooyin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/fedora-rawhide-x86_64/08982914-fooyin/fooyin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/fedora-rawhide-x86_64/08982914-fooyin/fooyin-0.8.1-1.fc43.src.rpm (directory ownership fixes)
Created attachment 2087899 [details] The .spec file difference from Copr build 8982493 to 8982970
Copr build: https://copr.fedorainfracloud.org/coprs/build/8982970 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363087-fooyin/fedora-rawhide-x86_64/08982970-fooyin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09011586/fooyin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09011586/fooyin-0.8.1-1.src.rpm (upstream patch removing application/octet-stream from mime types)
Spec URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09027564/fooyin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09027564/fooyin-0.8.1-1.src.rpm (enable ALSA, build devel package)
Created attachment 2089604 [details] The .spec file difference from Copr build 8982970 to 9027587
Copr build: https://copr.fedorainfracloud.org/coprs/build/9027587 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363087-fooyin/fedora-rawhide-x86_64/09027587-fooyin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi! I'm new to Fedora packaging and looking to learn more about the process before getting sponsorship to bring my own packages into Fedora. I took a look at this one as a non-binding review to help. I'm not able to sponsor packages yet, but hopefully this is helpful. I went through the checklist. There aren't too many things that stood out to me. The main highlights: 1. Patch0 and Patch1 should have a justification provided in a comment to explain why they're being brought in from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. 2. There is no documentation installed although an empty docdir does get created. I took a look through the upstream repo and couldn't find any manpages but this should be verified just in case. fooyin.x86_64: W: no-manual-page-for-binary fooyin fooyin-devel.x86_64: W: no-documentation 3. Is it accurate that the package has no runtime deps other than the icon theme? I cross-referenced the BuildRequires with the build instructions from upstream but wasn't able to test all features of the app to validate. [?]: Final provides and requires are sane (see attachments). I'll paste the full review output in the next comment. Hopefully this helps!
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "BSD 3-Clause License". 193 files have unknown license. Detailed output of licensecheck in /home/user/package- reviews/fooyin/fooyin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3108 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1392640 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
(In reply to Alex Haydock from comment #9) > 1. Patch0 and Patch1 should have a justification provided in a comment to > explain why they're being brought in from upstream. Fair, I didn't comment them as the links go to directly to upstream commits, but it would be clearer. > 2. There is no documentation installed although an empty docdir does get > created. I took a look through the upstream repo and couldn't find any > manpages but this should be verified just in case. > > fooyin.x86_64: W: no-manual-page-for-binary fooyin > fooyin-devel.x86_64: W: no-documentation The README is installed as documentation (and packaged), there is no man page or devel-specific documentation though. > 3. Is it accurate that the package has no runtime deps other than the icon > theme? I cross-referenced the BuildRequires with the build instructions from > upstream but wasn't able to test all features of the app to validate. RPM infers the library dependencies (see the Requires in the review template). hicolor-icon-theme owns /usr/share/icons/hicolor and is required explicitly per https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership > I'll paste the full review output in the next comment. Hopefully this helps! Thanks for the review!
Just chime in for a suggestion. It seems like upstream employs a testing suite, and it would be a nice addition to enable it during the build. Include GTest as a BuildRequires and adding `-DBUILD_TESTING` flag should suffice.
The test suite currently does not pass, required fixes have been sent upstream: https://github.com/fooyin/fooyin/pull/524
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "BSD 3-Clause License". 193 files have unknown license. Detailed output of licensecheck in /home/fedora- packaging/reviews/fooyin/2363087-fooyin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3108 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1392640 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fooyin-0.8.1-1.fc43.x86_64.rpm fooyin-devel-0.8.1-1.fc43.x86_64.rpm fooyin-0.8.1-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpn42szxhv')] checks: 32, packages: 3 fooyin-devel.x86_64: W: only-non-binary-in-usr-lib fooyin.x86_64: W: no-manual-page-for-binary fooyin fooyin-devel.x86_64: W: no-documentation fooyin.x86_64: E: files-duplicated-waste 133315 fooyin.x86_64: W: files-duplicate /usr/share/fooyin/translations/fooyin_en_GB.qm /usr/share/fooyin/translations/fooyin_en.qm 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 15 filtered, 1 badness; has taken 2.5 s Rpmlint (debuginfo) ------------------- Checking: fooyin-debuginfo-0.8.1-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbmlq2_6f')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 46 filtered, 0 badness; has taken 7.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 fooyin-devel.x86_64: W: only-non-binary-in-usr-lib fooyin.x86_64: W: no-manual-page-for-binary fooyin fooyin-devel.x86_64: W: no-documentation fooyin.x86_64: E: files-duplicated-waste 133315 fooyin.x86_64: W: files-duplicate /usr/share/fooyin/translations/fooyin_en_GB.qm /usr/share/fooyin/translations/fooyin_en.qm 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 74 filtered, 1 badness; has taken 11.0 s Unversioned so-files -------------------- fooyin: /usr/lib64/fooyin/plugins/fyplugin_alsa.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_fileops.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_filters.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_gmeinput.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_libarchive.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_mpris.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_openmpt.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_pipewire.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_rawaudio.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_rgscanner.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_scrobbler.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_sndfile.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_tageditor.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_vumeter.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_wavebar.so Source checksums ---------------- https://github.com/fooyin/fooyin/archive/v0.8.1/fooyin-0.8.1.tar.gz : CHECKSUM(SHA256) this package : e702389488e19c4c48b1b62bf1b2adf263b818138e3b232a39259057cbcec9c2 CHECKSUM(SHA256) upstream package : e702389488e19c4c48b1b62bf1b2adf263b818138e3b232a39259057cbcec9c2 Requires -------- fooyin (rpmlib, GLIBC filtered): hicolor-icon-theme libQt6Concurrent.so.6()(64bit) libQt6Concurrent.so.6(Qt_6)(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.9)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Sql.so.6()(64bit) libQt6Sql.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libarchive.so.13()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libavcodec.so.61()(64bit) libavcodec.so.61(LIBAVCODEC_61)(64bit) libavformat.so.61()(64bit) libavformat.so.61(LIBAVFORMAT_61)(64bit) libavutil.so.59()(64bit) libavutil.so.59(LIBAVUTIL_59)(64bit) libc.so.6()(64bit) libebur128.so.1()(64bit) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgme.so.0()(64bit) libicui18n.so.76()(64bit) libkdsingleapplication-qt6.so.1.1()(64bit) libm.so.6()(64bit) libopenmpt.so.0()(64bit) libpipewire-0.3.so.0()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libswresample.so.5()(64bit) libswresample.so.5(LIBSWRESAMPLE_5)(64bit) libtag.so.1()(64bit) rtld(GNU_HASH) fooyin-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) fooyin(x86-64) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) Provides -------- fooyin: application() application(org.fooyin.fooyin.desktop) fooyin fooyin(x86-64) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) metainfo() metainfo(org.fooyin.fooyin.metainfo.xml) mimehandler(application/ogg) mimehandler(application/vnd.apple.mpegurl) mimehandler(application/vnd.ms-asf) mimehandler(application/x-cue) mimehandler(application/x-ogg) mimehandler(application/x-ogm-audio) mimehandler(audio/aac) mimehandler(audio/aiff) mimehandler(audio/basic) mimehandler(audio/flac) mimehandler(audio/mp4) mimehandler(audio/mpeg) mimehandler(audio/mpegurl) mimehandler(audio/ogg) mimehandler(audio/vnd.rn-realaudio) mimehandler(audio/vorbis) mimehandler(audio/wav) mimehandler(audio/x-ape) mimehandler(audio/x-ay) mimehandler(audio/x-flac) mimehandler(audio/x-gbs) mimehandler(audio/x-hes) mimehandler(audio/x-kss) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-ms-wma) mimehandler(audio/x-musepack) mimehandler(audio/x-nsf) mimehandler(audio/x-nsfe) mimehandler(audio/x-oggflac) mimehandler(audio/x-sap) mimehandler(audio/x-spc) mimehandler(audio/x-speex) mimehandler(audio/x-sph) mimehandler(audio/x-voc) mimehandler(audio/x-vorbis) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-w64) mimehandler(audio/x-wav) mimehandler(audio/x-wavex) mimehandler(audio/x-wavpack) mimehandler(audio/x-wve) mimehandler(video/x-ms-asf) mimehandler(x-content/audio-player) fooyin-devel: cmake(Fooyin) cmake(fooyin) fooyin-devel fooyin-devel(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2363087 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: PHP, R, Perl, Java, Python, SugarActivity, fonts, Ocaml, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) sonames should not be globbed https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries b) translation files should be listed using %find_lang %{name} --with-qt rather than using %[_datadir}/fooyin https://docs.fedoraproject.org/en-US/packaging-guidelines/#handling_locale_files
Spec URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09065455/fooyin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09065455/fooyin-0.8.1-1.src.rpm
Created attachment 2090856 [details] The .spec file difference from Copr build 9027587 to 9065471
Copr build: https://copr.fedorainfracloud.org/coprs/build/9065471 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363087-fooyin/fedora-rawhide-x86_64/09065471-fooyin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09076355/fooyin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09076355/fooyin-0.8.1-1.src.rpm
Created attachment 2091336 [details] The .spec file difference from Copr build 9065471 to 9076359
Copr build: https://copr.fedorainfracloud.org/coprs/build/9076359 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363087-fooyin/fedora-rawhide-x86_64/09076359-fooyin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "BSD 3-Clause License". 193 files have unknown license. Detailed output of licensecheck in /home/fedora- packaging/reviews/fooyin/2363087-fooyin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 41971 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1433600 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fooyin-0.8.1-1.fc43.x86_64.rpm fooyin-devel-0.8.1-1.fc43.x86_64.rpm fooyin-0.8.1-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpj1okwlhw')] checks: 32, packages: 3 fooyin-devel.x86_64: W: only-non-binary-in-usr-lib fooyin.x86_64: W: no-manual-page-for-binary fooyin fooyin-devel.x86_64: W: no-documentation fooyin.x86_64: E: files-duplicated-waste 133315 fooyin.x86_64: W: files-duplicate /usr/share/fooyin/translations/fooyin_en_GB.qm /usr/share/fooyin/translations/fooyin_en.qm 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 15 filtered, 1 badness; has taken 2.1 s Rpmlint (debuginfo) ------------------- Checking: fooyin-debuginfo-0.8.1-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpsx91gdm8')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 46 filtered, 0 badness; has taken 6.0 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 fooyin-devel.x86_64: W: only-non-binary-in-usr-lib fooyin.x86_64: W: no-manual-page-for-binary fooyin fooyin-devel.x86_64: W: no-documentation fooyin.x86_64: E: files-duplicated-waste 133315 fooyin.x86_64: W: files-duplicate /usr/share/fooyin/translations/fooyin_en_GB.qm /usr/share/fooyin/translations/fooyin_en.qm 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 74 filtered, 1 badness; has taken 9.2 s Unversioned so-files -------------------- fooyin: /usr/lib64/fooyin/plugins/fyplugin_alsa.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_fileops.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_filters.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_gmeinput.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_libarchive.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_mpris.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_openmpt.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_pipewire.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_rawaudio.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_rgscanner.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_scrobbler.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_sndfile.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_tageditor.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_vumeter.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_wavebar.so Source checksums ---------------- https://github.com/fooyin/fooyin/archive/v0.8.1/fooyin-0.8.1.tar.gz : CHECKSUM(SHA256) this package : e702389488e19c4c48b1b62bf1b2adf263b818138e3b232a39259057cbcec9c2 CHECKSUM(SHA256) upstream package : e702389488e19c4c48b1b62bf1b2adf263b818138e3b232a39259057cbcec9c2 Requires -------- fooyin (rpmlib, GLIBC filtered): hicolor-icon-theme libQt6Concurrent.so.6()(64bit) libQt6Concurrent.so.6(Qt_6)(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.9)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Sql.so.6()(64bit) libQt6Sql.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libarchive.so.13()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libavcodec.so.61()(64bit) libavcodec.so.61(LIBAVCODEC_61)(64bit) libavformat.so.61()(64bit) libavformat.so.61(LIBAVFORMAT_61)(64bit) libavutil.so.59()(64bit) libavutil.so.59(LIBAVUTIL_59)(64bit) libc.so.6()(64bit) libebur128.so.1()(64bit) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgme.so.0()(64bit) libicui18n.so.76()(64bit) libkdsingleapplication-qt6.so.1.1()(64bit) libm.so.6()(64bit) libopenmpt.so.0()(64bit) libpipewire-0.3.so.0()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libswresample.so.5()(64bit) libswresample.so.5(LIBSWRESAMPLE_5)(64bit) libtag.so.1()(64bit) rtld(GNU_HASH) fooyin-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) fooyin(x86-64) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) Provides -------- fooyin: application() application(org.fooyin.fooyin.desktop) fooyin fooyin(x86-64) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) metainfo() metainfo(org.fooyin.fooyin.metainfo.xml) mimehandler(application/ogg) mimehandler(application/vnd.apple.mpegurl) mimehandler(application/vnd.ms-asf) mimehandler(application/x-cue) mimehandler(application/x-ogg) mimehandler(application/x-ogm-audio) mimehandler(audio/aac) mimehandler(audio/aiff) mimehandler(audio/basic) mimehandler(audio/flac) mimehandler(audio/mp4) mimehandler(audio/mpeg) mimehandler(audio/mpegurl) mimehandler(audio/ogg) mimehandler(audio/vnd.rn-realaudio) mimehandler(audio/vorbis) mimehandler(audio/wav) mimehandler(audio/x-ape) mimehandler(audio/x-ay) mimehandler(audio/x-flac) mimehandler(audio/x-gbs) mimehandler(audio/x-hes) mimehandler(audio/x-kss) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-ms-wma) mimehandler(audio/x-musepack) mimehandler(audio/x-nsf) mimehandler(audio/x-nsfe) mimehandler(audio/x-oggflac) mimehandler(audio/x-sap) mimehandler(audio/x-spc) mimehandler(audio/x-speex) mimehandler(audio/x-sph) mimehandler(audio/x-voc) mimehandler(audio/x-vorbis) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-w64) mimehandler(audio/x-wav) mimehandler(audio/x-wavex) mimehandler(audio/x-wavpack) mimehandler(audio/x-wve) mimehandler(video/x-ms-asf) mimehandler(x-content/audio-player) fooyin-devel: cmake(Fooyin) cmake(fooyin) fooyin-devel fooyin-devel(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2363087 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, Ocaml, Java, Haskell, PHP, R, fonts, Perl, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH a) Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=133143214 b) Can tests be built and run? c) May want to add sdl2-compat-devel as a dependency d) Is it worth packaging libvgm: https://github.com/ValleyBell/libvgm it is an optional dependency: https://github.com/fooyin/fooyin/tree/master/3rdparty Does not block the review, but if not, may want to add -DBUILD_LIBVGM=OFF to cmake build flags as it is not currently bundled. e) Upstream has a Fedora build: https://github.com/fooyin/fooyin/blob/master/.github/workflows/build.yml#L40 may want to check if they would be willing to use https://packit.dev as it would simplify maintenance. f) None of the above are blocking for approving the package. b would be nice if possible.
(In reply to Benson Muite from comment #21) > b) Can tests be built and run? Not currently, fixes have been sent upstream, will enable them when possible. https://github.com/fooyin/fooyin/pull/524 > c) May want to add sdl2-compat-devel as a dependency I left it out initially as ALSA+PipeWire seemed complete, no reason not to include it though. > d) Is it worth packaging libvgm: libvgm code is a mix of GPL, various BSD, and in some places no clear license (and doesn't make releases), definitely prevents packaging/bundling it. https://github.com/ValleyBell/libvgm/issues/43 https://github.com/ValleyBell/libvgm/issues/129 > Does not block the review, but if not, may want to add > -DBUILD_LIBVGM=OFF > to cmake build flags as it is not currently bundled. Agreed. > e) Upstream has a Fedora build: > https://github.com/fooyin/fooyin/blob/master/.github/workflows/build.yml#L40 > may want to check if they would be willing to use https://packit.dev as > it would simplify maintenance. I think the main developer is currently busy with other things, but definitely something to look at, thanks. > f) None of the above are blocking for approving the package. b would be nice > if possible. Thanks for the review!
Spec URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09078308/fooyin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09078308/fooyin-0.8.1-1.src.rpm
Created attachment 2091516 [details] The .spec file difference from Copr build 9076359 to 9078309
Copr build: https://copr.fedorainfracloud.org/coprs/build/9078309 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363087-fooyin/fedora-rawhide-x86_64/09078309-fooyin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Tests pass and run with your patch: https://koji.fedoraproject.org/koji/taskinfo?taskID=133246757 please enable them. Consider updating the CMakeLists.txt files to be able to run the tests using ctest.
Spec URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09091844/fooyin.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09091844/fooyin-0.8.1-1.src.rpm
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9091857 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363087-fooyin/fedora-rawhide-x86_64/09091857-fooyin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9091945 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363087-fooyin/fedora-rawhide-x86_64/09091945-fooyin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "BSD 3-Clause License". 193 files have unknown license. Detailed output of licensecheck in /home/fedora- packaging/reviews/fooyin/2363087-fooyin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 41971 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1433600 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fooyin-0.8.1-1.fc43.x86_64.rpm fooyin-devel-0.8.1-1.fc43.x86_64.rpm fooyin-0.8.1-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphwh65vb8')] checks: 32, packages: 3 fooyin-devel.x86_64: W: only-non-binary-in-usr-lib fooyin.x86_64: W: no-manual-page-for-binary fooyin fooyin-devel.x86_64: W: no-documentation fooyin.x86_64: E: files-duplicated-waste 133315 fooyin.x86_64: W: files-duplicate /usr/share/fooyin/translations/fooyin_en_GB.qm /usr/share/fooyin/translations/fooyin_en.qm 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 15 filtered, 1 badness; has taken 2.1 s Rpmlint (debuginfo) ------------------- Checking: fooyin-debuginfo-0.8.1-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpu5ffst15')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 48 filtered, 0 badness; has taken 6.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 fooyin-devel.x86_64: W: only-non-binary-in-usr-lib fooyin.x86_64: W: no-manual-page-for-binary fooyin fooyin-devel.x86_64: W: no-documentation fooyin.x86_64: E: files-duplicated-waste 133315 fooyin.x86_64: W: files-duplicate /usr/share/fooyin/translations/fooyin_en_GB.qm /usr/share/fooyin/translations/fooyin_en.qm 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 77 filtered, 1 badness; has taken 9.4 s Unversioned so-files -------------------- fooyin: /usr/lib64/fooyin/plugins/fyplugin_alsa.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_fileops.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_filters.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_gmeinput.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_libarchive.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_mpris.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_openmpt.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_pipewire.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_rawaudio.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_rgscanner.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_scrobbler.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_sdl.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_sndfile.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_tageditor.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_vumeter.so fooyin: /usr/lib64/fooyin/plugins/fyplugin_wavebar.so Source checksums ---------------- https://github.com/fooyin/fooyin/archive/v0.8.1/fooyin-0.8.1.tar.gz : CHECKSUM(SHA256) this package : e702389488e19c4c48b1b62bf1b2adf263b818138e3b232a39259057cbcec9c2 CHECKSUM(SHA256) upstream package : e702389488e19c4c48b1b62bf1b2adf263b818138e3b232a39259057cbcec9c2 Requires -------- fooyin (rpmlib, GLIBC filtered): hicolor-icon-theme libQt6Concurrent.so.6()(64bit) libQt6Concurrent.so.6(Qt_6)(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.9)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Sql.so.6()(64bit) libQt6Sql.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libSDL2-2.0.so.0()(64bit) libarchive.so.13()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libavcodec.so.61()(64bit) libavcodec.so.61(LIBAVCODEC_61)(64bit) libavformat.so.61()(64bit) libavformat.so.61(LIBAVFORMAT_61)(64bit) libavutil.so.59()(64bit) libavutil.so.59(LIBAVUTIL_59)(64bit) libc.so.6()(64bit) libebur128.so.1()(64bit) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgme.so.0()(64bit) libicui18n.so.76()(64bit) libkdsingleapplication-qt6.so.1.1()(64bit) libm.so.6()(64bit) libopenmpt.so.0()(64bit) libpipewire-0.3.so.0()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libswresample.so.5()(64bit) libswresample.so.5(LIBSWRESAMPLE_5)(64bit) libtag.so.1()(64bit) rtld(GNU_HASH) fooyin-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) fooyin(x86-64) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) Provides -------- fooyin: application() application(org.fooyin.fooyin.desktop) fooyin fooyin(x86-64) libfooyin_core.so.0.0.0()(64bit) libfooyin_gui.so.0.0.0()(64bit) libfooyin_utils.so.0.0.0()(64bit) metainfo() metainfo(org.fooyin.fooyin.metainfo.xml) mimehandler(application/ogg) mimehandler(application/vnd.apple.mpegurl) mimehandler(application/vnd.ms-asf) mimehandler(application/x-cue) mimehandler(application/x-ogg) mimehandler(application/x-ogm-audio) mimehandler(audio/aac) mimehandler(audio/aiff) mimehandler(audio/basic) mimehandler(audio/flac) mimehandler(audio/mp4) mimehandler(audio/mpeg) mimehandler(audio/mpegurl) mimehandler(audio/ogg) mimehandler(audio/vnd.rn-realaudio) mimehandler(audio/vorbis) mimehandler(audio/wav) mimehandler(audio/x-ape) mimehandler(audio/x-ay) mimehandler(audio/x-flac) mimehandler(audio/x-gbs) mimehandler(audio/x-hes) mimehandler(audio/x-kss) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-ms-wma) mimehandler(audio/x-musepack) mimehandler(audio/x-nsf) mimehandler(audio/x-nsfe) mimehandler(audio/x-oggflac) mimehandler(audio/x-sap) mimehandler(audio/x-spc) mimehandler(audio/x-speex) mimehandler(audio/x-sph) mimehandler(audio/x-voc) mimehandler(audio/x-vorbis) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-w64) mimehandler(audio/x-wav) mimehandler(audio/x-wavex) mimehandler(audio/x-wavpack) mimehandler(audio/x-wve) mimehandler(video/x-ms-asf) mimehandler(x-content/audio-player) fooyin-devel: cmake(Fooyin) cmake(fooyin) fooyin-devel fooyin-devel(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2363087 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Ocaml, Python, Perl, R, Java, SugarActivity, fonts, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) One minor nit. Please change %{_libdir}/fooyin/*.so to either %{_libdir}/fooyin/libfooyin*.so or %{_libdir}/fooyin/libfooyin_core.so %{_libdir}/fooyin/libfooyin_gui.so %{_libdir}/fooyin/libfooyin_utils.so to ensure new libraries do not accidentally create conflicts. b) Thanks for using a cleaner way to run the tests. c) Approved. Please fix (a) before import. d) I can sponsor. If you would like me to do that, please do mock reviews of at least three packages and place links to those reviews here. Some options: https://bugzilla.redhat.com/show_bug.cgi?id=2239258 https://bugzilla.redhat.com/show_bug.cgi?id=2366506 https://bugzilla.redhat.com/show_bug.cgi?id=2251509 https://bugzilla.redhat.com/show_bug.cgi?id=2319105 https://bugzilla.redhat.com/show_bug.cgi?id=2306884 https://bugzilla.redhat.com/show_bug.cgi?id=2262694 https://bugzilla.redhat.com/show_bug.cgi?id=2314587 though other packages you find interesting are also fine.
(In reply to Benson Muite from comment #31) > c) Approved. Please fix (a) before import. Thanks, will do! > d) I can sponsor. If you would like me to do that, > please do mock reviews of at least three packages and place > links to those reviews here. Okay, I've reviewed these packages: https://bugzilla.redhat.com/show_bug.cgi?id=2306884 https://bugzilla.redhat.com/show_bug.cgi?id=2314587 https://bugzilla.redhat.com/show_bug.cgi?id=2368438
(and spec file with those adjustments: https://download.copr.fedorainfracloud.org/results/ypsvlq/fooyin/srpm-builds/09104263/fooyin.spec)
You are now a member of packager group and can import your package. You are also welcome to finish the reviews.
FEDORA-2025-b2ad07d67b (fooyin-0.8.1-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b2ad07d67b
FEDORA-2025-b2ad07d67b (fooyin-0.8.1-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.