Spec URL: http://sdz.fedorapeople.org/rpmbuild/python-oauth.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/python-oauth-1.0.1-1.fc11.src.rpm Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1729587 [sebastian@localhost SRPMS]$ rpmlint -vi python-oauth-1.0.1-1.fc11.src.rpm python-oauth.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [sebastian@localhost noarch]$ rpmlint -vi python-oauth-1.0.1-1.fc11.noarch.rpm python-oauth.noarch: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. This is the first requirement in an effort to get TypePad Motion packaged for Fedora.
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1729587 + rpmlint is silent for SRPM and for RPM. + source files match upstream url b2d7609e4852b33d0d33f0bc6ae5cab8fadca014 oauth-1.0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) you can add example directory to %doc for that you need to add following line to %prep rm -f oauth/example/._* ==> This will make sure remove unnecessary files from installing and also to silent rpmlint output. Then, use %doc in spec as %doc oauth/example LICENSE.txt APPROVED.
New Package CVS Request ======================= Package Name: python-oauth Short Description: Library for OAuth version 1.0a Owners: sdz Branches: F-11 F-12 EL-5
cvs done.
If this package is built for all required branches can you close this review?
I'm going to close this and the other finished reviews as NEXTRELEASE. Once typepad-motion gets into cvs, I'll build it and push them all as updates then. Thanks for all the reviews! :)