Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Perms.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Perms-1.0.6-1.fc16.src.rpm Description: The Perms package provides an interface to the Horde permissions system.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Perms.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Perms-1.0.7-1.fc16.src.rpm
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Perms.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Perms-2.0.3-2.fc17.src.rpm
Please fix the license before review... like most other Horde packages, "LGPLv2" and not "LGPLv2+". I did not look at anything in this package except the license but please fix any other common Horde package issues as well if there are any.
Please update to latest version (2.1.0) and fix the License, I will do the review.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Perms.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Perms-2.1.0-1.fc17.src.rpm
Created attachment 716954 [details] phpci.log phpci 2.14.0
Created attachment 716955 [details] review.txt Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785473
No blocker. === APPROVED ===
New Package SCM Request ======================= Package Name: php-horde-Horde-Perms Short Description: Horde permissions system Owners: nb remi Branches: el6 f18 f19 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Mime-2.0.4-2.fc18, php-horde-Horde-Perms-2.1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Perms-2.1.0-1.fc18,php-horde-Horde-Mime-2.0.4-2.fc18
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Perms-2.1.0-1.el6,php-horde-Horde-Data-2.0.3-3.el6,php-horde-Horde-Prefs-2.3.2-2.el6,php-horde-Horde-Mime-2.0.4-2.el6
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6, php-horde-Horde-Icalendar-2.0.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.