Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Db.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Db-1.2.0-1.fc16.src.rpm Description: Horde database/SQL abstraction layer
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Db.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Db-1.2.1-1.fc16.src.rpm
I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package.
Please update to latest version and make any necessary updates before review.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Db.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Db-2.0.1-2.fc17.src.rpm
Created attachment 695525 [details] phpci.log
Created attachment 695526 [details] php-horde-Horde-Db-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785472
[!]: Requires correct, justified where necessary. /usr/bin/env => Fix horde-db-migrate-component shebang (will pull php-cli) from phpci output: Requires: php-ereg Requires: php-pcre Requires: php-spl Requires: php-pdo pgsql, mysql and mysqli are optionnal, probably we need to recommand at least one (I think of mysqli as mysql will be deprecated in php 5.5)
For shebang, see https://github.com/horde/horde/pull/29 (so, as acked by upstream, should be fixed in next version) See Horde_Vfs for a temporary fix.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Db.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Db-2.0.2-1.fc17.src.rpm
--- php-horde-Horde-Db.spec.0 2013-02-09 17:36:24.000000000 +0100 +++ php-horde-Horde-Db.spec 2013-03-20 21:21:07.000000000 +0100 @@ -4,8 +4,8 @@ %global pear_channel pear.horde.org Name: php-horde-Horde-Db -Version: 2.0.1 -Release: 2%{?dist} +Version: 2.0.2 +Release: 1%{?dist} Summary: Horde Database Libraries Group: Development/Libraries @@ -24,6 +24,7 @@ Requires(postun): %{__pear} Requires: php-common >= 5.3.0 Requires: php-channel(%{pear_channel}) +Requires: php-ereg php-pcre php-spl php-pdo Requires: php-pear(%{pear_channel}/Horde_Date) >= 2.0.0 Conflicts: php-pear(%{pear_channel}/Horde_Date) >= 3.0.0 Requires: php-pear(%{pear_channel}/Horde_Exception) >= 2.0.0 @@ -97,6 +98,9 @@ %changelog +* Wed Mar 20 2013 Nick Bebout <nb> - 2.0.2-1 +- Update for review + * Tue Feb 5 2013 Nick Bebout <nb> - 2.0.1-2 - Use php-common instead of php(language), Remove BuildRoot Shebang issue fixed by new upstream version No blocker == APPROVED ==
New Package SCM Request ======================= Package Name: php-horde-Horde-Db Short Description: Horde database/SQL abstraction layer Owners: nb remi Branches: el6 f18 f19 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.el6,php-horde-Horde-LoginTasks-2.0.2-4.el6,php-horde-Horde-Stream-Filter-2.0.1-4.el6,php-horde-Horde-Token-2.0.3-3.el6
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.fc18,php-horde-Horde-Group-2.0.2-1.fc18,php-horde-Horde-LoginTasks-2.0.2-4.fc18,php-horde-Horde-Stream-Filter-2.0.1-4.fc18,php-horde-Horde-Token-2.0.3-3.fc18
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been pushed to the Fedora 18 stable repository.
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository.