Bug 785474 (Horde_Prefs) - Review Request: php-horde-Horde-Prefs - Horde Preferences API
Summary: Review Request: php-horde-Horde-Prefs - Horde Preferences API
Alias: Horde_Prefs
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
Depends On: horde-channel Horde_Translation Horde_Exception Horde_Util Horde_Mime
Blocks: Horde_Core Horde_Itip
TreeView+ depends on / blocked
Reported: 2012-01-29 03:07 UTC by Nick Bebout
Modified: 2013-03-29 21:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-03-29 21:27:14 UTC
Type: ---
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
phpci.log (12.82 KB, text/plain)
2013-03-27 08:18 UTC, Remi Collet
no flags Details
review.txt (8.92 KB, text/plain)
2013-03-27 08:19 UTC, Remi Collet
no flags Details

Description Nick Bebout 2012-01-29 03:07:13 UTC
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Prefs.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Prefs-1.1.7-1.fc16.src.rpm
Description: The Horde_Prefs package provides a common abstracted interface into the various preferences storage mediums. It also includes all of the functions
for retrieving, storing, and checking preference values.

Comment 3 Remi Collet 2013-03-26 13:26:05 UTC
Please update to latest version (2.3.2) and I will quickly do the review

Comment 5 Remi Collet 2013-03-27 08:18:28 UTC
Created attachment 716929 [details]

phpci version 2.14.0.

Comment 6 Remi Collet 2013-03-27 08:19:09 UTC
Created attachment 716930 [details]

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785474

Comment 7 Remi Collet 2013-03-27 08:24:40 UTC
[!]: Requires correct, justified where necessary.

	php-pdo is optional, but probably wanted

From upstream changelog
* [jan] Fix LDAP driver and use Horde_Ldap (Heinz Schweiger <heinz.at>, Request #11697).

	So remove (confirmed by phpci report)

	And add
	Requires: php-pear(%{pear_channel}/Horde_Ldap) >= 2.0.0

See http://bugs.horde.org/ticket/12145

Comment 9 Remi Collet 2013-03-27 09:15:57 UTC
-Requires:       php-ldap
+Requires:       php-pdo
+Requires:       php-pear(%{pear_channel}/Horde_Ldap) >= 2.0.0
+Conflicts:      php-pear(%{pear_channel}/Horde_Ldap) >= 3.0.0

[x]: Requires correct, justified where necessary.

Comment 10 Nick Bebout 2013-03-27 09:23:27 UTC
New Package SCM Request
Package Name: php-horde-Horde-Prefs
Short Description: Horde preferences API
Owners: nb remi
Branches: el6 f18 f19

Comment 11 Gwyn Ciesla 2013-03-27 12:32:57 UTC
Git done (by process-git-requests).

Comment 12 Fedora Update System 2013-03-27 20:36:38 UTC
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6 has been submitted as an update for Fedora EPEL 6.

Comment 13 Fedora Update System 2013-03-27 20:38:13 UTC
php-horde-Horde-Mime-2.0.4-2.fc18, php-horde-Horde-Perms-2.1.0-1.fc18, php-horde-Horde-Prefs-2.3.2-2.fc18 has been submitted as an update for Fedora 18.

Comment 14 Fedora Update System 2013-03-29 21:27:16 UTC
php-horde-Horde-Mime-2.0.4-2.el6, php-horde-Horde-Prefs-2.3.2-2.el6, php-horde-Horde-Data-2.0.3-3.el6, php-horde-Horde-Perms-2.1.0-1.el6, php-horde-Horde-Icalendar-2.0.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.