830848 – sanlock: initscript should create /var/lock/subsys/sanlock

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 830848 - sanlock: initscript should create /var/lock/subsys/sanlock

Summary: sanlock: initscript should create /var/lock/subsys/sanlock

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	sanlock
Sub Component:
Version:	6.4
Hardware:	Unspecified
OS:	Unspecified
Priority:	urgent
Severity:	urgent
Target Milestone:	rc
Target Release:	---
Assignee:	David Teigland
QA Contact:	Haim
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	841991 906027
TreeView+	depends on / blocked

Reported:	2012-06-11 14:13 UTC by Daniel Berrangé
Modified:	2016-04-26 13:34 UTC (History)
CC List:	6 users (show)
Fixed In Version:	sanlock-2.5-1.el6
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2013-02-21 08:52:44 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2013:0530	0	normal	SHIPPED_LIVE	sanlock bug fix and enhancement update	2013-02-21 02:02:17 UTC

Description Daniel Berrangé 2012-06-11 14:13:08 UTC

Description of problem:
The 'killall' initscript that is run when a machine shuts down, iterates over all files in /var/lock/subsys/, taking filenames as a service name. It invokes the stop action on each initscript which a subsys file.

Unfortunately, the sanlock initscript never creates/deletes any /var/lock/subsys/sanlock file, so it is not handled by the killall init script.

Version-Release number of selected component (if applicable):
sanlock-2.3-1.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. /etc/init.d/sanlock start
2. ls /var/lock/subsys/sanlock
3.
  
Actual results:
subsys file not present

Expected results:
subsys file should be present


Additional info:

Comment 2 David Teigland 2012-06-11 15:06:42 UTC

Hi Dan, this seems to work for me, could you check for any wdmd or sanlock errors in /var/log/messages?  This could also be related to all the uid issues we've been going through (sanlock is now back to being root, so that should lessen the problems.)

# modprobe softdog
# service wdmd start
# service sanlock start

# ps ax | grep -E 'sanlock|wdmd'
17771 ?        SLs    0:00 wdmd -G sanlock
17787 ?        SLsl   0:00 sanlock daemon -U sanlock -G sanlock

# ls -l /var/run/sanlock/
total 4
-rw-rw-rw-. 1 root    root    6 Jun 11 10:17 sanlock.pid
srw-rw----. 1 sanlock sanlock 0 Jun 11 10:17 sanlock.sock

# killall sanlock

# ps ax | grep -E 'sanlock|wdmd'
17771 ?        SLs    0:00 wdmd -G sanlock

Comment 3 Daniel Berrangé 2012-06-11 15:21:05 UTC

You are mixing up the 'killall' command in /usr/bin which kills processes based on their argv[0] name, with the /etc/init.d/killall script which stops init services based on the existance of /var/lock/subsys/XXXXXX (where XXXX must be the initscript name ie 'sanlock').

Comment 4 David Teigland 2012-06-11 16:01:06 UTC

Thanks, I've pushed out a fix for both sanlock and wdmd:
http://git.fedorahosted.org/git/?p=sanlock.git;a=commitdiff;h=e25453ccd46d265de1d5ef720e40977786a6fb1b

Comment 5 David Teigland 2012-07-09 21:36:46 UTC


*** This bug has been marked as a duplicate of bug 838654 ***

Comment 6 David Teigland 2012-07-13 15:27:12 UTC

deconsolidating

Comment 9 Leonid Natapov 2012-12-17 15:17:41 UTC

sanlock-2.6-2.el6.x86_64.


[root@cinteg26 ~]# service sanlock start
Starting sanlock:                                          [  OK  ]
[root@cinteg26 ~]# ls -al /var/run/sanlock/
total 12
drwxrwxr-x.  2 sanlock sanlock 4096 Dec 17 17:17 .
drwxr-xr-x. 24 root    root    4096 Dec 17 13:23 ..
-rw-r--r--.  1 sanlock sanlock    6 Dec 17 17:17 sanlock.pid
srw-rw----.  1 sanlock sanlock    0 Dec 17 17:17 sanlock.sock
[root@cinteg26 ~]#

Comment 11 errata-xmlrpc 2013-02-21 08:52:44 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0530.html

Note You need to log in before you can comment on or make changes to this bug.