Bug 1210796

Summary: Windows needs to send complete monitors_config message to client
Product: Red Hat Enterprise Linux 8 Reporter: Sandy Stutsman <sstutsma>
Component: spice-vdagent-winAssignee: Default Assignee for SPICE Bugs <rh-spice-bugs>
Status: CLOSED ERRATA QA Contact: SPICE QE bug list <spice-qe-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: ---CC: astepano, bazulay, bmcclain, cfergeau, dblechte, djasa, gklein, lsurette, pgrunt, rbalakri, Rhev-m-bugs, sherold, spice-qe-bugs, uril, yeylon, ykaul, ylavi
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Windows   
Whiteboard:
Fixed In Version: vdagent-win-3.6-1 Doc Type: Bug Fix
Doc Text:
Previously, Windows did not provide correct position information for multi-monitor in the monitors_config message to the spice client, which caused virtual monitors to change position. In this fix, the spice-vdagent code now uses APIs for managing monitor positions. As a result, monitors stay in the expected position.
 Story Points: ---
Clone Of: 1202419 Environment:
Last Closed: 2016-03-09 14:45:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Spice RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1202419, 1244878, 1244880, 1248189, 1248196, 1265359, 1265360, 1265361, 1265363    
Bug Blocks:    

Description Sandy Stutsman 2015-04-10 14:43:13 UTC 
+++ This bug was initially created as a clone of Bug #1202419 +++

Description of problem:
Currently, Windows does not provide correct position information for multi-monitor in the monitors_config message to the spice client.

Version-Release number of selected component (if applicable):
3.6


How reproducible:
Always

Steps to Reproduce:
1. Bring up a Windows VM with >1 monitor
2. Use the "Screen Resolution" applet to position the monitors
3. Notice that after clicking apply, the monitors are all positioned at the same X position

Actual results:
When using the Windows "Screen Resolution" to position monitors, the monitors are re-positioned at the same X location (0)

Expected results:
The monitor positions should remain at the position set by the user.

Additional info:
The solution required a new IOCTL to the Windows QXL driver that will allow VDAgent to pass updated position information to the driver which can then set it in the monitors_config message.
Comment 1 Sandy Stutsman 2015-07-23 19:05:10 UTC 
Changes to vd_agent are here:
http://cgit.freedesktop.org/spice/win32/vd_agent/commit/?id=6023630562fd129433aef1eaddcf6fbee3f03e50
Comment 2 David Jaša 2015-08-14 12:21:37 UTC 
qa_ack+ as per bug 1202419 comment 4.
Comment 4 Uri Lublin 2015-09-24 21:21:13 UTC 
Requires a recent enough qxl-win driver ( >= 0.1-24)
Comment 6 Andrei Stepanov 2016-02-08 16:17:16 UTC 
Tested with : Win7 64 + RHEV-toolsSetup_3.6_4.iso + virt-viewer-2.0-6.el7.x86_64 + virt-viewer-2.0-13.el6.x86_64
Comment 7 Dayle Parker 2016-02-22 00:58:03 UTC 
If this bug requires doc text for errata release, please provide draft text in the doc text field in the following format:

 Cause:
 Consequence:
 Fix:
 Result:

The documentation team will review, edit, and approve the text.
If this bug does not require doc text, please set the 'requires_doc_text' flag to -.
Comment 9 errata-xmlrpc 2016-03-09 14:45:07 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0383.html