Bug 2231928
| Summary: | Review Request: golang-modernc-ccgo-3 - ccgo is a C compiler targeting Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-10-03 20:09:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2231392, 2231393, 2231451, 2233178, 2233179, 2233180, 2233181, 2233182, 2233184, 2233185, 2233187, 2233188 | ||
| Bug Blocks: | 2231930, 2231933 | ||
|
Description
W. Michael Petullo
2023-08-14 17:22:55 UTC
- Bump to 3.6.15 # https://gitlab.com/cznic/ccgo %global goipath modernc.org/ccgo/v3 %global forgeurl https://gitlab.com/cznic/ccgo Version: 3.16.15 %global tag v%{version} - You need to assess the LICENSE of the testdata in https://gitlab.com/cznic/ccgo/-/tree/v3.16.15/v3/lib/testdata and add them to the License: field. And add a comment with the breakdown - you need v4 to package v3: DEBUG util.py:442: No matching package to install: 'golang(modernc.org/ccgo/v4/lib)' and you need v3 to package v4, you need to bootstrap one of these package, probably make a bootstrap on v3, not building the binary and removing main.go in the bootstrap. Spec URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-3.spec SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-3-3.16.14-1.fc38.src.rpm - Update to 3.6.15 - Bootstrap to resolve new circular dependency - Breakdown license of tests This new version now depends on: https://bugzilla.redhat.com/show_bug.cgi?id=2233178 https://bugzilla.redhat.com/show_bug.cgi?id=2233179 https://bugzilla.redhat.com/show_bug.cgi?id=2233180 https://bugzilla.redhat.com/show_bug.cgi?id=2233181 https://bugzilla.redhat.com/show_bug.cgi?id=2233182 https://bugzilla.redhat.com/show_bug.cgi?id=2233184 https://bugzilla.redhat.com/show_bug.cgi?id=2233185 https://bugzilla.redhat.com/show_bug.cgi?id=2233187 https://bugzilla.redhat.com/show_bug.cgi?id=2233188 This shouldn't be here outside of the bootstrap when you're building the binary
%global debug_package %{nil}
Don't fetch de
%build
%if %{without bootstrap}
%gobuild -o %{gobuilddir}/bin/ccgo %{goipath}
%endif
%files
%license LICENSE
%doc AUTHORS CONTRIBUTORS README.md
%if %{without bootstrap}
%{_bindir}/ccgo
%endif
->
%if %{without bootstrap}
%build
%gobuild -o %{gobuilddir}/bin/ccgo %{goipath}
%endif
%if %{without bootstrap}
%files
%license LICENSE
%doc AUTHORS CONTRIBUTORS README.md
%{_bindir}/ccgo
%endif
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-3.spec SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-3-3.16.15-1.fc39~bootstrap.src.rpm - Fix debug_package. (Did I understand you right? - Widen use of %if %{without bootstrap} What does "Don't fetch de" mean? Thank you! - License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines Package approved. Please: - add commit rights to go-sig after requesting the repo - add the package to Koschei in the go-sig group on all branches you are building - add the package to release-monitoring.org even if it does not release version The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-ccgo-3 |