Bug 785451 (Horde_Token)
| Summary: | Review Request: php-horde-Horde-Token - Horde Token API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Bebout <nb> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, notting, package-review, shawn |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-03-27 20:29:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 785424, 785432, 785436, 785438, 785439 | ||
| Bug Blocks: | 785463, 908329 | ||
|
Description
Nick Bebout
2012-01-29 01:37:42 UTC
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-1.1.7-1.fc16.src.rpm I will review this package After a quick review: [MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml [MUST] Fix file-not-in-%lang rpmlint warnings [SHOULD] %check is present and all tests pass [SHOULD] Localized php.ini not necessary (see https://bugzilla.redhat.com/show_bug.cgi?id=785471#c5) Please update to 2.0.1 Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-2.0.3-2.fc17.src.rpm [!]: License field in the package spec file matches the actual license.
LGPLv2 (not LGPLv2+)
[!]: Package installs properly.
Note: Installation errors (see attachment)
Wait for dependencies before import in repository
Please fix the License, everything else seems OK.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Token-2.0.3-3.fc17.src.rpm License fixed No blocker === APPROVED === New Package SCM Request ======================= Package Name: php-horde-Horde-Token Short Description: A common abstracted interface into the various token generation mediums Owners: nb remi Branches: el6 f18 f19 InitialCC: Git done (by process-git-requests). php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.el6,php-horde-Horde-LoginTasks-2.0.2-4.el6,php-horde-Horde-Stream-Filter-2.0.1-4.el6,php-horde-Horde-Token-2.0.3-3.el6 php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.fc18,php-horde-Horde-Group-2.0.2-1.fc18,php-horde-Horde-LoginTasks-2.0.2-4.fc18,php-horde-Horde-Stream-Filter-2.0.1-4.fc18,php-horde-Horde-Token-2.0.3-3.fc18 php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 testing repository. php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been pushed to the Fedora 18 stable repository. php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository. |