Bug 1263917
| Summary: | implement the new job page design | ||
|---|---|---|---|
| Product: | [Retired] Beaker | Reporter: | Dan Callaghan <dcallagh> |
| Component: | general | Assignee: | Dan Callaghan <dcallagh> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | tools-bugs <tools-bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 21 | CC: | dcallagh, dowang, mjia, rjoost |
| Target Milestone: | 23.0 | Keywords: | FutureFeature, Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-07 23:11:40 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 646416, 853351, 894137, 967481, 995009, 1064738, 1122682, 1169838, 1305951 | ||
|
Description
Dan Callaghan
2015-09-17 05:39:13 UTC
New HTTP APIs: http://gerrit.beaker-project.org/4406 New job page implementation: http://gerrit.beaker-project.org/4407 There is still one big missing piece of functionality: reviews (ack/nak/comments). The team has discussed this already to some length but we are still not sure what is the best way forwards, in terms of modelling the new review system and what features it should have and how the UI should behave. The current design proposal kind of handwaves past that, but it will need some more attention, perhaps in a separate BZ. The HTTP APIs on the server side of things are merged now, which should make it easier to work on some other related patches. The actual job page UI itself still needs some decisions about the model and UI for reviewing (ack/nak/comments). I noticed in my devel environment that the system page was giving a 500 if a hardware scan was in progress. It was caused by a circular reference in JSON for system when a hardware scan recipe was running (system -> recipe -> system) accidentally introduced by the job API patch. Fix is here: http://gerrit.beaker-project.org/4441 After some discussions on the mailing list [1] we have settled on an approach for the ack/nak/commenting problem. Recipe set comments will be separated into a fully-fledged commenting system. For this bug it will support recipe set comments only but they will be expanded to recipes/tasks in subsequent patches. "Nak" will become "waived", "ack" will be the default. We will have a new optional mechanism for users to track whether they have reviewed a given recipe or not, inspired by Gerrit's reviewed checkboxes. So now, with the original patch implementing the whole new UI: http://gerrit.beaker-project.org/4407 plus some extra supporting patches: http://gerrit.beaker-project.org/4480 extract recipe set comments into a separate table http://gerrit.beaker-project.org/4481 support for tracking per-user recipe reviewed state http://gerrit.beaker-project.org/4482 track per-user recipe reviewed state http://gerrit.beaker-project.org/4486 job page: add UI for commenting on recipe sets this is ready to go. [1] http://thread.gmane.org/gmane.comp.systems.beaker.devel/1302 This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions The results-reporting-improvements-take3 branch has been merged to develop. *** Bug 1013445 has been marked as a duplicate of this bug. *** I'm assuming this was meant to go to VERIFIED not MODIFIED.. Beaker 23.0 has been released. This comment was flagged a spam, view the edit history to see the original text if required. |