Bug 524983

Greg, is this a duplicate of bz#521609 or at least the same fix will be required?

Created attachment 405142 [details]
daemon mode test implementation

This patch is an implementation that explores use of cgi communication with a separate server deamon process used to carry out commands.

*** Bug 641150 has been marked as a duplicate of this bug. ***

*** Bug 690363 has been marked as a duplicate of this bug. ***

*** Bug 692775 has been marked as a duplicate of this bug. ***

*** Bug 692576 has been marked as a duplicate of this bug. ***

Created attachment 491758 [details]
network test output - both client and server have v7-1.3.19

Created attachment 491759 [details]
console messages on v7 network test

Created attachment 491760 [details]
network test console messages running with v7 server selinux disabled.

------- Comment From hienn.com 2011-04-13 13:26 EDT-------
Can you post the command to apply the patch?

I got errors when trying to apply it:
[root@eagle3 v7]# pwd
/usr/share/v7/lib/v7
[root@eagle3 v7]# patch -p2 < hardwaretest.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: hardwaretest.py
|===================================================================
|--- hardwaretest.py    (revision 474)
|+++ hardwaretest.py    (working copy)
--------------------------
File to patch: hardwaretest.py
patching file hardwaretest.py
Hunk #1 FAILED at 43.
Hunk #2 FAILED at 190.
Hunk #3 FAILED at 416.
Hunk #4 FAILED at 429.
Hunk #5 FAILED at 1040.
5 out of 5 hunks FAILED -- saving rejects to file hardwaretest.py.rej

[root@eagle3 v7]# cat hardwaretest.py.rej
--- /dev/null
+++ /dev/null
@@ -43,7 +43,7 @@
from v7.command import Command, V7CommandException
from v7.resultsengine import ResultsEngine
from v7.redhatrelease import RedHatRelease
-
+from v7.daemon import V7Daemon

class HardwareTestHarness(Controller):

@@ -190,10 +190,8 @@
command = self.options.command
if command == "print":
self.doPrint(format="html")
-        elif (command == 'run'):
+        elif (command == 'run' or command == 'server'):
result = self.addTask()
-        elif command == "status":
-            self.doWebStatus()
else:
print "Error: unknown/unsupported command %s" % command
return False
@@ -416,7 +414,8 @@
subcommand = "start"

if subcommand == "daemon":
-            return self.doDaemon()
+            daemon = V7Daemon(self.environment)
+            return daemon.run()

planner = Planner(self.options, virtualization=None)
@@ -429,53 +428,33 @@
if rv != 0:
result = rv
return result
-
-    def doDaemon(self):
-        while True:
-            if self.Debugging != Constants.off:
-                print "checking for tasks"
-            try:
-                taskFile = open(self.environment.getTaskFilePath())
-                for line in taskFile.readlines():
-                    if not line:
-                        break
-                    try:
-                        print "\"" + line.strip() + "\""
-                        if line.strip() == "shutdown":
-                            print "v7 daemon shutdown"
-                            # delete the lines from the file
-                            open(self.environment.getTaskFilePath(), "w").close()
-                            return 0
-                        # otherwise
-                        # only run v7 - nothing else
-                        if line.split()[0] == "v7" and ";" not in line:
-                            print "Running: " + line
-                            task = Command(line)
-                            task.echo()
-                        else:
-                            print "unsupported command: " + line
-                    except V7CommandException, e:
-                        print "Error: " + e.message
-                taskFile.close()
-                # delete the lines from the file
-                open(self.environment.getTaskFilePath(), "w").close()
-                time.sleep(10)
-            except IOError, e:
-                print e/v7/results.xml
-                return False

def addTask(self):
print "<pre>"
-        command = "v7 " + self.webOptions["command"] + " "
+        command = "v7 " + self.webOptions["command"] + " " + self.webOptions["subcommand"] + " "
for option in self.webOptions.keys():
-            if option != "command" and self.webOptions[option]:
+            if "command" not in option and self.webOptions[option]:
command += "--" + option + " " + self.webOptions[option] + " "
command += "\n"
print "Adding Task: " + command
sys.stdout.flush()
-        taskFile = open(self.environment.getTaskFilePath(), "a")
-        taskFile.write(command)
-        taskFile.close()
+        taskInFile = os.open(self.environment.getTaskFilePath() + ".in", os.O_WRONLY)
+        print "opened task file"
+        sys.stdout.flush()
+        os.write(taskInFile, command)
+        os.write(taskInFile, "\n")
+        os.close(taskInFile)
+        print "Reading Results"
+        taskOutFile = open(self.environment.getTaskFilePath()+".out", "r")
+        while True:
+            line = taskOutFile.readline()
+            if line:
+                print line
+            else:
+                break
+        taskOutFile.close()
+        print "done"
+        sys.stdout.flush()
print "</pre>"

def doWebStatus(self):
@@ -1040,8 +1019,8 @@
print "Warning: unknown device: %s " % key
# create one from scratch
device = HalDevice(dict())
-                if self.options.udi:
-                    device.setUDI(self.options.udi)
+                if self.options.udi and len(self.options.udi) > 0:
+                    device.setUDI(self.options.udi[0])

test.setDevice(device)
if self.options.device:
[root@eagle3 v7]#

Created attachment 492385 [details]
network test patch adding warning about selinux on server start

------- Comment From lxie.com 2011-04-16 00:05 EDT-------
(In reply to comment #17)
> Created an attachment (id=60829) [details]
> daemon mode test implementation
>
>
> ------- Comment on attachment From gnichols 2010-04-07 21:02:11
> EDT-------
>
>
> This patch is an implementation that explores use of cgi communication with a
> separate server deamon process used to carry out commands.

RedHat,

Dose this patch have a fix for this bug? are you expecting IBM to test it? which build should this patch be applied to v7-1.1-19 or later build?

------- Comment From lxie.com 2011-04-20 16:29 EDT-------
(In reply to comment #20)
> (In reply to comment #17)
> > Created an attachment (id=60829) [details] [details]
> > daemon mode test implementation
> >
> >
> > ------- Comment on attachment From gnichols 2010-04-07 21:02:11
> > EDT-------
> >
> >
> > This patch is an implementation that explores use of cgi communication with a
> > separate server deamon process used to carry out commands.
>
> RedHat,
>
> Dose this patch have a fix for this bug? are you expecting IBM to test it?
> which build should this patch be applied to v7-1.1-19 or later build?

oops,  the severity was accidentally changed to low, needs to be block

*** Bug 624493 has been marked as a duplicate of this bug. ***

------- Comment From hienn.com 2011-04-29 17:18 EDT-------
v7-1.3-35 : passed the network tests on a Power7 blade with a 2-port HEA card.

Will try on a Power7 standalone system.

------- Comment From lxie.com 2011-05-11 14:09 EDT-------
(In reply to comment #23)
> v7-1.3-35 : passed the network tests on a Power7 blade with a 2-port HEA card.
>
> Will try on a Power7 standalone system.

Hien,

When you get a chance, please test the latest HTS (-43) build on a server, if it works, you might close this bug.

Thanks,

Linda

------- Comment From sglass.com 2011-05-18 08:11 EDT-------
This is now working for IBM

customer has escalated the delay to senior management, we need to accelerate the cert, to the customer

(In reply to comment #22)
> customer has escalated the delay to senior management, we need to accelerate
> the cert, to the customer

This bug does not block certifications.