Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date-1.0.9-1.fc16.src.rpm Description: Package for creating and manipulating dates.
Please - handle locales - remove "Conflicts" - you can remove "Requires" of channel and Horde_Exception (implicitly required by Horde_Nls)
Any news on this package ?
Sorry for the delay: Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date-1.0.10-1.fc16.src.rpm
Created attachment 595410 [details] php-horde-Horde-Date.spec Generated by fedora-review 0.1.3
You could consider adding the implicit requires. * Horde_Exception and Horde_Util (for Horde_String) * php-common >= 5.2.0 You could also consider adding the "optional" dependency on Horde_Icalendar, when it will be approved, if this don't create a circular dependency nightmare. In Provides and %file, please use %{pear_name} where possible A %{pear_channel} could be usefull (pear.horde.org) Only blocker is (as you have drop other EL-5 stuff) MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.
Please also update to 1.0.11
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Date-1.0.11-1.fc16.src.rpm
Created attachment 598669 [details] php-horde-Horde-Date-review.txt Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
No blocker. Please consider updating BR php-pear to version 1.7.0 (from package.xml). Others implicitly requires could be add, but at your choice. == APPROVED ==
New Package SCM Request ======================= Package Name: php-horde-Horde-Date Short Description: Package for creating and manipulating dates in Horde Owners: nb Branches: el6 f16 f17 InitialCC:
Git done (by process-git-requests).