Description of problem: Pirut crashes when double clicking an item in optional packages. Steps to Reproduce: 1. Open optional packages for any group 2. Double click 3. Actual results: Component: pirut Summary: TB91835f44 GroupSelector.py:211:_pkgToggled:TypeError: GtkTreeModel.get_iter_from_string() argument 1 must be string, not tuple Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/pirut/GroupSelector.py", line 208, in _rowToggle self._pkgToggled(None, path) File "/usr/lib/python2.5/site-packages/pirut/GroupSelector.py", line 211, in _pkgToggled i = self.pkgstore.get_iter_from_string(path) TypeError: GtkTreeModel.get_iter_from_string() argument 1 must be string, not tuple Local variables in innermost frame: path: (3,) widget: None self: <pirut.GroupSelector.OptionalPackageSelector instance at 0x3e4f7e8>
Proposed patch: 211c211,214 < i = self.pkgstore.get_iter_from_string(path) --- > if type(path) == type(str): > i = self.pkgstore.get_iter_from_string(path) > else: > i = self.pkgstore.get_iter(path)
Thanks for the patch. Applied in git and will be in 1.3.26
*** Bug 354751 has been marked as a duplicate of this bug. ***
*** Bug 354761 has been marked as a duplicate of this bug. ***
*** Bug 360481 has been marked as a duplicate of this bug. ***
*** Bug 365481 has been marked as a duplicate of this bug. ***
Just fixed this in another way before searching in bugzilla. Posting here for reference. --- GroupSelector.py 2007-11-09 20:35:38.000000000 +0000 +++ /usr/lib/python2.5/site-packages/pirut/GroupSelector.py 2007-11-09 20:36:21.000000000 +0000 @@ -205,7 +205,7 @@ self.pkgstore.set_sort_column_id(1, gtk.SORT_ASCENDING) def _rowToggle(self, tree, path, col): - self._pkgToggled(None, path) + self._pkgToggled(None, str(path[0])) def _pkgToggled(self, widget, path): i = self.pkgstore.get_iter_from_string(path)
Would something like this be a better option? --- GroupSelector.py 2007-11-09 20:35:38.000000000 +0000 +++ /usr/lib/python2.5/site-packages/pirut/GroupSelector.py 2007-11-09 20:52:18.000000000 +0000 @@ -208,7 +208,10 @@ self._pkgToggled(None, path) def _pkgToggled(self, widget, path): - i = self.pkgstore.get_iter_from_string(path) + try: + i = self.pkgstore.get_iter_from_string(path) + except TypeError: + i = self.pkgstore.get_iter(path) sel = self.pkgstore.get_value(i, 0) pkg = self.pkgstore.get_value(i, 2).returnSimple('name') if sel and not self.ayum.simpleDBInstalled(name = pkg):
My €0.014 Not sure whether this bug should be marked with priority "Low", since it also shows up in the installer on the F8 DVD. It consistently crashes the installer and requires a reboot and running through the whole process again. This is even worse if you don't have (or want to use) your mouse, as I was scrolling through the package list with the cursor list and hitting "space". Depending on whether the checkbox in front of the package name has the focus or the package name, you either (de-)select the package or crash the installer.
*** Bug 374211 has been marked as a duplicate of this bug. ***
*** Bug 376381 has been marked as a duplicate of this bug. ***
*** Bug 368201 has been marked as a duplicate of this bug. ***
Flávio, how about this? In "/usr/lib/python2.5/site-packages/pirut/GroupSelector.py": def _pkgToggled(self, widget, path): i = self.pkgstore.get_iter_from_string(path) should be replaced with: def _pkgToggled(self, widget, path): i = self.pkgstore.get_iter(path) because the "row-activated" signal of GtkTree returns a path not a string representation of a path. See http://www.pygtk.org/docs/pygtk/class-gtktreeview.html#signal-gtktreeview--row-activated and http://pygtk.org/pygtk2reference/class-gtktreemodel.html#method-gtktreemodel--get-iter.
*** Bug 327141 has been marked as a duplicate of this bug. ***
Created attachment 263321 [details] Dump Created when trying to install webmin
Created attachment 263331 [details] Dump Created when trying to install webmin
Craig Lindley, just my 2 cents, I think that while your report bug is a pirut bug, it has nothing to do with the current bug. If this is true, you should add your comments to the proper bug (one with a "maximum recursion depth exceeded" error message) if it already exists or report a new bug.
pirut-1.3.26-1.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pirut'
This version seems to be working fine.
Yes, this version - pirut-1.3.26-1.fc8 - works fine for me too. Double click on an item checks/unchecks it.
pirut-1.3.27-1.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pirut'
pirut-1.3.28-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
pirut-1.3.28-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
*** Bug 425793 has been marked as a duplicate of this bug. ***
New versions of pirut have been released that should address these issues
*** Bug 427139 has been marked as a duplicate of this bug. ***
*** Bug 428659 has been marked as a duplicate of this bug. ***
*** Bug 436231 has been marked as a duplicate of this bug. ***
*** Bug 441422 has been marked as a duplicate of this bug. ***