Bug 603566
| Summary: | [abrt] crash in get_permissions_cb() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Doncho Gunchev <dgunchev> | ||||
| Component: | NetworkManager | Assignee: | Dan Williams <dcbw> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 13 | CC: | adam.w.royal, alessandromachado.vip, alex, allen.jaloola, arkiados, bugzilla, cquike, dcbw, d.duransseau, dematron1986, dimanechepurenko, djdm.public, dr.diesel, eblake, filip.salda, garybspencer, gewasiuk, gl, goofballadam, gordan, gtmkramer, hexanouns, hmelende, ideason88, james.brown, jensk.maps, jklimes, jrfuller, jurek.bajor, kparal, larieu, lgraves, linuxgelistirme, m1204101, marco, matteopacini.informatica, nicolas.mailhot, nomnex, postaljapan, projects.rg, redhat-bugzilla, reza.hdi, rianby64, RMuscaritolo, shadowbu, spoffley, stefan.thormar, steven, sunilpallikkara, tommy9874, tonysk8, tore, tuldok89, vbenes, vbl55, wanghuamiao, zaterio | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | i686 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | abrt_hash:74d448e22426bedac1cf6b26c1ee094011b105c5 | ||||||
| Fixed In Version: | NetworkManager-0.8.1-4.git20100817.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 614057 (view as bug list) | Environment: | |||||
| Last Closed: | 2010-08-23 22:06:10 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 614057 | ||||||
| Attachments: |
|
||||||
|
Description
Doncho Gunchev
2010-06-13 21:49:16 UTC
Created attachment 423695 [details]
File: backtrace
in ce-polkit-button.c we should allocate a structure that contains a pointer to the CEPolkitButton object and a boolean 'disposed' variable, and add that structure to a GSList in the private data of the CEPolkitButton, and pass that structure as the user data to nm_settings_system_interface_get_permissions(). Then in get_permissions_cb() we check the disposed member of that structure (which gets passed in as user data) and if it's disposed, we free the structure and return. If it's not disposed, process as normal, remove the structure from priv->permissions_calls GSList, and free the structure. In the CEPolkitButton dispose/finalize handler, run through the GSList of these structures and set 'disposed' to TRUE for each one (but *don't* free the structures since that has to happen in get_permissions_cb()). *** Bug 577000 has been marked as a duplicate of this bug. *** *** Bug 573208 has been marked as a duplicate of this bug. *** Upstream fix: 5978047977a17f35d9a3961023143506a73899f8 (master) 0d9a1ec1baa734187d1521ff213c11ddf6dcb3b1 (0.8.1) (In reply to comment #5) > Upstream fix: > > 5978047977a17f35d9a3961023143506a73899f8 (master) > 0d9a1ec1baa734187d1521ff213c11ddf6dcb3b1 (0.8.1) These fixes missed adding the PermInfo structure to the GSlist in CEPolkitButton priv data. That causes a crash when changing a system connection. Corrected upstream fix: 9737403b155d303cffbd08fe4a84c510ac995c8b (master) d1ed64f36588c953025972b73677a6c3af2d178f (0.8.1) Nevertheless, I think the code is still not completely correct and needs deeper inspection. The corrections try to prevent usage of disposed object in get_permissions_cb() and it works using 'info->disposed' flag. However, the issue is that get_permissions() is called even after finalize() and thus the CEPolkitButton object is officially 'dead' and should not be used any more. Another doubt, do we need a perm_calls GSList at all? *** Bug 610760 has been marked as a duplicate of this bug. *** *** Bug 613486 has been marked as a duplicate of this bug. *** Package: NetworkManager-gnome-1:0.8.1-2.el6 Architecture: x86_64 OS Release: Red Hat Enterprise Linux Server release 6.0 Beta (Santiago) How to reproduce ----- 1.I've created wpa network via nm-applet -> create new wireless network 2.while it was connecting I went into nm-c-e and edited the profile to add available to other users 3.entering root password - > crash *** Bug 613206 has been marked as a duplicate of this bug. *** NetworkManager-0.8.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-1.fc13 NetworkManager-0.8.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-1.fc12 NetworkManager-0.8.1-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update NetworkManager'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-1.fc13 Package: NetworkManager-gnome-1:0.8.1-2.el6 Architecture: x86_64 OS Release: Red Hat Enterprise Linux Workstation release 6.0 Beta (Santiago) How to reproduce ----- 1.Add new SSH connection to dolphin 2. 3. Comment ----- Was adding a new network folder in Dolphin. Attempts to add the remote folder failed multiple times due to a DNS issue. After fixing that, the attempt still failed and the app crashed. Upon restart of the dolphin, I was able to access the network folder without error or without another crash. (In reply to comment #14) > Package: NetworkManager-gnome-1:0.8.1-2.el6 > Architecture: x86_64 > OS Release: Red Hat Enterprise Linux Workstation release 6.0 Beta (Santiago) > > > How to reproduce > ----- > 1.Add new SSH connection to dolphin > 2. > 3. > What does that have in common with this bug?? NetworkManager-0.8.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. The d1ed64f36588c953025972b73677a6c3af2d178f (0.8.1) commit actually didn't exist. This results that NetworkManager-gnome-0.8.1-1.fc13, doesn't contain the fix and nm-connection-editor crashes. Sorry, mea culpa. I've cherry-picked the change to NMA_0_8_1 branch (even if now NMA_0_8 is used). Summary of commits: master: http://git.gnome.org/browse/network-manager-applet/commit/?id=9737403b155d303cffbd08fe4a84c510ac995c8b NMA_0_8: http://git.gnome.org/browse/network-manager-applet/commit/?h=NMA_0_8&id=9737403b155d303cffbd08fe4a84c510ac995c8b NMA_0_8_1: http://git.gnome.org/browse/network-manager-applet/commit/?h=NMA_0_8_1&id=003ea1ea91ac172d128d3b1832fcae0a7b7dcfab If this was fixed in NetworkManager-0.8.1-1.fc13 then how come it is still occurring in NetworkManager-0.8.1-2.el6? Actually, it's *not* fixed in NetworkManager-0.8.1-1.fc13, see comment #17. As far as RHEL6 is concerned, the fix *is* present in NetworkManager-0.8.1-3.el6 Unfixed. Reopening. Package: NetworkManager-gnome-1:0.8.1-2.el6 Architecture: i686 OS Release: Red Hat Enterprise Linux Workstation release 6.0 Beta (Santiago) Comment ----- after a clean installation of rhel 6 workstation beta 2, following the initial reboot I activated the network and the core was generated. rhel6beta2 is installed as a virtual client in vmware running on windows 7 host *** Bug 618590 has been marked as a duplicate of this bug. *** *** Bug 621869 has been marked as a duplicate of this bug. *** *** Bug 621873 has been marked as a duplicate of this bug. *** *** Bug 621952 has been marked as a duplicate of this bug. *** *** Bug 622006 has been marked as a duplicate of this bug. *** *** Bug 622146 has been marked as a duplicate of this bug. *** *** Bug 622153 has been marked as a duplicate of this bug. *** *** Bug 622288 has been marked as a duplicate of this bug. *** *** Bug 622339 has been marked as a duplicate of this bug. *** *** Bug 622783 has been marked as a duplicate of this bug. *** Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. Enable "connect automatically" on System eth0 connection 2. Click ok. 3. crash. Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: i686 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1.Change etho settings from manual to dhcp 2. 3. Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: i686 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. tried to save changes on eth0 2. 3. Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) Comment ----- I was editing the eth0 profile in order to switch between static IPv4 assignment and DHCP. *** Bug 623784 has been marked as a duplicate of this bug. *** *** Bug 623623 has been marked as a duplicate of this bug. *** *** Bug 623048 has been marked as a duplicate of this bug. *** *** Bug 623013 has been marked as a duplicate of this bug. *** *** Bug 623936 has been marked as a duplicate of this bug. *** *** Bug 622954 has been marked as a duplicate of this bug. *** *** Bug 623821 has been marked as a duplicate of this bug. *** Fixes for this are coming, for example: http://koji.fedoraproject.org/koji/buildinfo?buildID=190062 (f14) http://koji.fedoraproject.org/koji/buildinfo?buildID=190055 (f13) http://koji.fedoraproject.org/koji/buildinfo?buildID=190056 (f12) but we need to do another rebuild to fix a dbus-glib security issue. In the mean time feel free to use the above packages. *** Bug 624157 has been marked as a duplicate of this bug. *** Package: NetworkManager-gnome-1:0.8.1-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Branched) How to reproduce ----- 1. Edited 'System eth0' in connection editor, set it to connect automatically 2. Closed connection editor, NM started to connect to eth0 3. Right after that ABRT reported this crash, but NM seems to be working fine (I'm connected) *** Bug 624627 has been marked as a duplicate of this bug. *** *** Bug 544175 has been marked as a duplicate of this bug. *** NetworkManager-0.8.1-4.git20100817.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-4.git20100817.fc12 NetworkManager-0.8.1-4.git20100817.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-4.git20100817.fc13 NetworkManager-0.8.1-4.git20100817.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-4.git20100817.fc14 Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) Comment ----- Occurred after setting the eth0 connection to a static IP addr instead of auto. Package: NetworkManager-gnome-1:0.8.1-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Branched) How to reproduce ----- 1. 2. 3. recreated this bug for bug #623434 Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. Change eth0 from DHCP to DHCP address only 2. Add DNS servers 3. Apply Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- I opened Network Manager and configured the Ethernet interface to use IPv6 on the 'Automatic' setting. Then clicked 'OK'. When I did, the crash happened as the network interface was reset. Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1.attempt to edit the the network interface while it is active 2. 3. Comment ----- attempt to edit the network interface while it is active NetworkManager-0.8.1-5.git20100818.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-5.git20100818.fc14 NetworkManager-0.8.1-4.git20100817.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update NetworkManager'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-4.git20100817.fc13 *** Bug 624867 has been marked as a duplicate of this bug. *** *** Bug 625823 has been marked as a duplicate of this bug. *** Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1.edit connections.. 2.wired ->eth0 ->edit 3.ipv4 4.set new gateway 5.apply & root password 6.Crash Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: i686 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1.Edit network connections in any way and it fails and generates the error 2. 3. Comment ----- I am using network manager currently, but even if I don't, I am prohibited from editing the connections by this error. Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. Crash happened just after setting a static IP from within NM and hitting the OK button 2. I frequently set a static IP and this does not normally happen, so not always reproducable. Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. Change settings for wireless mode 2. validate (root passeword needed) 3. then it crashed Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. Open Network Connections. (System -> Preferences -> Network Connections) 2. Goto the VPN Tab and proceed to add a Point-to-Point Tunneling Protocol (PPTP) VPN Connection. 3. Fill out the needed information. 4. Check the box Available to all users and click Apply. 5. Type in the root password. 6. A dialog box with only a Close button pops up: Connection add failed Saving connection failed: (0) Can't write connection type 'vpn' 7. Clicking Close causes this crash with ABRT detecting it. Comment ----- All the information needed is listed above. I attempted to add a PPTP VPN using the gateway ukfree.hideipvpn.com. (In reply to comment #49) > NetworkManager-0.8.1-4.git20100817.fc13 has been submitted as an update for > Fedora 13. > http://admin.fedoraproject.org/updates/NetworkManager-0.8.1-4.git20100817.fc13 Tried to delete, recreate and modify all used devices. Everything (LAN, WLAN & Broadband) works fine now. Thx a lot! ;-) Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: i686 OS Release: Fedora release 13 (Goddard) Comment ----- Changed DHCP connection to Manual... *** Bug 626104 has been marked as a duplicate of this bug. *** *** Bug 626100 has been marked as a duplicate of this bug. *** Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: i686 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. Changed DNS setting on NAT Router 2. eth0 was disconnected 3. confirmed eth0 setting in the Network Connection applet 4. Crash report generated Comment ----- After changing DNS server setting in my router the eth0 was disconnected. I confirmed the settings in network connection applet. During the automatic reconnection, a crash occured and the ABRT generated an automatic bug report. Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: i686 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. Right-click NetworkManager Applet 0.8.1 2. Click edit connections 3. Edit the network connection info 4. Click the IPv4 tab 5. Change the method to Automatic (DHCP) Addresses only 6. Add DNS Server, then OK 7. Crash Comment ----- Always happens everytime I edit the connection settings Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: x86_64 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1. set a static ip address 2. click on apply button 3. Package: NetworkManager-gnome-1:0.8.1-1.fc13 Architecture: i686 OS Release: Fedora release 13 (Goddard) How to reproduce ----- 1.Made last update 2.if wireless is working and plug ethernet then 3.crash report Comment ----- If connect eth0 when wlan0 is working already then network manager becomes crazy switching from one connection to other. If shut down wireless then ethernet stops working. If unplug ethernet and switch on wireless then all works normally. NetworkManager-0.8.1-4.git20100817.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. NetworkManager-0.8.1-5.git20100818.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. *** Bug 622795 has been marked as a duplicate of this bug. *** NetworkManager-0.8.1-6.git20100831.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/NetworkManager-0.8.1-6.git20100831.fc13 NetworkManager-0.8.1-6.git20100831.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/NetworkManager-0.8.1-6.git20100831.fc12 NetworkManager-0.8.1-6.git20100831.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |