Bug 785436 (Horde_Exception)
| Summary: | Review Request: php-horde-Horde-Exception - Horde Exception Handler | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Bebout <nb> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, notting, package-review |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-21 23:49:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 785424, 785432 | ||
| Bug Blocks: | 785438, 785442, 785444, 785446, 785447, 785449, 785450, 785451, 785453, 785455, 785460, 785463, 785465, 785466, 785468, 785472, 785473, 785474, 785475, 785476, 785477, 785485, 785492, 785494, 785495, 874677, 874688, 894563, 894570, 908361, 908371, 909588, 909706, 909713 | ||
|
Description
Nick Bebout
2012-01-28 23:38:15 UTC
According to upstream (package.xml), this requires:
BuildRequires: php-pear(PEAR) >= 1.7.0
Requires: php-common >= 5.2.0
Avoir conflicts
pear-pear(pear.horde.org/Horde_Translation) >= 1.0.0
pear-pear(pear.horde.org/Horde_Translation) < 2.0.0
%file
%{pear_xmldir}/%{name}.xml
%{pear_phpdir}/Horde/Exception
%{pear_phpdir}/Horde/Exception.php
%{pear_datadir}/Horde_Exception
%{pear_testdir}/Horde_Exception
Updated. License is LGPLv2+ This package must handle locales properly, http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files Updated We need to discuss about locales in this package (and probably the other php-horde-*)
With current spec
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/ar/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/bg/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/bs/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/ca/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/cs/LC_MESSAGES/Horde_Exception.mo
warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/da/LC_MESSAGES/Horde_Exception.mo
...
%dir %{pear_datadir}/Horde_Exception should be enough, but it also contains .pot and .po files.
I really don't think this are needed, as Horde_Translation use "gettext" by default (but I don't know if others backend are available in Horde stack, which requires .po)
Could you please ask upstream about this ?
(better solution to exclude files, is to delete lines in the package.xml, to keep "pear list-files" report consistent)
I think this one is ready to review. I made the changes you suggested via email. it seems you have forgotten to update/upload the new spec/srpm (last is January 30) I've uploaded it now. This one is ok (Package must own all directories that it creates.) You could removed Requires: php-channel(pear.horde.org) As this package is already required by php-pear(pear.horde.org/Horde_Translation) This package is APPROVED (must wait for Horde_Translation before importing to repo) New Package SCM Request ======================= Package Name: php-horde-Horde-Exception Short Description: Provides the default exception handlers for the Horde Application Framework Owners: nb Branches: f16 f17 el6 InitialCC: New Package SCM Request ======================= Package Name: php-horde-Horde-Exception Short Description: Provides the default exception handlers for the Horde Application Framework Owners: nb Branches: f16 f17 el6 InitialCC: Git done (by process-git-requests). |